From patchwork Sun May 8 07:17:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 35699 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp2441805pzb; Sun, 8 May 2022 00:17:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaZRwWDPmFyAFADMC5gjl0pblSv+G+AmYSBFR+KQF4Vq8m8caFQCXgqHhONV1D0gmx/0+H X-Received: by 2002:a05:6402:948:b0:425:ea37:96b8 with SMTP id h8-20020a056402094800b00425ea3796b8mr11505391edz.90.1651994252804; Sun, 08 May 2022 00:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651994252; cv=none; d=google.com; s=arc-20160816; b=e48PJroYG7d1CXJS4WCKCi8QlYV0PL/X7qwmx6JiPHYfAegsWMHla0J57xtRIaSU2Z +2QhZKOrVFyt1DdJjJOTWpwhQdj92Bkk1Jczdq2szc4GqiKpCVSGMjpDFhUHyYJGyCru hZiPAos4Pfd9IQI2ssIOjYQ+OO7ERhwhVc3lJb88qsgEBHrVAX4m+J9bjEr+LTcJPYGg YeJyJmGHM+x8NwDJct8vUakLwBNtzPXpGOMynqo5RlEq/Y7ciQvtFHr4zsYIU3T6+3sW kIKjckWN5ku3PaeWQTClLu91h0o8SSioipk168vHw8ssczr7OVL55Jvpto1u4hXMETqZ RnOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=degSEhZ+QTezlry33r2chAq4I94zCQbj8NZh6A8j+Og=; b=tfPsDzXMunfMOFG0qeFm7CK3Gwj2sk8JEiatHDdbVGyxwz2q9Df8lE4ZZ/bum2CfUw n+JgMtTF7+OqS66DZ/0zSbMopCkY/ZyDwd2kXnefQ8pa67ukjJ6borOdGaV4YDDxQuYi +mxhklH1gtRmPUp7fvkco2VHdSHG0tPJO/mqhH70k0Jz3XyPX7iq32HzY7DWgFbZ2Ky8 TGKT6mWCmU0x89uN2WI7kFpoV13Fvm+HGtTNJXBK0zmQrN0cOvruUcdEoFbFoejjkxiA apPl1kK0hUnqnPW1AfaBJqDFXJUMxQ1cN8g6hyE6TKrgBMOzfUurEdGnxWrrZiitsSJ4 xrNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=iQcyd7CR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b13-20020a170906150d00b006f3b9995f9bsi8903775ejd.448.2022.05.08.00.17.31; Sun, 08 May 2022 00:17:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=iQcyd7CR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 52AE668B2D5; Sun, 8 May 2022 10:17:18 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34FAB6881B1 for ; Sun, 8 May 2022 10:17:11 +0300 (EEST) Received: by mail-pj1-f54.google.com with SMTP id w17-20020a17090a529100b001db302efed6so10291510pjh.4 for ; Sun, 08 May 2022 00:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=95AOTwW+yvbGkwqCEfs52mVlmD0j+gXrTvaP1KAKths=; b=iQcyd7CRDveru9YKAeTZWto/I4byFckz6cI6Qg1GwX4aHmT8gNJnNZUw8Ov23WnouD ixeGMwvlXUvTR7szGjElVvvj3quN42GFyBP9Fjl9tvDbw4tHLiphKy6xmmHfkhFND2C1 0jJMKY1ptWHhHsGf0xrwHLot12lceIJdaewvPvR0D0RxJWC2RShLyGr6N+eImiJTWhHw EByI7DjLtrYavWl1BX7dCCBqsQ0ZyaM+0DR8LILU/pZhb302H802SFYow6iQRPt/IYnd 6GuPrqVf9pS3CdbcyIXL6Qe330Ru9C02dJsXc7AeVGBderYm0t4Rdy3MRZmDJ59aBK9P IVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=95AOTwW+yvbGkwqCEfs52mVlmD0j+gXrTvaP1KAKths=; b=c4+mdOuPaShCfmqWvxx+QanbPYFu6BeC18VDECJY3V+ukKexXzArFI/eA5RiD/K3Dr bh4IiX1lZWzxvEX7z9unzNJDtmSPIs6UFPWNjS/eI+nNh6C7UBl55jbikXfpCNfStigg Je06dcLIcZuuBgAx188cAQIJKZP+vqtYom6UPDJZzlHLJ6Ddldt9ib8mSYa8g9zd0kc7 o7+v0oXLW6QzjBLOIE9qledHMkld94hD1emLwKHhY9aMQeWnWbjyovIi6dz7flLFJq8D Qr0Y60eBxu6MZ4QP4nvSnPetog0qwez9kfOctzybQyR7U5X+FH3DuLgV0kjY4InVCGmt q9mQ== X-Gm-Message-State: AOAM533UGDlT9D3u4KP3sjz6yoY4LZHljvV0IoHecV025rLxkNtxOT2R b972jurbwZklGQiq8bdwP40+txCfvkM= X-Received: by 2002:a17:902:e851:b0:15e:d129:fb20 with SMTP id t17-20020a170902e85100b0015ed129fb20mr10715315plg.140.1651994229433; Sun, 08 May 2022 00:17:09 -0700 (PDT) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id c3-20020a170902b68300b0015eee3ab203sm4239607pls.49.2022.05.08.00.17.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 May 2022 00:17:09 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 8 May 2022 15:17:01 +0800 Message-Id: <1651994221-11660-2-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1651994221-11660-1-git-send-email-lance.lmwang@gmail.com> References: <1651994221-11660-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 3jcoqASwKye7 From: Limin Wang some samples include both A53 and SCTE20 data. Before the commit, both of the will be exported, so the CC data will be repeated or garbarge as they're using the same frame side data. If you know your samples include only one of them, You can export by +a53cc+scte20. After the commit, the default will not export MPEG2 A53/SCTE20/DVD CC side data, please export on demand. Signed-off-by: Limin Wang --- doc/codecs.texi | 10 ++++++++++ libavcodec/avcodec.h | 16 +++++++++++++++- libavcodec/mpeg12dec.c | 6 +++--- libavcodec/options_table.h | 3 +++ libavcodec/version.h | 2 +- tests/fate/ffmpeg.mak | 2 +- tests/fate/subtitles.mak | 6 +++--- 7 files changed, 36 insertions(+), 9 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 5e10020900..4cced983b9 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -662,6 +662,16 @@ for codecs that support it. At present, those are H.264 and VP9. @item film_grain Export film grain parameters through frame side data (see @code{AV_FRAME_DATA_FILM_GRAIN_PARAMS}). Supported at present by AV1 decoders. +@item a53cc +Export A53 CC through frame side data (see @code{AV_FRAME_DATA_A53_CC}) +for codecs that support it. +@item scte20cc +Export SCTE20 CC through frame side data (see @code{AV_FRAME_DATA_A53_CC}) +for codecs that support it. +@item dvdcc +Export DVD CC through frame side data (see @code{AV_FRAME_DATA_A53_CC}) +for codecs that support it. + @end table @item threads @var{integer} (@emph{decoding/encoding,video}) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4dae23d06e..25fd4de2fe 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -360,7 +360,21 @@ typedef struct RcOverride{ * Do not apply film grain, export it instead. */ #define AV_CODEC_EXPORT_DATA_FILM_GRAIN (1 << 3) - +/** + * Decoding only. + * Export A53 CC through frame side data + */ +#define AV_CODEC_EXPORT_DATA_A53_CC (1 << 4) +/** + * Decoding only. + * Export SCTE20 CC through frame side data + */ +#define AV_CODEC_EXPORT_DATA_SCTE20_CC (1 << 5) +/** + * Decoding only. + * Export DVD CC through frame side data + */ +#define AV_CODEC_EXPORT_DATA_DVD_CC (1 << 6) /** * The decoder will keep a reference to the frame and may reuse it later. */ diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e9bde48f7a..032cb8f9b1 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2203,7 +2203,7 @@ static int mpeg_decode_a53_cc(AVCodecContext *avctx, { Mpeg1Context *s1 = avctx->priv_data; - if (buf_size >= 6 && + if (buf_size >= 6 && (avctx->export_side_data & AV_CODEC_EXPORT_DATA_A53_CC) && p[0] == 'G' && p[1] == 'A' && p[2] == '9' && p[3] == '4' && p[4] == 3 && (p[5] & 0x40)) { /* extract A53 Part 4 CC data */ @@ -2224,7 +2224,7 @@ static int mpeg_decode_a53_cc(AVCodecContext *avctx, avctx->properties |= FF_CODEC_PROPERTY_CLOSED_CAPTIONS; } return 1; - } else if (buf_size >= 2 && + } else if (buf_size >= 2 && (avctx->export_side_data & AV_CODEC_EXPORT_DATA_SCTE20_CC) && p[0] == 0x03 && (p[1]&0x7f) == 0x01) { /* extract SCTE-20 CC data */ GetBitContext gb; @@ -2269,7 +2269,7 @@ static int mpeg_decode_a53_cc(AVCodecContext *avctx, avctx->properties |= FF_CODEC_PROPERTY_CLOSED_CAPTIONS; } return 1; - } else if (buf_size >= 11 && + } else if (buf_size >= 11 && (avctx->export_side_data & AV_CODEC_EXPORT_DATA_DVD_CC) && p[0] == 'C' && p[1] == 'C' && p[2] == 0x01 && p[3] == 0xf8) { /* extract DVD CC data * diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index e72b4d12b6..3c6db07459 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -88,6 +88,9 @@ static const AVOption avcodec_options[] = { {"prft", "export Producer Reference Time through packet side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_PRFT}, INT_MIN, INT_MAX, A|V|S|E, "export_side_data"}, {"venc_params", "export video encoding parameters through frame side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_VIDEO_ENC_PARAMS}, INT_MIN, INT_MAX, V|D, "export_side_data"}, {"film_grain", "export film grain parameters through frame side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_FILM_GRAIN}, INT_MIN, INT_MAX, V|D, "export_side_data"}, +{"a53cc", "export A53 CC through frame side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_A53_CC}, INT_MIN, INT_MAX, V|D, "export_side_data"}, +{"scte20cc", "export SCTE20 CC through frame side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_SCTE20_CC}, INT_MIN, INT_MAX, V|D, "export_side_data"}, +{"dvdcc", "export DVD CC through frame side data", 0, AV_OPT_TYPE_CONST, {.i64 = AV_CODEC_EXPORT_DATA_DVD_CC}, INT_MIN, INT_MAX, V|D, "export_side_data"}, {"time_base", NULL, OFFSET(time_base), AV_OPT_TYPE_RATIONAL, {.dbl = 0}, 0, INT_MAX}, {"g", "set the group of picture (GOP) size", OFFSET(gop_size), AV_OPT_TYPE_INT, {.i64 = 12 }, INT_MIN, INT_MAX, V|E}, {"ar", "set audio sampling rate (in Hz)", OFFSET(sample_rate), AV_OPT_TYPE_INT, {.i64 = DEFAULT }, 0, INT_MAX, A|D|E}, diff --git a/libavcodec/version.h b/libavcodec/version.h index 735c8b813c..87b7284a95 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -29,7 +29,7 @@ #include "version_major.h" -#define LIBAVCODEC_VERSION_MINOR 27 +#define LIBAVCODEC_VERSION_MINOR 28 #define LIBAVCODEC_VERSION_MICRO 100 #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 9d14a96e13..a403aa27a1 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -109,7 +109,7 @@ FATE_SAMPLES_FFMPEG-$(call ALLYES, LAVFI_INDEV MOVIE_FILTER FILE_PROTOCOL \ += fate-ffmpeg-fix_sub_duration fate-ffmpeg-fix_sub_duration: CMD = fmtstdout srt -fix_sub_duration \ -real_time 1 -f lavfi \ - -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v[out0+subcc]" + -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v:dec_opts=export_side_data=a53cc[out0+subcc]" FATE_STREAMCOPY-$(call ALLYES, EAC3_DEMUXER MOV_MUXER) += fate-copy-trac3074 fate-copy-trac3074: $(SAMPLES)/eac3/csi_miami_stereo_128_spx.eac3 diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak index bc464edce6..bb1dc7434e 100644 --- a/tests/fate/subtitles.mak +++ b/tests/fate/subtitles.mak @@ -2,13 +2,13 @@ FATE_SUBTITLES_ASS-$(call ALLYES, AQTITLE_DEMUXER TEXT_DECODER ICONV) += fate-su fate-sub-aqtitle: CMD = fmtstdout ass -sub_charenc windows-1250 -i $(TARGET_SAMPLES)/sub/AQTitle_capability_tester.aqt FATE_SUBTITLES_ASS-$(call ALLYES, AVDEVICE LAVFI_INDEV CCAPTION_DECODER MOVIE_FILTER MPEGTS_DEMUXER) += fate-sub-cc -fate-sub-cc: CMD = fmtstdout ass -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v[out0+subcc]" +fate-sub-cc: CMD = fmtstdout ass -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v:dec_opts=export_side_data=a53cc[out0+subcc]" FATE_SUBTITLES_ASS-$(call ALLYES, AVDEVICE LAVFI_INDEV CCAPTION_DECODER MOVIE_FILTER MPEGTS_DEMUXER) += fate-sub-cc-realtime -fate-sub-cc-realtime: CMD = fmtstdout ass -real_time 1 -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v[out0+subcc]" +fate-sub-cc-realtime: CMD = fmtstdout ass -real_time 1 -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/Closedcaption_rollup.m2v:dec_opts=export_side_data=a53cc[out0+subcc]" FATE_SUBTITLES_ASS-$(call ALLYES, AVDEVICE LAVFI_INDEV CCAPTION_DECODER MOVIE_FILTER MPEGTS_DEMUXER) += fate-sub-cc-scte20 -fate-sub-cc-scte20: CMD = fmtstdout ass -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/scte20.ts[out0+subcc]" +fate-sub-cc-scte20: CMD = fmtstdout ass -f lavfi -i "movie=$(TARGET_SAMPLES)/sub/scte20.ts:dec_opts=export_side_data=scte20cc[out0+subcc]" FATE_SUBTITLES_ASS-$(call DEMDEC, ASS, ASS) += fate-sub-ass-to-ass-transcode fate-sub-ass-to-ass-transcode: CMD = fmtstdout ass -i $(TARGET_SAMPLES)/sub/1ededcbd7b.ass