From patchwork Fri Dec 23 15:04:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Bramini X-Patchwork-Id: 39745 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp562938pzb; Fri, 23 Dec 2022 07:04:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXsDIgR8uhQKC9A2KbCEivrqgaxQ8oL3+E2pw/SgrJX1EKYxo7Jwl3fjVcAu0DVVb55LisLt X-Received: by 2002:a17:907:c301:b0:7fd:ecee:c8ba with SMTP id tl1-20020a170907c30100b007fdeceec8bamr12089388ejc.42.1671807882535; Fri, 23 Dec 2022 07:04:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671807882; cv=none; d=google.com; s=arc-20160816; b=tM+++QirPH8d9eO0Y1TD6MnofpmNTj5YCwSORcA2M7KFJzpkTWqAnaz3LMjkCksAqZ OWZVj2QtSuOBAkCDxVFiwZNbfI51uRf6gPTrQLDzvBxcp3AcFkRUAXxxaX5k924/Az+v TvAO7752pUNLd0zkFd9qJWL7Ih8I+G8SAAaqIVv4Ri0BPK15rFDvsJsa6b2TDquwZ1cc bsXU91rhKJZrIX9pnOSwdWOUF6pXtxKnXUptyEeGANKDBLmN2b5BndU4JZIfmT1cxQQK M3eIQtwwWgeYesyQASQBRsJXkgkKDvxWl3ZAbjltP7iSkI5rKSgEV9sHi3Hznx4e8Qu9 +i6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:importance :mime-version:references:in-reply-to:message-id:to:from:date :dkim-signature:delivered-to; bh=bup+nG0nXB1UC46BnvfSuhFzT+Ng1hSyAzzJZxETT+Y=; b=Tkw9LLF0DE69AHrClnGnzhNxpV6nTzAHHCpx0bS6tY6/Y4KzigBI7b8hGV6CvRLY1A jFN9dLO0Nj/lvcESH/UCIBEfEJeC/moEPZpnuZc9ZHKBlz/YTQOvm6Qek0lRcqq/IYvu G4UJbxth4tXFXInruk+dKQCJfJF5xm9jEFz2BI5yf8jOSbYCgMhKlE1OX5NYxhj1+2OC cuW8LrdxfdyiurC4KNlWBZt1uNPSSbc9pRpWJWSX93gm1gx44X4Sr4nm7MSX0DKI6LhV B3dEjZ7GUR+W531HFlNC3BPRBDcwfdDfzx75LW7HBf8R8nqeRIZXvuL2dMuR4Rk6d7Q1 ZDhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@libero.it header.s=s2021 header.b=mGz+gy3N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v1-20020a056402348100b004511d552be3si3320750edc.4.2022.12.23.07.04.41; Fri, 23 Dec 2022 07:04:42 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@libero.it header.s=s2021 header.b=mGz+gy3N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 918E768BA7C; Fri, 23 Dec 2022 17:04:38 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from libero.it (smtp-36-i2.italiaonline.it [213.209.12.36]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5FE1268092B for ; Fri, 23 Dec 2022 17:04:32 +0200 (EET) Received: from oxapps-13-074.iol.local ([10.101.8.84]) by smtp-36.iol.local with ESMTPA id 8jb5pSFDSTZGI8jb5pEcX5; Fri, 23 Dec 2022 16:04:31 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2021; t=1671807871; bh=OcivcDpC3/76/lY0zw870eRslAhcvQUUFf73oHv8jqY=; h=From; b=mGz+gy3Nz/PfzjFvL4o73BScqXhSXD+7GvVDD/Gy9/j6N5QIbUmA5b2cqcvhBgaTb CyIKG92egABhHXze/2yLIB8V59hhle7/qVSTDO5/mLnTVte5+UfrQ8px043eF2Lw9V NZpoi587VVBySg6WqIlsBkgKo3m5Key8GUdJbKLX6tAP6Q/A0fGBsCae1pzUeotOg+ OHgaN0Qdhe9PKDhUlxO416pIi+3jOdb9KZlkcU3AlJswwpXdBgR1th1aKWnEsuRdxF RX89fX5JiV6uEcxLjINbwQqDlBjqY45FiHqW9OIY85gruXu32kXUcNPtODB5II2AqQ T9me16J/tkM7g== X-CNFS-Analysis: v=2.4 cv=NZsglUP4 c=1 sm=1 tr=0 ts=63a5c37f cx=a_exe a=+htklNqd2nUvwHGxo3khsw==:117 a=DtqkoXZ5MxIA:10 a=FDU5-MRIzX4A:10 a=4UeiKzbevKA590Rjo-IA:9 a=QEXdDO2ut3YA:10 a=QXUnqtUjQfTwK7_1xl0A:9 Date: Fri, 23 Dec 2022 16:04:31 +0100 (CET) From: Carlo Bramini To: "ffmpeg-devel@ffmpeg.org" Message-ID: <1658097660.1149740.1671807871813@mail1.libero.it> In-Reply-To: <1653614161.1115544.1671790568974@mail1.libero.it> References: <1653614161.1115544.1671790568974@mail1.libero.it> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev51 X-Originating-IP: 93.63.107.146 X-Originating-Client: open-xchange-appsuite x-libjamsun: 3Lkhd38X9gBj6q+TJqhplMeebCJF4AwZ x-libjamv: vvH0bhphEpI= X-CMAE-Envelope: MS4xfIgdRNRfgq9B9JkjM+bo3bVE4CSHEUqog5z692R3A6r0X3wEN5cIaxSGO8nWGtTJSS0mQOZTUCFsJHh1PxfqGG+6sG3jTebJQJgqhYPynNFssetU1kI9 suWxkGe4ohRxktUrGUD5mRIxFn6IKA1xBov0IqviXM0qWM9QfaSmh4m7/Heq0nSZ/mQklND4vCJBmCBByPuq4yGUyyB1N5jJI/A= Subject: [FFmpeg-devel] [PATCH] ffmpeg-3.4.12 does not build (i686-w64-mingw32) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jzslSrA81jlh Hello, I tried to build ffmpeg-3.4.12, which is the last one supporting Windows XP, but it fails to compile the resource file for Windows. Running verbose build, it prints this output on the console: > $ make V=1 > i686-w64-mingw32-windres -I. -Isrc/ --preprocessor "i686-w64-mingw32-gcc -E -xc-header -DRC_INVOKED -MMD -MF libavdevice/avdeviceres.d -MT libavdevice/avdeviceres.o" -o libavdevice/avdeviceres.o /home/carlo/packages/ffmpeg/mingw64-i686-ffmpeg-3.4.12-1.noarch/src/ffmpeg-3.4.12/libavdevice/avdeviceres.rc > /bin/sh: i686-w64-mingw32-gcc -E -xc-header -DRC_INVOKED -MMD -MF libavdevice/avdeviceres.d -MT libavdevice/avdeviceres.o: No such file or directory > make: *** [/home/carlo/packages/ffmpeg/mingw64-i686-ffmpeg-3.4.12-1.noarch/src/ffmpeg-3.4.12/ffbuild/common.mak:86: libavdevice/avdeviceres.o] Error 1 I found a solution by comparing ffbuild/common.mak between this version and the latest 5.1.2, which has already fixed this bug. So, I'm wondering if it could be possible to apply the same patch for fixing this tiny issue in the next maintenance release of 3.4.x branch, if it will happen in the future. I attached that patch in this email for reference, if somebody can import that line from development sources. Sincerely, Carlo Bramini. --- origsrc/ffmpeg-3.4.12/ffbuild/common.mak 2022-10-27 22:21:00.000000000 +0200 +++ src/ffmpeg-3.4.12/ffbuild/common.mak 2022-12-23 10:46:32.733625900 +0100 @@ -83,7 +83,7 @@ COMPILE_NVCC = $(call COMPILE,NVCC) -$(if $(ASMSTRIPFLAGS), $(STRIP) $(ASMSTRIPFLAGS) $@) %.o: %.rc - $(WINDRES) $(IFLAGS) --preprocessor "$(DEPWINDRES) -E -xc-header -DRC_INVOKED $(CC_DEPFLAGS)" -o $@ $< + $(WINDRES) $(IFLAGS) $(foreach ARG,$(CC_DEPFLAGS),--preprocessor-arg "$(ARG)") -o $@ $< %.i: %.c $(CC) $(CCFLAGS) $(CC_E) $<