From patchwork Sun Nov 20 00:07:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Cadhalpun X-Patchwork-Id: 1493 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.90.1 with SMTP id o1csp856408vsb; Sat, 19 Nov 2016 16:07:54 -0800 (PST) X-Received: by 10.28.25.135 with SMTP id 129mr5560570wmz.122.1479600473934; Sat, 19 Nov 2016 16:07:53 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r1si7704963wmf.122.2016.11.19.16.07.52; Sat, 19 Nov 2016 16:07:53 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE dis=NONE) header.from=googlemail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5CF4689CFD; Sun, 20 Nov 2016 02:07:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEA83689980 for ; Sun, 20 Nov 2016 02:07:42 +0200 (EET) Received: by mail-wm0-f67.google.com with SMTP id a20so16437859wme.2 for ; Sat, 19 Nov 2016 16:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=YItQuqzjcu5LY+OE77Qp/pNBviWRWplw45LkbPw/DRc=; b=UIvznHblTgf8QP4iHfyK0ogfQZ9ja7MmQutHt0c+NKaFaGy5gvPut+9aR4m4f/V7AA uUlIjDrATWWJY32Gy+WjauLCkG268c+rj1l6ImTUBrTz8FxSYN9FMMIG0JJYGLEutCFb v6rHmFeTEeuBaz+kBLjst3tSeOYqg5fILUbDjO9mNGBPdpb8qpmO9hMoBLbdy9rqjPya m8rMd2WAMcE2Z6xa6juPIefkosqmoBxVg7YUpqllNlPP3u4TRTgtzngvul7tPOlvpEeS I49SDDZQD1Q8mO7qllrDw2edsibVMRkqWmY8C+i6+UsbB+jo+1/MzP/rMWuVEBrsFgk4 eVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=YItQuqzjcu5LY+OE77Qp/pNBviWRWplw45LkbPw/DRc=; b=a8rW0dOyJueAiP7QIgMCGrRYTjHQz0jnbUNsMUniYc1HpWyIiAQbuoPFPzBGWLJ7Xe P2OXKPKszxs0dZG1u5O5qRWybxcPpGwlfisgFK7L9J2rNrfQj917+97uUgfm8Twv2poO mu/PWgj9ZmlCP+lRjmohwaqEj7adBpQRtPsMSBNI5eZ24M9LrqrPo9wPRlqYhJ0wArsQ BZfVgeMY0YTpEivetZfs5TiMSOYHPYqY/KILlnHup3cuLrZOIF8pDXVrLmkl37AVbu3h fO+KXcN/Rq1Oi6P6EyNVPPZ5lLwVakNh8y3KjJCvIxcFKgloNCwOnYhZcQWFJnuDqUv5 yBeg== X-Gm-Message-State: AKaTC033teCo6qetKLGUEERCfAKJTjmVIXh9vvfLEbnzNRRFtihTiJmkDocWRXfoAyAy4w== X-Received: by 10.28.172.3 with SMTP id v3mr6571677wme.133.1479600464298; Sat, 19 Nov 2016 16:07:44 -0800 (PST) Received: from [192.168.2.21] (p5B095CF1.dip0.t-ipconnect.de. [91.9.92.241]) by smtp.googlemail.com with ESMTPSA id w79sm11167375wmw.0.2016.11.19.16.07.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Nov 2016 16:07:43 -0800 (PST) From: Andreas Cadhalpun X-Google-Original-From: Andreas Cadhalpun To: FFmpeg development discussions and patches Message-ID: <1fac701c-6989-5e4f-3536-64d458e4e09e@googlemail.com> Date: Sun, 20 Nov 2016 01:07:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is enabled. This fixes build failures due to: error: 'asm' operand has impossible constraints Signed-off-by: Andreas Cadhalpun --- A build log of a failed build with gcc 4.9 is available at: https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=i386&ver=7%3A3.2-2~bpo8%2B1&stamp=1478791165 --- configure | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/configure b/configure index b5bfad6..8794580 100755 --- a/configure +++ b/configure @@ -5364,6 +5364,19 @@ EOF enabled ssse3 && check_inline_asm ssse3_inline '"pabsw %xmm0, %xmm0"' enabled mmxext && check_inline_asm mmxext_inline '"pmaxub %mm0, %mm1"' + case "$toolchain" in + hardened) + if enabled x86_32; then + # When PIE is enabled on x86_32, gcc before gcc-5 reserves a register for the GOT. + case $gcc_basever in + 2*|3*|4*) + disable ebp_available + ;; + esac + fi + ;; + esac + if ! disabled_any asm mmx yasm; then if check_cmd $yasmexe --version; then enabled x86_64 && yasm_extra="-m amd64"