| Message ID | 201608271736.05561.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Headers | show |
On Sat, Aug 27, 2016 at 05:36:05PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5786. > > Please comment, Carl Eugen > httpauth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 9a5fad1ac41b9eab840a6664e54c5998de6b4e98 0001-lavf-httpauth-Do-case-insensitive-http-header-checks.patch > From 3b9380e0a4e715dcbc3ff508235ccad14a01ad37 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos <cehoyos@ag.or.at> > Date: Sat, 27 Aug 2016 17:27:48 +0200 > Subject: [PATCH] lavf/httpauth: Do case-insensitive http header checks. > > Fixes ticket #5786. LGTM thx [...]
2016-09-02 4:07 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>: >> Subject: [PATCH] lavf/httpauth: Do case-insensitive http header checks. >> >> Fixes ticket #5786. > > LGTM Patch applied. Thank you, Carl Eugen
diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c index 18cf36b..2d42ab2 100644 --- a/libavformat/httpauth.c +++ b/libavformat/httpauth.c @@ -90,7 +90,7 @@ static void choose_qop(char *qop, int size) void ff_http_auth_handle_header(HTTPAuthState *state, const char *key, const char *value) { - if (!strcmp(key, "WWW-Authenticate") || !strcmp(key, "Proxy-Authenticate")) { + if (!av_strcasecmp(key, "WWW-Authenticate") || !av_strcasecmp(key, "Proxy-Authenticate")) { const char *p; if (av_stristart(value, "Basic ", &p) && state->auth_type <= HTTP_AUTH_BASIC) { @@ -112,7 +112,7 @@ void ff_http_auth_handle_header(HTTPAuthState *state, const char *key, if (!av_strcasecmp(state->digest_params.stale, "true")) state->stale = 1; } - } else if (!strcmp(key, "Authentication-Info")) { + } else if (!av_strcasecmp(key, "Authentication-Info")) { ff_parse_key_value(value, (ff_parse_key_val_cb) handle_digest_update, state); }
Hi! Attached patch fixes ticket #5786. Please comment, Carl Eugen From 3b9380e0a4e715dcbc3ff508235ccad14a01ad37 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Sat, 27 Aug 2016 17:27:48 +0200 Subject: [PATCH] lavf/httpauth: Do case-insensitive http header checks. Fixes ticket #5786. --- libavformat/httpauth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)