From patchwork Wed Aug 31 08:52:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 348 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.134 with SMTP id o128csp267159vsd; Wed, 31 Aug 2016 01:53:12 -0700 (PDT) X-Received: by 10.28.214.130 with SMTP id n124mr8228533wmg.37.1472633591627; Wed, 31 Aug 2016 01:53:11 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y64si3130041wmy.46.2016.08.31.01.53.10; Wed, 31 Aug 2016 01:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48B46689D7A; Wed, 31 Aug 2016 11:53:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 84C31689CAD for ; Wed, 31 Aug 2016 11:52:54 +0300 (EEST) Received: from mfilter20-d.gandi.net (mfilter20-d.gandi.net [217.70.178.148]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 7EE80A80E9 for ; Wed, 31 Aug 2016 10:53:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter20-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter20-d.gandi.net (mfilter20-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id i-saMrpdsKyj for ; Wed, 31 Aug 2016 10:52:59 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E7F80A8112 for ; Wed, 31 Aug 2016 10:52:58 +0200 (CEST) Date: Wed, 31 Aug 2016 10:52:55 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20160831085255.GS4692@nb4> References: <20160831060531.50128-1-rodger.combs@gmail.com> MIME-Version: 1.0 In-Reply-To: <20160831060531.50128-1-rodger.combs@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: improve tag-skipping checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Aug 31, 2016 at 01:05:31AM -0500, Rodger Combs wrote: > - Add "duration" to list of skipped attributes (we handle that elsewhere) > - Move the list to its own function and make its use consistent These 2 should be in separate patches code moving and code changes are more readable when in seperate diffs Also this changes a fate test checksum: Test matroska-remux failed. Look at tests/data/fate/matroska-remux.err for details. make: *** [fate-matroska-remux] Error 1 [...] --- - 2016-08-31 10:28:19.016237007 +0200 +++ tests/data/fate/matroska-remux 2016-08-31 10:28:19.007989456 +0200 @@ -1 +1 @@ -5ebcfaa8e3d534f8a800a58fd2b0aca6 +f08b20b90f158a4de5a02a52c25596b9