| Message ID | 20160831144254.4983-2-timo@rothenpieler.org |
|---|---|
| State | Accepted |
| Headers | show |
2016-08-31 16:42 GMT+02:00 Timo Rothenpieler <timo@rothenpieler.org>: > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index e30ddd2..f2c8492 100755 > --- a/configure > +++ b/configure > @@ -5388,7 +5388,8 @@ decklink_indev_extralibs="$decklink_indev_extralibs $ldl" > frei0r_filter_extralibs='$ldl' > frei0r_src_filter_extralibs='$ldl' > ladspa_filter_extralibs='$ldl' > -nvenc_encoder_extralibs='$ldl' > +h264_nvenc_encoder_extralibs='$ldl' > +hevc_nvenc_encoder_extralibs='$ldl' LGTM. Carl Eugen
On 8/31/2016 11:42 AM, Timo Rothenpieler wrote: > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index e30ddd2..f2c8492 100755 > --- a/configure > +++ b/configure > @@ -5388,7 +5388,8 @@ decklink_indev_extralibs="$decklink_indev_extralibs $ldl" > frei0r_filter_extralibs='$ldl' > frei0r_src_filter_extralibs='$ldl' > ladspa_filter_extralibs='$ldl' > -nvenc_encoder_extralibs='$ldl' > +h264_nvenc_encoder_extralibs='$ldl' > +hevc_nvenc_encoder_extralibs='$ldl' nvenc_extralibs='$ldl' Is simpler and should cover every nvenc encoder, i think.
On Wed, Aug 31, 2016 at 04:42:54PM +0200, Timo Rothenpieler wrote: > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index e30ddd2..f2c8492 100755 > --- a/configure > +++ b/configure > @@ -5388,7 +5388,8 @@ decklink_indev_extralibs="$decklink_indev_extralibs $ldl" > frei0r_filter_extralibs='$ldl' > frei0r_src_filter_extralibs='$ldl' > ladspa_filter_extralibs='$ldl' > -nvenc_encoder_extralibs='$ldl' > +h264_nvenc_encoder_extralibs='$ldl' > +hevc_nvenc_encoder_extralibs='$ldl' > coreimage_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL" > coreimagesrc_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL" not sure why and possibly not an issue in this patch but this patch causes ldl to end up twice in *.pc Libs:
Am 31.08.2016 um 21:26 schrieb Michael Niedermayer: > On Wed, Aug 31, 2016 at 04:42:54PM +0200, Timo Rothenpieler wrote: >> --- >> configure | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index e30ddd2..f2c8492 100755 >> --- a/configure >> +++ b/configure >> @@ -5388,7 +5388,8 @@ decklink_indev_extralibs="$decklink_indev_extralibs $ldl" >> frei0r_filter_extralibs='$ldl' >> frei0r_src_filter_extralibs='$ldl' >> ladspa_filter_extralibs='$ldl' >> -nvenc_encoder_extralibs='$ldl' >> +h264_nvenc_encoder_extralibs='$ldl' >> +hevc_nvenc_encoder_extralibs='$ldl' >> coreimage_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL" >> coreimagesrc_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL" > > not sure why and possibly not an issue in this patch but > this patch causes ldl to end up twice in > *.pc Libs: > I locally replaced it with just nvenc_extralibs, so that shouldn't be an issue anymore.
diff --git a/configure b/configure index e30ddd2..f2c8492 100755 --- a/configure +++ b/configure @@ -5388,7 +5388,8 @@ decklink_indev_extralibs="$decklink_indev_extralibs $ldl" frei0r_filter_extralibs='$ldl' frei0r_src_filter_extralibs='$ldl' ladspa_filter_extralibs='$ldl' -nvenc_encoder_extralibs='$ldl' +h264_nvenc_encoder_extralibs='$ldl' +hevc_nvenc_encoder_extralibs='$ldl' coreimage_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL" coreimagesrc_filter_extralibs="-framework QuartzCore -framework AppKit -framework OpenGL"