From patchwork Sun Sep 4 19:15:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 418 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.134 with SMTP id o128csp2410251vsd; Sun, 4 Sep 2016 12:15:59 -0700 (PDT) X-Received: by 10.28.199.65 with SMTP id x62mr1789283wmf.106.1473016559382; Sun, 04 Sep 2016 12:15:59 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 9si21564622wjq.93.2016.09.04.12.15.57; Sun, 04 Sep 2016 12:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17371689E3A; Sun, 4 Sep 2016 22:15:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe02-2.mx.upcmail.net (vie01a-dmta-pe02-2.mx.upcmail.net [62.179.121.158]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E9ECB689D17 for ; Sun, 4 Sep 2016 22:15:40 +0300 (EEST) Received: from [172.31.216.44] (helo=vie01a-pemc-psmtp-pe02) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1bgctQ-0005UQ-Uj for ffmpeg-devel@ffmpeg.org; Sun, 04 Sep 2016 21:15:48 +0200 Received: from [192.168.1.3] ([80.110.104.164]) by vie01a-pemc-psmtp-pe02 with SMTP @ mailcloud.upcmail.net id fXFn1t00f3YpwW801XFobv; Sun, 04 Sep 2016 21:15:48 +0200 X-SourceIP: 80.110.104.164 From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Date: Sun, 4 Sep 2016 21:15:47 +0200 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <201609042115.47744.cehoyos@ag.or.at> Subject: [FFmpeg-devel] [PATCH]lavc/avpacket: Fix undefined behaviour, do not pass null pointer to memcpy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes ticket #5128. Please comment, Carl Eugen From a3dcd65c313e6b456fcb05915508d8d583c1840e Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 4 Sep 2016 21:11:02 +0200 Subject: [PATCH] lavc/avpacket: Fix undefined behaviour, do not pass a null pointer to memcpy(). Fixes ticket #5128. --- libavcodec/avpacket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 92186892..fa2844d 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -581,7 +581,8 @@ int av_packet_ref(AVPacket *dst, const AVPacket *src) ret = packet_alloc(&dst->buf, src->size); if (ret < 0) goto fail; - memcpy(dst->buf->data, src->data, src->size); + if (src->size) + memcpy(dst->buf->data, src->data, src->size); dst->data = dst->buf->data; } else {