From patchwork Wed Sep 7 02:39:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Gregan X-Patchwork-Id: 459 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.134 with SMTP id o128csp86523vsd; Tue, 6 Sep 2016 19:40:06 -0700 (PDT) X-Received: by 10.194.90.174 with SMTP id bx14mr29508933wjb.41.1473216006343; Tue, 06 Sep 2016 19:40:06 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id e10si22598394wju.122.2016.09.06.19.40.05; Tue, 06 Sep 2016 19:40:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@flim.org; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC9CD68A067; Wed, 7 Sep 2016 05:39:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from flim.org (flim.org [65.99.223.158]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6376268A05E for ; Wed, 7 Sep 2016 05:39:47 +0300 (EEST) Received: from localhost (unknown [121.98.49.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by flim.org (Postfix) with ESMTPSA id 05E2C1415C for ; Wed, 7 Sep 2016 02:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flim.org; s=default; t=1473215995; bh=/v1IZpr+BCcWG12TlkI76F98FjRM/+59nMe+tphYYd0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=eWfkTSrur1XhIxqgS+oPj0dtt/wm0d+UwGIg3A16D5zv5wCx2HC2+0iy1Qbg7GK+T sVjNBZf6i2XnLI60GTvAPAtuiVbPfOE6GW4IaE1mmoJZ/izQVUh4zlQZ4gO8cqogYH QlAN7k04Jw27MSw6NX5unXvVlkVAG1PWcHSblqcM= Date: Wed, 7 Sep 2016 14:39:52 +1200 From: Matthew Gregan To: FFmpeg development discussions and patches Message-ID: <20160907023952.GG29077@brak.lan> Mail-Followup-To: FFmpeg development discussions and patches References: <20160907021023.GA13510@brak.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable stream parsing for VP9. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote: > I think the patch is fine, but I wonder if it should set it to _FULL (the > parser ignores the option, but it is semantically more correct). Good point, thanks for the feedback. Updated (simpler!) patch attached. Cheers, From a9d69f145bb92939c1ffce11a0522dffff76857f Mon Sep 17 00:00:00 2001 From: Matthew Gregan Date: Wed, 7 Sep 2016 13:58:30 +1200 Subject: avformat/mov: Enable stream parsing for VP9. MP4 media containing VP9 using superframes (such as https://github.com/Netflix/vp9-dash/raw/master/DASH-Samples/Fountain_2997_0560kbps_640x480_4x3PAR.ivf_DashUnencrypted.ismv) does not decode correctly with the built-in VP9 decoder because superframes are passed to the decoder whole rather than split into individual frames. Signed-off-by: Matthew Gregan diff --git a/libavformat/mov.c b/libavformat/mov.c index f499906..fa4e016 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2161,6 +2161,7 @@ static int mov_finalize_stsd_codec(MOVContext *c, AVIOContext *pb, case AV_CODEC_ID_EAC3: case AV_CODEC_ID_MPEG1VIDEO: case AV_CODEC_ID_VC1: + case AV_CODEC_ID_VP9: st->need_parsing = AVSTREAM_PARSE_FULL; break; default: -- 2.9.3