From patchwork Thu Sep 8 16:54:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 481 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.134 with SMTP id o128csp932232vsd; Thu, 8 Sep 2016 09:55:10 -0700 (PDT) X-Received: by 10.28.185.202 with SMTP id j193mr1238816wmf.78.1473353710753; Thu, 08 Sep 2016 09:55:10 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n8si6163344wmf.138.2016.09.08.09.55.06; Thu, 08 Sep 2016 09:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FCDF689FAD; Thu, 8 Sep 2016 19:54:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7E3F689F93 for ; Thu, 8 Sep 2016 19:54:48 +0300 (EEST) Received: from mfilter27-d.gandi.net (mfilter27-d.gandi.net [217.70.178.155]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id B6540FB8D1 for ; Thu, 8 Sep 2016 18:54:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter27-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter27-d.gandi.net (mfilter27-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id YGyQOjJf6hTc for ; Thu, 8 Sep 2016 18:54:57 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D6A30FB89F for ; Thu, 8 Sep 2016 18:54:56 +0200 (CEST) Date: Thu, 8 Sep 2016 18:54:43 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20160908165443.GW4692@nb4> References: <578B3FDB.7010407@mail.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] fate/als: add floating point decoding test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Sun, Jul 17, 2016 at 07:25:31PM +0530, Umair Khan wrote: > On Sun, Jul 17, 2016 at 1:50 PM, Thilo Borgmann wrote: > > Hi, > > > >> From e172e333807b4b3b2558a1ffa735ade79a3f3e36 Mon Sep 17 00:00:00 2001 > >> From: Umair Khan > >> Date: Sun, 17 Jul 2016 13:05:49 +0530 > >> Subject: [PATCH 1/1] fate/als: add floating point decoding test > >> > >> Signed-off-by: Umair Khan > >> --- > >> tests/fate/als.mak | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/tests/fate/als.mak b/tests/fate/als.mak > >> index ff2badf..2847a8d 100644 > >> --- a/tests/fate/als.mak > >> +++ b/tests/fate/als.mak > >> @@ -7,5 +7,8 @@ endef > >> > >> $(foreach N,$(ALS_SUITE),$(eval $(call FATE_ALS_SUITE,$(N)))) > >> > >> ++FATE_ALS += fate-mpeg4-als-conformance-07 > > > > Just add "07" to the ALS_SUITE. > > > > You also need to add a new "tests/ref/fate/mpeg4-als-conformance-07" > > file containing the correct CRC for that conformance file. > > > > Please setup a local FATE suite and test your patch before resubmitting. > > Tested. > Updated patch attached. > > -Umair > fate/als.mak | 3 +++ > ref/fate/mpeg4-als-conformance-07 | 1 + > 2 files changed, 4 insertions(+) > 1a677b6670ab1214c568ea495efd182a285dc6e3 0001-fate-als-add-floating-point-decoding-test.patch > From 4295fc1a5f56d81e9b498bece4aed36197328763 Mon Sep 17 00:00:00 2001 > From: Umair Khan > Date: Sun, 17 Jul 2016 13:05:49 +0530 > Subject: [PATCH 1/1] fate/als: add floating point decoding test > > Signed-off-by: Umair Khan > --- > tests/fate/als.mak | 3 +++ > tests/ref/fate/mpeg4-als-conformance-07 | 1 + > 2 files changed, 4 insertions(+) > create mode 100644 tests/ref/fate/mpeg4-als-conformance-07 > > diff --git a/tests/fate/als.mak b/tests/fate/als.mak > index ff2badf..a67302c 100644 > --- a/tests/fate/als.mak > +++ b/tests/fate/als.mak > @@ -7,5 +7,8 @@ endef > > $(foreach N,$(ALS_SUITE),$(eval $(call FATE_ALS_SUITE,$(N)))) > > +FATE_ALS += fate-mpeg4-als-conformance-07 > +fate-mpeg4-als-conformance-07: CMD = crc -i $(TARGET_SAMPLES)/lossless-audio/als_07_2ch192k32bF.mp4 fails on arm Test mpeg4-als-conformance-07 failed. Look at tests/data/fate/mpeg4-als-conformance-07.err for details. make: *** [fate-mpeg4-als-conformance-07] Error 1 interrestingly it does not fail on mips [...] --- tests/ref/fate/mpeg4-als-conformance-07 2016-09-08 18:36:16.095167935 +0200 +++ tests/data/fate/mpeg4-als-conformance-07 2016-09-08 18:49:32.219184707 +0200 @@ -1 +1 @@ -CRC=0x01503df3 +CRC=0x81b53f05