diff mbox

[FFmpeg-devel] Add CONTRIBUTING.md

Message ID 20160917234252.54404-1-josh@itanimul.li
State Accepted
Headers show

Commit Message

Josh de Kock Sept. 17, 2016, 11:42 p.m. UTC
TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice.

Signed-off-by: Josh de Kock <josh@itanimul.li>
---
 CONTRIBUTING.md | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 CONTRIBUTING.md

Comments

James Almer Sept. 18, 2016, 12:29 a.m. UTC | #1
On 9/17/2016 8:42 PM, Josh de Kock wrote:
> TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice.
> 
> Signed-off-by: Josh de Kock <josh@itanimul.li>
> ---
>  CONTRIBUTING.md | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 CONTRIBUTING.md
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> new file mode 100644
> index 0000000..c2b79e4
> --- /dev/null
> +++ b/CONTRIBUTING.md
> @@ -0,0 +1,4 @@
> +# Note to Github users
> +Patches should be submitted to the [ffmpeg-devel mailing list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git format-patch` or `git send-email`. Github pull requests should be avoided because they are not part of our review process and **will be ignored**.

The wording here is different to the notice in README.md, so
make it either "will be ignored" or "will likely be ignored"
in both.

This patch should be ok in any case.

> +
> +See [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) for more information.
>
Thilo Borgmann Sept. 18, 2016, 12:34 a.m. UTC | #2
> Am 18.09.2016 um 01:42 schrieb Josh de Kock <josh@itanimul.li>:
> 
> TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice.
> 
> Signed-off-by: Josh de Kock <josh@itanimul.li>
> ---
> CONTRIBUTING.md | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 CONTRIBUTING.md
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> new file mode 100644
> index 0000000..c2b79e4
> --- /dev/null
> +++ b/CONTRIBUTING.md
> @@ -0,0 +1,4 @@
> +# Note to Github users
> +Patches should be submitted to the [ffmpeg-devel mailing list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git format-patch` or `git send-email`. Github pull requests should be avoided because they are not part of our review process and **will be ignored**.
> +
> +See [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) for more information.
> -- 

LGTM

-Thilo
Josh de Kock Sept. 18, 2016, 9:04 a.m. UTC | #3
On 18/09/2016 01:29, James Almer wrote:
> On 9/17/2016 8:42 PM, Josh de Kock wrote:
>> TimothyGu (https://github.com/FFmpeg/FFmpeg/pull/153#issuecomment-143274708) suggested doing this a while ago, but it was never done. As pull requests seem to be still coming through, I thought I'd send a patch to add the notice.
>>
>> Signed-off-by: Josh de Kock <josh@itanimul.li>
>> ---
>>  CONTRIBUTING.md | 4 ++++
>>  1 file changed, 4 insertions(+)
>>  create mode 100644 CONTRIBUTING.md
>>
>> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
>> new file mode 100644
>> index 0000000..c2b79e4
>> --- /dev/null
>> +++ b/CONTRIBUTING.md
>> @@ -0,0 +1,4 @@
>> +# Note to Github users
>> +Patches should be submitted to the [ffmpeg-devel mailing list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git format-patch` or `git send-email`. Github pull requests should be avoided because they are not part of our review process and **will be ignored**.
>
> The wording here is different to the notice in README.md, so
> make it either "will be ignored" or "will likely be ignored"
> in both.
>
> This patch should be ok in any case.
>
>> +
>> +See [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) for more information.
>>

Thanks, applied with updated wording to README.md.

--
Josh
diff mbox

Patch

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..c2b79e4
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,4 @@ 
+# Note to Github users
+Patches should be submitted to the [ffmpeg-devel mailing list](https://ffmpeg.org/mailman/listinfo/ffmpeg-devel) using `git format-patch` or `git send-email`. Github pull requests should be avoided because they are not part of our review process and **will be ignored**.
+
+See [https://ffmpeg.org/developer.html#Contributing](https://ffmpeg.org/developer.html#Contributing) for more information.