From patchwork Tue Sep 20 11:53:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 657 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp362032vsd; Tue, 20 Sep 2016 04:53:32 -0700 (PDT) X-Received: by 10.194.9.36 with SMTP id w4mr28873742wja.133.1474372412614; Tue, 20 Sep 2016 04:53:32 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d77si27594603wmi.13.2016.09.20.04.53.29; Tue, 20 Sep 2016 04:53:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B3A9B689909; Tue, 20 Sep 2016 14:53:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F3CA6897E2 for ; Tue, 20 Sep 2016 14:53:06 +0300 (EEST) Received: from mfilter43-d.gandi.net (mfilter43-d.gandi.net [217.70.178.174]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id A11FAFB8D2 for ; Tue, 20 Sep 2016 13:53:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter43-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter43-d.gandi.net (mfilter43-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id U9S8KC-FZlwk for ; Tue, 20 Sep 2016 13:53:19 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2774FFB8C4 for ; Tue, 20 Sep 2016 13:53:18 +0200 (CEST) Date: Tue, 20 Sep 2016 13:53:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20160920115305.GX4975@nb4> References: <20160920102841.19193-1-u@pkh.me> MIME-Version: 1.0 In-Reply-To: <20160920102841.19193-1-u@pkh.me> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: switch to codecpar X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Sep 20, 2016 at 12:28:41PM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > This commit is largely based on commit 15e84ed3 from Anton Khirnov > which was previously skipped in bbf5ef9d. > > There are still a bunch of things raising codecpar related warnings that > need fixing, such as: > - the use of codec->debug in the interactive debug mode > - read_ffserver_streams(): it's probably broken now but there is no test > - lowres stuff > - codec copy apparently required by bitstream filters > > The matroska references are updated because they now properly forward > the field_order (previously unknown, now progressive). > > Thanks to James Almer for fixing a bunch of FATE issues in this commit. > > Signed-off-by: Clément Bœsch > Signed-off-by: James Almer > --- > cmdutils.c | 4 +- > ffmpeg.c | 246 +++++++++++++++++++++++++++++----------------------- > ffmpeg.h | 1 + > ffmpeg_filter.c | 24 ++--- > ffmpeg_opt.c | 140 +++++++++++++++++------------- > libavformat/utils.c | 2 +- > tests/ref/lavf/mkv | 4 +- > 7 files changed, 237 insertions(+), 184 deletions(-) breaks fate-rgb24-mkv IIRC i saw some difference with mkvinfo yesterdady related to interlacing Test rgb24-mkv failed. Look at tests/data/fate/rgb24-mkv.err for details. make: *** [fate-rgb24-mkv] Error 1 make: *** Waiting for unfinished jobs.... [...] --- ./tests/ref/fate/rgb24-mkv 2016-09-20 13:44:14.413175330 +0200 +++ tests/data/fate/rgb24-mkv 2016-09-20 13:48:58.381181313 +0200 @@ -1,4 +1,4 @@ -4765774ab65412c9b7565b1b4da82998 *tests/data/fate/rgb24-mkv.matroska +0d081c8e151a922435830f95000d3c71 *tests/data/fate/rgb24-mkv.matroska 58321 tests/data/fate/rgb24-mkv.matroska #tb 0: 1/10 #media_type 0: video