From patchwork Sun Sep 25 13:43:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timo Rothenpieler X-Patchwork-Id: 717 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp1463601vsd; Sun, 25 Sep 2016 06:43:24 -0700 (PDT) X-Received: by 10.194.54.138 with SMTP id j10mr3529043wjp.198.1474811004404; Sun, 25 Sep 2016 06:43:24 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y64si4529064wmy.70.2016.09.25.06.43.23; Sun, 25 Sep 2016 06:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@rothenpieler.org; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94C5A68978C; Sun, 25 Sep 2016 16:43:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from btbn.de (btbn.de [5.9.118.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5825680C89 for ; Sun, 25 Sep 2016 16:42:57 +0300 (EEST) Received: from localhost.localdomain (ip4d16c997.dynamic.kabel-deutschland.de [77.22.201.151]) by btbn.de (Postfix) with ESMTPSA id 7EC6C6B32; Sun, 25 Sep 2016 15:43:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rothenpieler.org; s=mail; t=1474810994; bh=pspwadg+bPrqFguz93Spe9/rajEup6lZBkHvskj/YtY=; h=From:To:Cc:Subject:Date; b=GREk4OLoEUmGhbmzZgD7hlbVDtxeksK8I0PkaC8YIWiz0+xce8hTYm1FHB3REgXXw QMtCJ2IJ74QdQ4AOTpBeaOvJcnMRxcBd+DpO/3Y0lUaVeAARH+Tq4zVqQ7gm1mQYQr ace1ilJfRYmwRHfyIvdZCy6842bOZzcn8TsycjsY= From: Timo Rothenpieler To: ffmpeg-devel@ffmpeg.org Date: Sun, 25 Sep 2016 15:43:06 +0200 Message-Id: <20160925134306.1690-1-timo@rothenpieler.org> X-Mailer: git-send-email 2.10.0 Subject: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timo Rothenpieler MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" When the input frames contain side data, it will accumulate endlessly in the coded frame, as av_frame_copy_props will append any new side data. --- libavcodec/mpegvideo_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 87d7954..5cd654f 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -1735,6 +1735,7 @@ static void frame_end(MpegEncContext *s) #if FF_API_CODED_FRAME FF_DISABLE_DEPRECATION_WARNINGS + av_frame_unref(s->avctx->coded_frame); av_frame_copy_props(s->avctx->coded_frame, s->current_picture.f); FF_ENABLE_DEPRECATION_WARNINGS #endif