From patchwork Tue Oct 4 20:58:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 876 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp2366484vsd; Tue, 4 Oct 2016 13:59:00 -0700 (PDT) X-Received: by 10.194.102.67 with SMTP id fm3mr4414482wjb.80.1475614740065; Tue, 04 Oct 2016 13:59:00 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b143si7550948wma.45.2016.10.04.13.58.59; Tue, 04 Oct 2016 13:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 214BF689DD8; Tue, 4 Oct 2016 23:58:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 43B43689A99 for ; Tue, 4 Oct 2016 23:58:35 +0300 (EEST) Received: from mfilter32-d.gandi.net (mfilter32-d.gandi.net [217.70.178.163]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id A3019C5A4E; Tue, 4 Oct 2016 22:58:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter32-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter32-d.gandi.net (mfilter32-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id KzlYmVvmQYKt; Tue, 4 Oct 2016 22:58:48 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0373DC5A46; Tue, 4 Oct 2016 22:58:47 +0200 (CEST) Date: Tue, 4 Oct 2016 22:58:45 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches , Derek Buitenhuis Message-ID: <20161004205845.GJ5270@nb4> References: <1475612489-35802-1-git-send-email-derek.buitenhuis@gmail.com> MIME-Version: 1.0 In-Reply-To: <1475612489-35802-1-git-send-email-derek.buitenhuis@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] vf_fps: Don't flush a cached frame if it should have been dropped X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Oct 04, 2016 at 04:21:29PM -0400, Derek Buitenhuis wrote: > This fixes downconverting framerates to multiples. > > For example, prior to this patch, converting 900 frames at 60 fps > to 30 fps would output 451 frames instead of the correct 450. > > Signed-off-by: Derek Buitenhuis > --- > DISCLAIMER: I don't know libavfilter very well, and I am not > sure this is the correct fix to the problem. Comments definitely > welcome. > > Also, I would be happy if any replies could be CC'd to me. breaks fate and the change to fate looks wrong, the last frame is lost make fate-filter-fps TEST filter-fps Test filter-fps failed. Look at tests/data/fate/filter-fps.err for details. [...] --- ./tests/ref/fate/filter-fps 2016-10-04 14:46:19.642736770 +0200 +++ tests/data/fate/filter-fps 2016-10-04 22:54:01.859353244 +0200 @@ -84,4 +84,3 @@ 0, 78, 78, 1, 30576, 0xa2fcd06f 0, 79, 79, 1, 30576, 0xa2fcd06f 0, 80, 80, 1, 30576, 0xa2fcd06f -0, 81, 81, 1, 30576, 0xd4150aad