diff mbox

[FFmpeg-devel,3/3] avcodec/utils: print Chroma Location string in verbose log level

Message ID 20161015154056.3148-3-jamrial@gmail.com
State Accepted
Commit 4b0f37dadb74f07095c81e7d0f546f6542f40f58
Headers show

Commit Message

James Almer Oct. 15, 2016, 3:40 p.m. UTC
It's container level information on some formats (Matroska, MXF, yuv4mpeg), so
it should be printed at higher log levels than debug.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Oct. 16, 2016, 2:32 p.m. UTC | #1
On Sat, Oct 15, 2016 at 12:40:56PM -0300, James Almer wrote:
> It's container level information on some formats (Matroska, MXF, yuv4mpeg), so
> it should be printed at higher log levels than debug.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
James Almer Oct. 16, 2016, 3:20 p.m. UTC | #2
On 10/16/2016 11:32 AM, Michael Niedermayer wrote:
> On Sat, Oct 15, 2016 at 12:40:56PM -0300, James Almer wrote:
>> It's container level information on some formats (Matroska, MXF, yuv4mpeg), so
>> it should be printed at higher log levels than debug.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavcodec/utils.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> LGTM
> 
> thx

Pushed, thanks.
diff mbox

Patch

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index be1686e..ec67ad5 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -3251,7 +3251,7 @@  void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
                                 av_get_colorspace_name(enc->colorspace));
             }
 
-            if (av_log_get_level() >= AV_LOG_DEBUG &&
+            if (av_log_get_level() >= AV_LOG_VERBOSE &&
                 enc->chroma_sample_location != AVCHROMA_LOC_UNSPECIFIED)
                 av_strlcatf(detail, sizeof(detail), "%s, ",
                             av_chroma_location_name(enc->chroma_sample_location));