From patchwork Mon Oct 17 22:42:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 1042 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.133 with SMTP id o127csp474933vsd; Mon, 17 Oct 2016 15:42:34 -0700 (PDT) X-Received: by 10.194.28.166 with SMTP id c6mr14521978wjh.40.1476744154715; Mon, 17 Oct 2016 15:42:34 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id fp6si44391221wjb.62.2016.10.17.15.42.34; Mon, 17 Oct 2016 15:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B1899689211; Tue, 18 Oct 2016 01:42:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe01-2.mx.upcmail.net (vie01a-dmta-pe01-2.mx.upcmail.net [62.179.121.155]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34402687EB3 for ; Tue, 18 Oct 2016 01:42:22 +0300 (EEST) Received: from [172.31.216.44] (helo=vie01a-pemc-psmtp-pe02) by vie01a-dmta-pe01.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1bwGbv-0002L8-Nn for ffmpeg-devel@ffmpeg.org; Tue, 18 Oct 2016 00:42:23 +0200 Received: from [192.168.1.3] ([80.110.104.209]) by vie01a-pemc-psmtp-pe02 with SMTP @ mailcloud.upcmail.net id wmiK1t00d4X5Bi801miNS0; Tue, 18 Oct 2016 00:42:23 +0200 X-SourceIP: 80.110.104.209 From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Date: Tue, 18 Oct 2016 00:42:18 +0200 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <201610180042.18646.cehoyos@ag.or.at> Subject: [FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch prints the tag and the tag size when ignoring the size. Please comment, Carl Eugen From e99dc274b7b4b4b5ef502ddb0a8245c1f47c2ece Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 18 Oct 2016 00:37:06 +0200 Subject: [PATCH] lavf/avidec: Be more verbose when ignoring very large tag size. --- libavformat/avidec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index b291625..2fcb0ee 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -986,7 +986,10 @@ FF_ENABLE_DEPRECATION_WARNINGS if (size > 1000000) { av_log(s, AV_LOG_ERROR, "Something went wrong during header parsing, " - "I will ignore it and try to continue anyway.\n"); + "tag %c%c%c%c has size %u, " + "I will ignore it and try to continue anyway.\n", + tag & 0xff, tag >> 8 & 0xff, tag >> 16 & 0xff, tag >> 24 & 0xff, + size); if (s->error_recognition & AV_EF_EXPLODE) goto fail; avi->movi_list = avio_tell(pb) - 4;