From patchwork Mon Dec 5 18:34:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Gu X-Patchwork-Id: 1682 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.86 with SMTP id o83csp1774082vsa; Mon, 5 Dec 2016 10:37:01 -0800 (PST) X-Received: by 10.28.9.80 with SMTP id 77mr11299495wmj.68.1480963021339; Mon, 05 Dec 2016 10:37:01 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u198si1140034wmf.106.2016.12.05.10.36.59; Mon, 05 Dec 2016 10:37:01 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 59692689E3A; Mon, 5 Dec 2016 20:36:47 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0655A689D8B for ; Mon, 5 Dec 2016 20:36:40 +0200 (EET) Received: by mail-pg0-f68.google.com with SMTP id p66so17198079pga.2 for ; Mon, 05 Dec 2016 10:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ytIrfzETlbPxrMvNTEERMHng6mGlC1trPGEp+XPDaFw=; b=wpjHfXXgSPLgJ4HyDg6/eggQtKIt8i/h7NNTgHkuJ7liVmuy/+wJcZ3Bp0HAKlqdFb grzsmTJFNTBtDVZljVNpTST90IXAR+KSHYkDNIhljk3xWW74n3WL9cKRW335Uag6XSjP 1u0KkUy4nlIBKttNQU3A2Cn3hsHd9VWPCvs7RBLblK/kXiZzbHqfslL9cHmmNzRAOb+u 55oiV2TLzxwGHNAZwrlAJFM+CnPMB6hoa9E4Mmn1eoAOz3jH3lw6HNcBxm2otlTLBTY8 7fMa6+5t55mHkajwxpcDPveaEdQwM5cHRk2lEBTKq8uGqS5Ko2FB5Q2ld6OMZAYEJBPP vnfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ytIrfzETlbPxrMvNTEERMHng6mGlC1trPGEp+XPDaFw=; b=l6SNqs1Nu0t/azvy+MouWHeOGx3+CoNaUQXrgXith5weIgruu1P0m0SYib6yK228F+ fDZPtyjMlskxQPYxJnIOdbG1n2zXhXCyf3cTgiUwH0JjMkqX2ow0Zah6VX7/5K49Hj2W XnRfenhJ9oM2cNPu0L5w4B97wyUjmypjkcsCDFZJ65GAJOKR7lcrV2xO8L7ZbQwHgb+h HD/MRcvSFr20KWJ5p8pNO4aMgcD991oVe9xnYZn7/1D1KyKqaTzTfd8if2JslVAdFzA3 B/uI/Z4yweEu/KQ7BXorRQhBI3XNppYFHGpim7RANZBTJx/Pmjpfzusd+//ai3oryhLK n5Vw== X-Gm-Message-State: AKaTC02EsuoKG783NwIb5ZWmyTwevtRlgtlM+gQhX9ldESRz+CDfQq4zySszrzBiB9655w== X-Received: by 10.99.107.4 with SMTP id g4mr105807529pgc.108.1480963006088; Mon, 05 Dec 2016 10:36:46 -0800 (PST) Received: from localhost.localdomain (sylly.timothygu.me. [138.68.13.242]) by smtp.gmail.com with ESMTPSA id s8sm29128138pfj.45.2016.12.05.10.36.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 10:36:45 -0800 (PST) From: Timothy Gu To: ffmpeg-devel@ffmpeg.org Date: Mon, 5 Dec 2016 10:34:43 -0800 Message-Id: <20161205183443.10562-1-timothygu99@gmail.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161205182417.10347-1-timothygu99@gmail.com> References: <20161205182417.10347-1-timothygu99@gmail.com> Subject: [FFmpeg-devel] [PATCH] qsvdec: Fix memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timothy Gu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes CID1396851. --- libavcodec/qsvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index ea4abfa..258042d 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -305,8 +305,10 @@ static int qsv_decode(AVCodecContext *avctx, QSVContext *q, do { ret = get_surface(avctx, q, &insurf); - if (ret < 0) + if (ret < 0) { + av_freep(&sync); return ret; + } ret = MFXVideoDECODE_DecodeFrameAsync(q->session, avpkt->size ? &bs : NULL, insurf, &outsurf, sync);