From patchwork Mon Dec 19 22:47:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 1864 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.86 with SMTP id o83csp1385688vsa; Mon, 19 Dec 2016 14:48:22 -0800 (PST) X-Received: by 10.194.142.243 with SMTP id rz19mr15494043wjb.132.1482187702346; Mon, 19 Dec 2016 14:48:22 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id e70si16379902wmc.129.2016.12.19.14.48.21; Mon, 19 Dec 2016 14:48:22 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95D2C68A088; Tue, 20 Dec 2016 00:48:11 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DCAB68A054; Tue, 20 Dec 2016 00:48:00 +0200 (EET) Received: from mfilter9-d.gandi.net (mfilter9-d.gandi.net [217.70.178.138]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id D750B17209D; Mon, 19 Dec 2016 23:48:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter9-d.gandi.net Received: from relay4-d.mail.gandi.net ([IPv6:::ffff:217.70.183.196]) by mfilter9-d.gandi.net (mfilter9-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id kGuWTkmEnBWv; Mon, 19 Dec 2016 23:48:06 +0100 (CET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BB7EB1720B3; Mon, 19 Dec 2016 23:48:05 +0100 (CET) Date: Mon, 19 Dec 2016 23:47:40 +0100 From: Michael Niedermayer To: FFmpeg git commit log and discussion , FFmpeg development discussions and patches Message-ID: <20161219224740.GC27739@nb4> References: <20161218094936.857621719BE@albiero.videolan.org> MIME-Version: 1.0 In-Reply-To: <20161218094936.857621719BE@albiero.videolan.org> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nicolas George Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Sun, Dec 18, 2016 at 10:49:36AM +0100, Nicolas George wrote: > ffmpeg | branch: master | Nicolas George | Sun Jan 3 15:44:42 2016 +0100| [02aa0701ae0dc2def8db640c9e3c06dc1b5de70c] | committer: Nicolas George > > lavfi: make filter_frame non-recursive. > > A lot of changes happen at the same time: > > - Add a framequeue fifo to AVFilterLink. > > - split AVFilterLink.status into status_in and status_out: requires > changes to the few filters and programs that use it directly > (f_interleave, split, filtfmts). > > - Add a field ready to AVFilterContext, marking when the filter is ready > and its activation priority. > > - Add flags to mark blocked links. > > - Change ff_filter_frame() to enqueue the frame. > > - Change all filtering functions to update the ready field and the > blocked flags. > > - Update ff_filter_graph_run_once() to use the ready field. > > - buffersrc: always push the frame immediately. > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=02aa0701ae0dc2def8db640c9e3c06dc1b5de70c > --- i dont know if this is a bug or just somethig that by sheer bad luck becomes vissible after this but ./ffmpeg -i cvid/dday.mov -vframes 30 -vcodec huffyuv -y -acodec pcm_s16le out3b.avi ; md5sum out3b.avi gives different outputs from time to time needs threads on the encoder side, huffyuv, vframes (audio codec irrelevant) difference in output files looks like this: valgrind shows nothing (but difference occurs under valgrind) should be here: http://samples.ffmpeg.org/V-codecs/CVID/grayscale/dday.mov [...] --- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --- A 2016-12-19 23:36:43.297001535 +0100 +++ B 2016-12-19 23:36:47.605001627 +0100 @@ -50,9 +50,7 @@ 0, 16, 16, 1, 54316, 0xdca6a02a 1, 18728, 18728, 1024, 2048, 0xf24df16c 0, 17, 17, 1, 55204, 0xa93a73e6 -1, 19752, 19752, 1024, 2048, 0x27c11d5c 0, 18, 18, 1, 54872, 0x8b01d9b0 -1, 20776, 20776, 1024, 2048, 0x77e00ab9 0, 19, 19, 1, 54544, 0x752b168f 0, 20, 20, 1, 58916, 0x1596d7cf 0, 21, 21, 1, 53868, 0x0f286854