From patchwork Fri Dec 23 20:39:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas George X-Patchwork-Id: 1901 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp35364vsb; Fri, 23 Dec 2016 12:39:48 -0800 (PST) X-Received: by 10.28.26.197 with SMTP id a188mr16401083wma.93.1482525588374; Fri, 23 Dec 2016 12:39:48 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b15si7338885wmf.133.2016.12.23.12.39.47; Fri, 23 Dec 2016 12:39:48 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2814689A67; Fri, 23 Dec 2016 22:39:44 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from nef2.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8F7CB6898CD for ; Fri, 23 Dec 2016 22:39:37 +0200 (EET) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id uBNKdcqK074347 for ; Fri, 23 Dec 2016 21:39:38 +0100 (CET) Received: by phare.normalesup.org (Postfix, from userid 1001) id 267C3E00FB; Fri, 23 Dec 2016 21:39:38 +0100 (CET) From: Nicolas George To: ffmpeg-devel@ffmpeg.org Date: Fri, 23 Dec 2016 21:39:35 +0100 Message-Id: <20161223203935.7970-1-george@nsup.org> X-Mailer: git-send-email 2.11.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef2.ens.fr [129.199.96.32]); Fri, 23 Dec 2016 21:39:38 +0100 (CET) Subject: [FFmpeg-devel] [PATCH] lavf/matroska: comment a missing error check. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Nicolas George --- libavformat/matroskaenc.c | 1 + 1 file changed, 1 insertion(+) I do not have time to fix this, but I got a few segfaults here, so it needs to be fixed. Either push the patch or, better push an actual fix. diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 827d7550c2..8e536f6774 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -351,6 +351,7 @@ static void end_ebml_master_crc32(AVIOContext *pb, AVIOContext **dyn_cp, Matrosk if (pb->seekable) { size = avio_close_dyn_buf(*dyn_cp, &buf); + /* FIXME missing error check */ if (mkv->write_crc && mkv->mode != MODE_WEBM) { skip = 6; /* Skip reserved 6-byte long void element from the dynamic buffer. */ AV_WL32(crc, av_crc(av_crc_get_table(AV_CRC_32_IEEE_LE), UINT32_MAX, buf + skip, size - skip) ^ UINT32_MAX);