From patchwork Wed Dec 28 13:03:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 1962 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp1942153vsb; Wed, 28 Dec 2016 05:04:25 -0800 (PST) X-Received: by 10.28.73.136 with SMTP id w130mr33362453wma.82.1482930265903; Wed, 28 Dec 2016 05:04:25 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x197si21236685wmf.58.2016.12.28.05.04.25; Wed, 28 Dec 2016 05:04:25 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E969D689BE5; Wed, 28 Dec 2016 15:04:19 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E4AB689B30 for ; Wed, 28 Dec 2016 15:04:13 +0200 (EET) Received: from mfilter37-d.gandi.net (mfilter37-d.gandi.net [217.70.178.168]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 03183FB886 for ; Wed, 28 Dec 2016 14:04:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter37-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter37-d.gandi.net (mfilter37-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id FTFs7Oy9_-a4 for ; Wed, 28 Dec 2016 14:04:14 +0100 (CET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 6B104FB883 for ; Wed, 28 Dec 2016 14:04:14 +0100 (CET) Date: Wed, 28 Dec 2016 14:03:38 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20161228130338.GA4749@nb4> References: <20161228054747.40683-1-mjbshaw@gmail.com> <20161228054747.40683-2-mjbshaw@gmail.com> MIME-Version: 1.0 In-Reply-To: <20161228054747.40683-2-mjbshaw@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Accept time base hint X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Dec 27, 2016 at 09:47:47PM -0800, Michael Bradshaw wrote: > From: Michael Bradshaw > > Signed-off-by: Michael Bradshaw > --- > libavformat/matroskaenc.c | 38 +++++++++++++++++++++++++++++++------- > 1 file changed, 31 insertions(+), 7 deletions(-) breaks fate Test rgb24-mkv failed. Look at tests/data/fate/rgb24-mkv.err for details. TEST ffmpeg-bsf-remove-e make: *** [fate-rgb24-mkv] Error 1 [...] --- ./tests/ref/fate/binsub-mksenc 2016-12-25 00:40:20.261173589 +0100 +++ tests/data/fate/binsub-mksenc 2016-12-28 14:01:40.073216831 +0100 @@ -1 +1 @@ -f80f42e646fce972e73aa6d99dcfa470 +6de7786a1c66b7c1be9c9a481ea5651a Test binsub-mksenc failed. Look at tests/data/fate/binsub-mksenc.err for details. make: *** [fate-binsub-mksenc] Error 1 --- ./tests/ref/fate/rgb24-mkv 2016-12-25 00:40:20.301173590 +0100 +++ tests/data/fate/rgb24-mkv 2016-12-28 14:01:41.505216862 +0100 @@ -1,5 +1,5 @@ -94cce0d7d5b14b4c86e74a1ca454c5aa *tests/data/fate/rgb24-mkv.matroska -58361 tests/data/fate/rgb24-mkv.matroska +cfc097705746aa2d8543ba217ef08237 *tests/data/fate/rgb24-mkv.matroska +58362 tests/data/fate/rgb24-mkv.matroska #tb 0: 1/10 #media_type 0: video #codec_id 0: rawvideo