From patchwork Tue Jan 10 19:56:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 2177 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp429898vsb; Tue, 10 Jan 2017 11:57:08 -0800 (PST) X-Received: by 10.28.87.16 with SMTP id l16mr2757514wmb.111.1484078228557; Tue, 10 Jan 2017 11:57:08 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t10si13867714wmb.123.2017.01.10.11.57.07; Tue, 10 Jan 2017 11:57:08 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 296D268A597; Tue, 10 Jan 2017 21:56:57 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4522D68A4DF for ; Tue, 10 Jan 2017 21:56:49 +0200 (EET) X-QQ-mid: bizesmtp7t1484078212ti8wqcilb Received: from localhost (unknown [47.90.47.25]) by esmtp4.qq.com (ESMTP) with id ; Wed, 11 Jan 2017 03:56:51 +0800 (CST) X-QQ-SSF: 01100000008000F0F621B00A0000000 X-QQ-FEAT: q17Yoz/cMVrCSAuyKH3zI+kMEGtGnJ6PE77scLAxQ6v+umLOf1bPN+EP5zI+v FB0eITyoPSiJp3L6e8ycCP6JTY7QHrxa9rO5E3eaUaxcELFCc3QglbaO/BCunJXNdOvY80i CfzM0EUz9/PYIXJ2OVQn0VHjMUCH1rt7KhFWel6j0RxATeHKPAjxDLDgHQ2ChSycFqkX+J+ W7gf+/AcxSiPszsVZndhG3mDT3kt0tjuOTMe4i/54TWTsCN71R4lybLq4altP4kUVR7p5lx 257g== X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 Jan 2017 03:56:46 +0800 Message-Id: <20170110195646.22768-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.10.1.382.ga23ca1b.dirty X-QQ-SENDSIZE: 520 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v2] avcodec/bsf: fix resource leak in av_bsf_list_parse_str X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" cid: 1396268 when av_strdup(str) error, the lst need release Signed-off-by: Steven Liu --- libavcodec/bsf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index ac2024b..c984526 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -514,8 +514,10 @@ int av_bsf_list_parse_str(const char *str, AVBSFContext **bsf_lst) if (!lst) return AVERROR(ENOMEM); - if (!(dup = buf = av_strdup(str))) - return AVERROR(ENOMEM); + if (!(dup = buf = av_strdup(str))) { + ret = AVERROR(ENOMEM); + goto end; + } while (1) { bsf_str = av_strtok(buf, ",", &saveptr);