diff mbox

[FFmpeg-devel] avcodec/alsdec.c: testing MPEG-4 ALS decoder with floating point audio data

Message ID 20170113171847.GM4698@nb4
State Not Applicable
Headers show

Commit Message

Michael Niedermayer Jan. 13, 2017, 5:18 p.m. UTC 
On Fri, Jan 13, 2017 at 03:13:15AM -0800, Thomas Turner wrote:
> If als_07_2ch192k32bF.mp4 isn't already located in fate-suite/lossless-audio/, you can download at:
> 
> http://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/compressedMp4/als_07_2ch192k32bF.mp4
> 
> Signed-off-by: Thomas Turner <thomastdt@googlemail.com>
> ---
>  tests/fate/als.mak                      | 3 +++
>  tests/ref/fate/mpeg4-als-conformance-07 | 1 +
>  2 files changed, 4 insertions(+)
>  create mode 100644 tests/ref/fate/mpeg4-als-conformance-07

This fails on qemu arm

TEST    mpeg4-als-conformance-07
Test mpeg4-als-conformance-07 failed. Look at tests/data/fate/mpeg4-als-conformance-07.err for details.
make: *** [fate-mpeg4-als-conformance-07] Error 1

interrestingly it does pass on qemu-mips

iam cc-ing thilo and umair they might have comments on this

but a test that compares this to a pcm reference instead of using a
checksum might help the result on arm seems very close

stddev:    0.00 PSNR: 94.36 MAXDIFF:    1 bytes: 11501352/ 11501352

changing the decoder so it matches exactly would be interresting too
but that might be much harder than writing a test also thats beyond the
scope of adding selftests ...

[...]
diff mbox

Patch

--- ffmpeg/tests/ref/fate/mpeg4-als-conformance-07     2017-01-13 17:20:29.230418469 +0100
+++ tests/data/fate/mpeg4-als-conformance-07    2017-01-13 18:00:47.098469407 +0100
@@ -1 +1 @@ 
-CRC=0x01503df3
+CRC=0x81b53f05