From patchwork Fri Feb 10 23:25:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 2496 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp740605vsb; Fri, 10 Feb 2017 15:25:54 -0800 (PST) X-Received: by 10.223.138.220 with SMTP id z28mr9732429wrz.26.1486769154086; Fri, 10 Feb 2017 15:25:54 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o15si3996903wrb.191.2017.02.10.15.25.51; Fri, 10 Feb 2017 15:25:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D499C689D83; Sat, 11 Feb 2017 01:25:44 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 422AD689D06 for ; Sat, 11 Feb 2017 01:25:38 +0200 (EET) Received: from mfilter19-d.gandi.net (mfilter19-d.gandi.net [217.70.178.147]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id F1148A80C2; Sat, 11 Feb 2017 00:25:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter19-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter19-d.gandi.net (mfilter19-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id hIJAiZD7rCoW; Sat, 11 Feb 2017 00:25:40 +0100 (CET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 66D02A80BE; Sat, 11 Feb 2017 00:25:39 +0100 (CET) Date: Sat, 11 Feb 2017 00:25:30 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170210232530.GS5776@nb4> References: <20170210211145.54685-1-vittorio.giovara@gmail.com> MIME-Version: 1.0 In-Reply-To: <20170210211145.54685-1-vittorio.giovara@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vittorio Giovara Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > This should help not losing details over muxing and allows > callers to get additional information in a clean manner. > > Please keep me in CC. > Vittorio > > doc/APIchanges | 5 +++++ > ffprobe.c | 11 ++++++++-- > libavformat/dump.c | 10 +++++++++ > libavutil/spherical.h | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ > libavutil/version.h | 2 +- > 5 files changed, 81 insertions(+), 3 deletions(-) breaks fate Test matroska-spherical-mono failed. Look at tests/data/fate/matroska-spherical-mono.err for details. make: *** [fate-matroska-spherical-mono] Error 1 [...] --- ./tests/ref/fate/matroska-spherical-mono 2017-02-10 23:43:51.993432371 +0100 +++ tests/data/fate/matroska-spherical-mono 2017-02-11 00:24:10.297483318 +0100 @@ -7,7 +7,7 @@ [/SIDE_DATA] [SIDE_DATA] side_data_type=Spherical Mapping -side_data_size=16 +side_data_size=56 projection=equirectangular yaw=45 pitch=30