| Message ID | 20170214215424.GP5776@nb4 |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Feb 14, 2017 at 4:54 PM, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Tue, Feb 14, 2017 at 03:52:39PM -0500, Vittorio Giovara wrote: >> On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer >> <michael@niedermayer.cc> wrote: >> > On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: >> >> Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com> >> >> --- >> >> This should help not losing details over muxing and allows >> >> callers to get additional information in a clean manner. >> >> >> >> Please keep me in CC. >> >> Vittorio >> >> >> >> doc/APIchanges | 5 +++++ >> >> ffprobe.c | 11 ++++++++-- >> >> libavformat/dump.c | 10 +++++++++ >> >> libavutil/spherical.h | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> >> libavutil/version.h | 2 +- >> >> 5 files changed, 81 insertions(+), 3 deletions(-) >> > >> > breaks fate >> > >> > --- ./tests/ref/fate/matroska-spherical-mono 2017-02-10 23:43:51.993432371 +0100 >> > +++ tests/data/fate/matroska-spherical-mono 2017-02-11 00:24:10.297483318 +0100 >> > @@ -7,7 +7,7 @@ >> > [/SIDE_DATA] >> > [SIDE_DATA] >> > side_data_type=Spherical Mapping >> > -side_data_size=16 >> > +side_data_size=56 >> > projection=equirectangular >> > yaw=45 >> > pitch=30 >> > Test matroska-spherical-mono failed. Look at tests/data/fate/matroska-spherical-mono.err for details. >> > make: *** [fate-matroska-spherical-mono] Error 1 >> >> Ah I didn't notice, it is fixed in the next commit, but I'll amend this one too. > > maybe iam missing some patch but > it still fails here with all 3 patches of the patchset: ops sorry you're right, i forgot to update the mkv test amended locally
--- ./tests/ref/fate/matroska-spherical-mono 2017-02-14 04:07:51.870553633 +0100 +++ tests/data/fate/matroska-spherical-mono 2017-02-14 22:52:40.901410068 +0100 @@ -7,8 +7,12 @@ [/SIDE_DATA] [SIDE_DATA] side_data_type=Spherical Mapping -side_data_size=16 -projection=equirectangular +side_data_size=56 +projection=tiled equirectangular +left_bound=148 +top_bound=73 +right_bound=147 +bottom_bound=72 yaw=45 pitch=30 roll=15