From patchwork Tue Feb 14 21:54:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 2549 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp1662743vsb; Tue, 14 Feb 2017 13:54:52 -0800 (PST) X-Received: by 10.223.133.131 with SMTP id 3mr27087124wrt.161.1487109292478; Tue, 14 Feb 2017 13:54:52 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w27si2361547wra.157.2017.02.14.13.54.52; Tue, 14 Feb 2017 13:54:52 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DBC97689730; Tue, 14 Feb 2017 23:54:43 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD550680B17 for ; Tue, 14 Feb 2017 23:54:36 +0200 (EET) Received: from mfilter11-d.gandi.net (mfilter11-d.gandi.net [217.70.178.131]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id 8E996C5A5C; Tue, 14 Feb 2017 22:54:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter11-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter11-d.gandi.net (mfilter11-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id TTV8izySbXAr; Tue, 14 Feb 2017 22:54:39 +0100 (CET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2A4BCC5A5F; Tue, 14 Feb 2017 22:54:38 +0100 (CET) Date: Tue, 14 Feb 2017 22:54:24 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170214215424.GP5776@nb4> References: <20170210211145.54685-1-vittorio.giovara@gmail.com> <20170210232530.GS5776@nb4> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vittorio Giovara Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Tue, Feb 14, 2017 at 03:52:39PM -0500, Vittorio Giovara wrote: > On Fri, Feb 10, 2017 at 6:25 PM, Michael Niedermayer > wrote: > > On Fri, Feb 10, 2017 at 04:11:43PM -0500, Vittorio Giovara wrote: > >> Signed-off-by: Vittorio Giovara > >> --- > >> This should help not losing details over muxing and allows > >> callers to get additional information in a clean manner. > >> > >> Please keep me in CC. > >> Vittorio > >> > >> doc/APIchanges | 5 +++++ > >> ffprobe.c | 11 ++++++++-- > >> libavformat/dump.c | 10 +++++++++ > >> libavutil/spherical.h | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ > >> libavutil/version.h | 2 +- > >> 5 files changed, 81 insertions(+), 3 deletions(-) > > > > breaks fate > > > > --- ./tests/ref/fate/matroska-spherical-mono 2017-02-10 23:43:51.993432371 +0100 > > +++ tests/data/fate/matroska-spherical-mono 2017-02-11 00:24:10.297483318 +0100 > > @@ -7,7 +7,7 @@ > > [/SIDE_DATA] > > [SIDE_DATA] > > side_data_type=Spherical Mapping > > -side_data_size=16 > > +side_data_size=56 > > projection=equirectangular > > yaw=45 > > pitch=30 > > Test matroska-spherical-mono failed. Look at tests/data/fate/matroska-spherical-mono.err for details. > > make: *** [fate-matroska-spherical-mono] Error 1 > > Ah I didn't notice, it is fixed in the next commit, but I'll amend this one too. maybe iam missing some patch but it still fails here with all 3 patches of the patchset: Test matroska-spherical-mono failed. Look at tests/data/fate/matroska-spherical-mono.err for details. make: *** [fate-matroska-spherical-mono] Error 1 [...] --- ./tests/ref/fate/matroska-spherical-mono 2017-02-14 04:07:51.870553633 +0100 +++ tests/data/fate/matroska-spherical-mono 2017-02-14 22:52:40.901410068 +0100 @@ -7,8 +7,12 @@ [/SIDE_DATA] [SIDE_DATA] side_data_type=Spherical Mapping -side_data_size=16 -projection=equirectangular +side_data_size=56 +projection=tiled equirectangular +left_bound=148 +top_bound=73 +right_bound=147 +bottom_bound=72 yaw=45 pitch=30 roll=15