From patchwork Thu Feb 16 23:49:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 2586 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp2730219vsb; Thu, 16 Feb 2017 15:49:19 -0800 (PST) X-Received: by 10.223.178.170 with SMTP id g39mr4201897wrd.7.1487288959467; Thu, 16 Feb 2017 15:49:19 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w4si2355806wme.115.2017.02.16.15.49.19; Thu, 16 Feb 2017 15:49:19 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5DE8689AD0; Fri, 17 Feb 2017 01:49:10 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe04-1.mx.upcmail.net (vie01a-dmta-pe04-1.mx.upcmail.net [62.179.121.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E31546891DD for ; Fri, 17 Feb 2017 01:49:04 +0200 (EET) Received: from [172.31.216.44] (helo=vie01a-pemc-psmtp-pe02) by vie01a-dmta-pe04.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1ceVnR-0001e3-Oy for ffmpeg-devel@ffmpeg.org; Fri, 17 Feb 2017 00:49:09 +0100 Received: from [192.168.1.3] ([80.110.111.16]) by vie01a-pemc-psmtp-pe02 with SMTP @ mailcloud.upcmail.net id lbp51u00j0MGZwY01bp60t; Fri, 17 Feb 2017 00:49:06 +0100 X-SourceIP: 80.110.111.16 From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Date: Fri, 17 Feb 2017 00:49:05 +0100 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <201702170049.05480.cehoyos@ag.or.at> Subject: [FFmpeg-devel] [PATCH]lavc/avpacket: Initialize a variable in error path X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch is said to fix undefined behaviour, see ticket #6153, I cannot reproduce. Please comment, Carl Eugen From 8bbd58c465deb28737586c9292d57ab75e3de32c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 17 Feb 2017 00:46:14 +0100 Subject: [PATCH] lavc/avpacket: Initialize a variable in error path. Fixes ticket #6153. --- libavcodec/avpacket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 24b4efb..8e028a2 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -348,6 +348,8 @@ uint8_t *av_packet_get_side_data(AVPacket *pkt, enum AVPacketSideDataType type, return pkt->side_data[i].data; } } + if (size) + *size = 0; return NULL; }