From patchwork Thu Feb 23 14:19:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 2658 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.149 with SMTP id x21csp235243vsf; Thu, 23 Feb 2017 06:20:02 -0800 (PST) X-Received: by 10.223.173.171 with SMTP id w40mr28250996wrc.177.1487859601943; Thu, 23 Feb 2017 06:20:01 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h72si7155620wma.60.2017.02.23.06.20.01; Thu, 23 Feb 2017 06:20:01 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B097B68839E; Thu, 23 Feb 2017 16:19:38 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe01-1.mx.upcmail.net (vie01a-dmta-pe01-1.mx.upcmail.net [62.179.121.154]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 70BAA688399 for ; Thu, 23 Feb 2017 16:19:32 +0200 (EET) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe01.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1cguFA-0007L5-Hy for ffmpeg-devel@ffmpeg.org; Thu, 23 Feb 2017 15:19:40 +0100 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id oEKc1u01U0S5wYM01EKdMk; Thu, 23 Feb 2017 15:19:37 +0100 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 Feb 2017 15:19:32 +0100 Message-Id: <20170223141932.31110-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170223141932.31110-1-michael@niedermayer.cc> References: <20170223141932.31110-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 4/4] avutil/frame: Disallow zero sized frame side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" There should be no case that needs this and its a potential for creating corner cases Signed-off-by: Michael Niedermayer --- libavutil/frame.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 8811dcdcfe..69ee240758 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -668,6 +668,8 @@ AVFrameSideData *av_frame_new_side_data(AVFrame *frame, enum AVFrameSideDataType type, int size) { + if (size <= 0) + return NULL; return frame_new_side_data(frame, type, av_buffer_alloc(size)); }