From patchwork Sat Feb 25 20:07:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 2677 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.149 with SMTP id x21csp387109vsf; Sat, 25 Feb 2017 12:07:52 -0800 (PST) X-Received: by 10.223.129.74 with SMTP id 68mr7446254wrm.183.1488053272470; Sat, 25 Feb 2017 12:07:52 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h26si11545984wrb.196.2017.02.25.12.07.51; Sat, 25 Feb 2017 12:07:52 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 555AB6883D7; Sat, 25 Feb 2017 22:07:33 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-qmta-pe01-2.mx.upcmail.net (vie01a-qmta-pe01-2.mx.upcmail.net [62.179.121.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6FA56883BF for ; Sat, 25 Feb 2017 22:07:31 +0200 (EET) Received: from [172.31.218.42] (helo=vie01a-dmta-pe04-3.mx.upcmail.net) by vie01a-pqmta-pe01.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1chid3-0007s4-3m for ffmpeg-devel@ffmpeg.org; Sat, 25 Feb 2017 21:07:41 +0100 Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe04.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1chicx-0002xj-Rc for ffmpeg-devel@ffmpeg.org; Sat, 25 Feb 2017 21:07:35 +0100 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id p87X1u00z0S5wYM0187YGX; Sat, 25 Feb 2017 21:07:32 +0100 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 25 Feb 2017 21:07:26 +0100 Message-Id: <20170225200726.7928-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170225200726.7928-1-michael@niedermayer.cc> References: <20170225200726.7928-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 5/5] avcodec/flacdsp: Fix: runtime error: signed integer overflow: -1027555328 + -1226681270 cannot be represented in type 'int' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: 673/clusterfuzz-testcase-5948736536576000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flacdsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flacdsp.c b/libavcodec/flacdsp.c index 560091f73a..bc9a5dbed9 100644 --- a/libavcodec/flacdsp.c +++ b/libavcodec/flacdsp.c @@ -67,7 +67,7 @@ static void flac_lpc_16_c(int32_t *decoded, const int coeffs[32], int sum = 0; for (j = 0; j < pred_order; j++) sum += coeffs[j] * (SUINT)decoded[j]; - decoded[j] += sum >> qlevel; + decoded[j] = decoded[j] + (unsigned)(sum >> qlevel); } }