From patchwork Tue Mar 28 21:57:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 3154 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.44.195 with SMTP id s186csp823292vss; Tue, 28 Mar 2017 14:58:04 -0700 (PDT) X-Received: by 10.28.215.74 with SMTP id o71mr15866139wmg.23.1490738284430; Tue, 28 Mar 2017 14:58:04 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l137si4742615wmg.134.2017.03.28.14.58.04; Tue, 28 Mar 2017 14:58:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 73632689937; Wed, 29 Mar 2017 00:57:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-qmta-pe02-2.mx.upcmail.net (vie01a-qmta-pe02-2.mx.upcmail.net [62.179.121.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F46368839D for ; Wed, 29 Mar 2017 00:57:33 +0300 (EEST) Received: from [172.31.218.34] (helo=vie01a-dmta-pe02-1.mx.upcmail.net) by vie01a-pqmta-pe02.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1csz7j-0007ta-1O for ffmpeg-devel@ffmpeg.org; Tue, 28 Mar 2017 23:57:55 +0200 Received: from [172.31.216.44] (helo=vie01a-pemc-psmtp-pe02) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1csz7d-0003ir-2E for ffmpeg-devel@ffmpeg.org; Tue, 28 Mar 2017 23:57:49 +0200 Received: from [192.168.1.3] ([80.110.118.35]) by vie01a-pemc-psmtp-pe02 with SMTP @ mailcloud.upcmail.net id 1Zxi1v00f0luTnU01ZxjwD; Tue, 28 Mar 2017 23:57:43 +0200 X-SourceIP: 80.110.118.35 From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Date: Tue, 28 Mar 2017 23:57:42 +0200 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <201703282357.42561.cehoyos@ag.or.at> Subject: [FFmpeg-devel] [PATCH]lavf/isom: Remove an incorrect codec point for WMAv2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! libavformat contains a codec point for WMAv2 for many years, it allows to write undecodable files but does not allow to decode existing (flip4mac) files. I believe the flip4mac files should be read differently, without using the code point. Please comment, Carl Eugen From 05f8ac8e0d583eeb20a273abeadfc5780a54cbab Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 28 Mar 2017 23:55:01 +0200 Subject: [PATCH] lavf/isom: Remove codec point for WMAv2 that has never worked. --- libavformat/isom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/isom.c b/libavformat/isom.c index 7da2700..470bb34 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -353,7 +353,6 @@ const AVCodecTag ff_codec_movaudio_tags[] = { { AV_CODEC_ID_QDMC, MKTAG('Q', 'D', 'M', 'C') }, { AV_CODEC_ID_SPEEX, MKTAG('s', 'p', 'e', 'x') }, /* Flash Media Server */ { AV_CODEC_ID_SPEEX, MKTAG('S', 'P', 'X', 'N') }, /* ZygoAudio (quality 10 mode) */ - { AV_CODEC_ID_WMAV2, MKTAG('W', 'M', 'A', '2') }, { AV_CODEC_ID_EVRC, MKTAG('s', 'e', 'v', 'c') }, /* 3GPP2 */ { AV_CODEC_ID_SMV, MKTAG('s', 's', 'm', 'v') }, /* 3GPP2 */ { AV_CODEC_ID_FLAC, MKTAG('f', 'L', 'a', 'C') }, /* nonstandard */ -- 1.7.10.4