From patchwork Sun Apr 9 16:46:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgQsWTc2No?= X-Patchwork-Id: 3349 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.44.195 with SMTP id s186csp1044674vss; Sun, 9 Apr 2017 09:47:06 -0700 (PDT) X-Received: by 10.28.101.68 with SMTP id z65mr6490056wmb.102.1491756426420; Sun, 09 Apr 2017 09:47:06 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c185si8531024wmf.168.2017.04.09.09.47.05; Sun, 09 Apr 2017 09:47:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D8C96891DD; Sun, 9 Apr 2017 19:46:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from golem.pkh.me (LStLambert-657-1-117-164.w92-154.abo.wanadoo.fr [92.154.28.164]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7E846883A2 for ; Sun, 9 Apr 2017 19:46:52 +0300 (EEST) Received: from localhost (golem.pkh.me [local]) by golem.pkh.me (OpenSMTPD) with ESMTPA id 43b66d31; Sun, 9 Apr 2017 16:46:56 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Apr 2017 18:46:50 +0200 Message-Id: <20170409164651.31151-1-u@pkh.me> X-Mailer: git-send-email 2.12.1 Subject: [FFmpeg-devel] [PATCH 1/2] configure: properly honor --valgrind option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Setting --valgrind implies the valgrind-memcheck toolchain. Before this commit, the toolchain handling was overriding the target exec with an arbitrary "valgrind" setting not taking into account the user setting. --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 8ad0bda76c..539a126656 100755 --- a/configure +++ b/configure @@ -3615,6 +3615,7 @@ case "$toolchain" in ;; valgrind-*) target_exec_default="valgrind" + test -n "$valgrind" && target_exec_default="$valgrind" case "$toolchain" in valgrind-massif) target_exec_args="--tool=massif --alloc-fn=av_malloc --alloc-fn=av_mallocz --alloc-fn=av_calloc --alloc-fn=av_fast_padded_malloc --alloc-fn=av_fast_malloc --alloc-fn=av_realloc_f --alloc-fn=av_fast_realloc --alloc-fn=av_realloc"