diff mbox

[FFmpeg-devel] avformat/movenc: auto insert vp9_superframe bsf when needed

Message ID 20170410043341.7376-1-jamrial@gmail.com
State Accepted
Commit d36a3f5a78bb1e15bbaffc7b92dbeb6a50c28ca9
Headers show

Commit Message

James Almer April 10, 2017, 4:33 a.m. UTC 
Experimental VP9 support was added to the muxer recently.
---
 libavformat/movenc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ronald S. Bultje April 10, 2017, 11:17 a.m. UTC | #1 
Hi,

On Mon, Apr 10, 2017 at 12:33 AM, James Almer <jamrial@gmail.com> wrote:

> Experimental VP9 support was added to the muxer recently.
> ---
>  libavformat/movenc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index a54aa879e9..9280dc8d23 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -6352,6 +6352,8 @@ static int mov_check_bitstream(struct
> AVFormatContext *s, const AVPacket *pkt)
>      if (st->codecpar->codec_id == AV_CODEC_ID_AAC) {
>          if (pkt->size > 2 && (AV_RB16(pkt->data) & 0xfff0) == 0xfff0)
>              ret = ff_stream_add_bitstream_filter(st, "aac_adtstoasc",
> NULL);
> +    } else if (st->codecpar->codec_id == AV_CODEC_ID_VP9) {
> +        ret = ff_stream_add_bitstream_filter(st, "vp9_superframe", NULL);
>      }


LGTM.

Ronald
James Almer April 10, 2017, 1:29 p.m. UTC | #2 
On 4/10/2017 8:17 AM, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Apr 10, 2017 at 12:33 AM, James Almer <jamrial@gmail.com> wrote:
> 
>> Experimental VP9 support was added to the muxer recently.
>> ---
>>  libavformat/movenc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index a54aa879e9..9280dc8d23 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -6352,6 +6352,8 @@ static int mov_check_bitstream(struct
>> AVFormatContext *s, const AVPacket *pkt)
>>      if (st->codecpar->codec_id == AV_CODEC_ID_AAC) {
>>          if (pkt->size > 2 && (AV_RB16(pkt->data) & 0xfff0) == 0xfff0)
>>              ret = ff_stream_add_bitstream_filter(st, "aac_adtstoasc",
>> NULL);
>> +    } else if (st->codecpar->codec_id == AV_CODEC_ID_VP9) {
>> +        ret = ff_stream_add_bitstream_filter(st, "vp9_superframe", NULL);
>>      }
> 
> 
> LGTM.
> 
> Ronald

Pushed, thanks.
diff mbox

Patch

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index a54aa879e9..9280dc8d23 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6352,6 +6352,8 @@  static int mov_check_bitstream(struct AVFormatContext *s, const AVPacket *pkt)
     if (st->codecpar->codec_id == AV_CODEC_ID_AAC) {
         if (pkt->size > 2 && (AV_RB16(pkt->data) & 0xfff0) == 0xfff0)
             ret = ff_stream_add_bitstream_filter(st, "aac_adtstoasc", NULL);
+    } else if (st->codecpar->codec_id == AV_CODEC_ID_VP9) {
+        ret = ff_stream_add_bitstream_filter(st, "vp9_superframe", NULL);
     }
 
     return ret;