From patchwork Thu Apr 20 14:47:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 3452 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.3.129 with SMTP id 123csp837810vsd; Thu, 20 Apr 2017 07:48:24 -0700 (PDT) X-Received: by 10.223.134.145 with SMTP id 17mr8739801wrx.130.1492699704378; Thu, 20 Apr 2017 07:48:24 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a31si68880wrc.277.2017.04.20.07.48.22; Thu, 20 Apr 2017 07:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C34D6898B3; Thu, 20 Apr 2017 17:48:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7805A6882FF for ; Thu, 20 Apr 2017 17:48:03 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by relay7-d.mail.gandi.net (Postfix) with ESMTPS id 080E9384D for ; Thu, 20 Apr 2017 16:48:11 +0200 (CEST) Received: from mfilter24-d.gandi.net (mfilter24-d.gandi.net [217.70.178.152]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id D95D8A8139 for ; Thu, 20 Apr 2017 16:48:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter24-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter24-d.gandi.net (mfilter24-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id aUtzptoLbhOm for ; Thu, 20 Apr 2017 16:48:09 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 29BAFA80F0 for ; Thu, 20 Apr 2017 16:48:08 +0200 (CEST) Date: Thu, 20 Apr 2017 16:47:29 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170420144729.GP4714@nb4> References: <1492690483-37511-1-git-send-email-derek.buitenhuis@gmail.com> <1492690483-37511-3-git-send-email-derek.buitenhuis@gmail.com> MIME-Version: 1.0 In-Reply-To: <1492690483-37511-3-git-send-email-derek.buitenhuis@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH 2/2] webmdashenc: Validate the 'streams' adaptation sets parameter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Apr 20, 2017 at 01:14:43PM +0100, Derek Buitenhuis wrote: > It should not be a value larger than the number of streams we have, > or it will cause invalid reads and/or SIGSEGV. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) breaks fate Test webm-dash-manifest-live-bandwidth failed. Look at tests/data/fate/webm-dash-manifest-live-bandwidth.err for details. make: *** [fate-webm-dash-manifest-live-bandwidth] Error 1 [...] --- ./tests/ref/fate/webm-dash-manifest 2017-04-18 01:26:16.687146020 +0200 +++ tests/data/fate/webm-dash-manifest 2017-04-20 16:10:26.923696509 +0200 @@ -1,48 +0,0 @@ - - - - - -dash_video1.webm - - - - - -dash_video2.webm - - - - - - - -dash_audio1.webm - - - - - -dash_audio2.webm - - - - - - - Test webm-dash-manifest failed. Look at tests/data/fate/webm-dash-manifest.err for details. make: *** [fate-webm-dash-manifest] Error 1 TEST webm-dash-manifest-live-bandwidth --- ./tests/ref/fate/webm-dash-manifest-live 2017-04-18 01:26:16.687146020 +0200 +++ tests/data/fate/webm-dash-manifest-live 2017-04-20 16:10:26.939696503 +0200 @@ -1,24 +0,0 @@ - - - - - - - - - - - - - - - Test webm-dash-manifest-live failed. Look at tests/data/fate/webm-dash-manifest-live.err for details. make: *** [fate-webm-dash-manifest-live] Error 1 TEST vp8-test-vector-005 TEST vp8-test-vector-006 TEST vp8-test-vector-007 --- ./tests/ref/fate/webm-dash-manifest-live-bandwidth 2017-04-18 12:31:39.137491812 +0200 +++ tests/data/fate/webm-dash-manifest-live-bandwidth 2017-04-20 16:10:26.975696506 +0200 @@ -1,24 +0,0 @@ - - - - - - - - - - - - - - -