| Message ID | 201705011037.51188.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Commit | f4c133c708747b5c93a15360ac15d93e123326da |
| Headers | show |
On Mon, May 01, 2017 at 10:37:51AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning when compiling for mips, I suspect it also > fixes usage of inline asm. > > Please comment, Carl Eugen > iirfilter_mips.c | 1 + > 1 file changed, 1 insertion(+) > 2c9416e78c7b93db40c774db11b45e14db785eba 0001-lavc-mips-iirfilter_mips-Include-config.h.patch > From bbb8a20926b679d05af3b668a2822e6e1a97efa7 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos <cehoyos@ag.or.at> > Date: Mon, 1 May 2017 10:35:28 +0200 > Subject: [PATCH] lavc/mips/iirfilter_mips: Include config.h. > > Fixes the following warning: > libavcodec/mips/iirfilter_mips.c:57:5: warning: "HAVE_INLINE_ASM" is not defined LGTM thx [...]
2017-05-01 16:41 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>: > On Mon, May 01, 2017 at 10:37:51AM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a warning when compiling for mips, I suspect it also >> fixes usage of inline asm. >> >> Please comment, Carl Eugen > >> iirfilter_mips.c | 1 + >> 1 file changed, 1 insertion(+) >> 2c9416e78c7b93db40c774db11b45e14db785eba 0001-lavc-mips-iirfilter_mips-Include-config.h.patch >> From bbb8a20926b679d05af3b668a2822e6e1a97efa7 Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos <cehoyos@ag.or.at> >> Date: Mon, 1 May 2017 10:35:28 +0200 >> Subject: [PATCH] lavc/mips/iirfilter_mips: Include config.h. >> >> Fixes the following warning: >> libavcodec/mips/iirfilter_mips.c:57:5: warning: "HAVE_INLINE_ASM" is not defined > > LGTM Patch applied. Thank you, Carl Eugen
diff --git a/libavcodec/mips/iirfilter_mips.c b/libavcodec/mips/iirfilter_mips.c index 74f036f..3a1352a 100644 --- a/libavcodec/mips/iirfilter_mips.c +++ b/libavcodec/mips/iirfilter_mips.c @@ -52,6 +52,7 @@ * Reference: libavcodec/iirfilter.c */ +#include "config.h" #include "libavcodec/iirfilter.h" #if HAVE_INLINE_ASM
Hi! Attached patch fixes a warning when compiling for mips, I suspect it also fixes usage of inline asm. Please comment, Carl Eugen From bbb8a20926b679d05af3b668a2822e6e1a97efa7 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Mon, 1 May 2017 10:35:28 +0200 Subject: [PATCH] lavc/mips/iirfilter_mips: Include config.h. Fixes the following warning: libavcodec/mips/iirfilter_mips.c:57:5: warning: "HAVE_INLINE_ASM" is not defined --- libavcodec/mips/iirfilter_mips.c | 1 + 1 file changed, 1 insertion(+)