From patchwork Tue May 9 13:32:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 3630 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.3.129 with SMTP id 123csp1337133vsd; Tue, 9 May 2017 06:32:53 -0700 (PDT) X-Received: by 10.223.171.238 with SMTP id s101mr33726wrc.83.1494336773264; Tue, 09 May 2017 06:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494336773; cv=none; d=google.com; s=arc-20160816; b=wX0CJ8lo3glRLPOWEBDN0IlsQEvkMUMP8BRbET5edMXzAKfgTw4qgQspJKKM+x9deh L82olq4hgdEa+mo+GRKZHCi+OKTWWbSZOYPoVcxK8x1MiPkAPwuBgmpQhg2f5C3caSfi dc9D/2Cu/0aPrplAGLxmdDKp5Bwl63xbSR/yA8ztS9OweVknMSrAgT+Mh6UM9gCF6Iyp 0ienVf0ykZf9NYQDzycn/jm9TexGhnDk+C75bQ0GmgRnBjmVL+aYX1b609aTOLkxZfBC Tny8vyRQj7nzQtz92lWnNKlBnq5DekbofaTf3UyCOUB0X6pD9Nke9jpR2NgD0RfHgCfv HC0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:message-id :mime-version:user-agent:date:to:from:delivered-to :arc-authentication-results; bh=5+UlVjXmIoAJeKMShVYZsW5/aczbvIbkSomwgTBxn3A=; b=QRlot8YF10W9eUgGMHvn+32r+MPB7vy5WMlWbSsc91yZ7PYXlQP5o89RrR4HTgAFJ2 AYu05HDKtcYb/9mZ6/vxwx1outb+mvRPNW8gt1juCcShYOjPlnkRXPzzjx3TObBd8qtT oXlWioa1H7fxugo9Q0V/ATOZ29zK1iGRO8dlQXDaTty9/bQ+2dbTtHcXtbaSHdplymcf dzP16VOytoIX+Izp6SYueum3B5DtshA+crzhKd79o3UM8uj3vW+NQxzQKHN46hEaFSOQ ZGKZTCFgK2Jj3XrxH1A63wATxuL/WbD8JQkDBhAavFZFBWGm5kySIu+dCppIax92tcif lBXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r186si910405wme.22.2017.05.09.06.32.52; Tue, 09 May 2017 06:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 822C6688399; Tue, 9 May 2017 16:32:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe03-3.mx.upcmail.net (vie01a-dmta-pe03-3.mx.upcmail.net [62.179.121.162]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 67DC56804B4 for ; Tue, 9 May 2017 16:32:37 +0300 (EEST) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe03.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1d85Fr-0001DR-8F for ffmpeg-devel@ffmpeg.org; Tue, 09 May 2017 15:32:43 +0200 Received: from [192.168.1.3] ([80.110.84.226]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id JDYd1v00F4szZML01DYeMv; Tue, 09 May 2017 15:32:38 +0200 X-SourceIP: 80.110.84.226 From: Carl Eugen Hoyos To: FFmpeg development discussions and patches Date: Tue, 9 May 2017 15:32:36 +0200 User-Agent: KMail/1.9.10 MIME-Version: 1.0 Message-Id: <201705091532.37005.cehoyos@ag.or.at> Subject: [FFmpeg-devel] [PATCH]lavf/mlv: Fix an snprintf() truncation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes a warning when compiling with gcc 7: libavformat/mlvdec.c: In function ‘read_header’: libavformat/mlvdec.c:353:58: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] snprintf(filename + strlen(filename) - 2, 3, "%02d", i); Please comment, Carl Eugen From f56bf75b2b8b99cbbe99da8d2e33e46bf50be92d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 9 May 2017 15:27:44 +0200 Subject: [PATCH] lavf/mlvdec: Avoid snprintf() output truncation. Fixes a gcc warning: 'snprintf' output may be truncated before the last format character --- libavformat/mlvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 319cd26..372acbe 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -349,7 +349,7 @@ static int read_header(AVFormatContext *avctx) if (!filename) return AVERROR(ENOMEM); - for (i = 0; i < 100; i++) { + for (i = 0; i < 99; i++) { snprintf(filename + strlen(filename) - 2, 3, "%02d", i); if (avctx->io_open(avctx, &mlv->pb[i], filename, AVIO_FLAG_READ, NULL) < 0) break;