diff mbox

[FFmpeg-devel] configure: use -x instead of -wN ..@ to strip assembly files

Message ID 20170516110837.24724-1-atomnuker@gmail.com
State Accepted
Commit 18f09524f72ccc56273859fceb2c7cf1c7b15c78
Headers show

Commit Message

Rostislav Pehlivanov May 16, 2017, 11:08 a.m. UTC
Reduces the amount of debugging information of external asm from
uselessly verbose to informative enough.
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

James Darnley May 16, 2017, 6:50 p.m. UTC | #1
On 2017-05-16 13:08, Rostislav Pehlivanov wrote:
> Reduces the amount of debugging information of external asm from
> uselessly verbose to informative enough.
> ---
>  configure | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index e4862f6a35..df849df14f 100755
> --- a/configure
> +++ b/configure
> @@ -6185,8 +6185,7 @@ enabled rpath && add_ldlibflags -Wl,-rpath,$libdir
>  test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic
>  
>  # add some strip flags
> -# -wN '..@*' is more selective than -x, but not available everywhere.
> -check_stripflags -wN \'..@*\' || check_stripflags -x
> +check_stripflags -x
>  
>  enabled neon_clobber_test &&
>      check_ldflags -Wl,--wrap,avcodec_open2              \
> 

Look good.  I'm in favour of this change.  It does exactly what I was
(partly) advocating for in my email on Friday.
Rostislav Pehlivanov June 16, 2017, 2:26 p.m. UTC | #2
On 16 May 2017 at 19:50, James Darnley <james.darnley@gmail.com> wrote:

> On 2017-05-16 13:08, Rostislav Pehlivanov wrote:
> > Reduces the amount of debugging information of external asm from
> > uselessly verbose to informative enough.
> > ---
> >  configure | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/configure b/configure
> > index e4862f6a35..df849df14f 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6185,8 +6185,7 @@ enabled rpath && add_ldlibflags -Wl,-rpath,$libdir
> >  test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic
> >
> >  # add some strip flags
> > -# -wN '..@*' is more selective than -x, but not available everywhere.
> > -check_stripflags -wN \'..@*\' || check_stripflags -x
> > +check_stripflags -x
> >
> >  enabled neon_clobber_test &&
> >      check_ldflags -Wl,--wrap,avcodec_open2              \
> >
>
> Look good.  I'm in favour of this change.  It does exactly what I was
> (partly) advocating for in my email on Friday.
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Thanks, pushed
diff mbox

Patch

diff --git a/configure b/configure
index e4862f6a35..df849df14f 100755
--- a/configure
+++ b/configure
@@ -6185,8 +6185,7 @@  enabled rpath && add_ldlibflags -Wl,-rpath,$libdir
 test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic
 
 # add some strip flags
-# -wN '..@*' is more selective than -x, but not available everywhere.
-check_stripflags -wN \'..@*\' || check_stripflags -x
+check_stripflags -x
 
 enabled neon_clobber_test &&
     check_ldflags -Wl,--wrap,avcodec_open2              \