From patchwork Sun May 21 00:12:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 3706 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.10.2 with SMTP id 2csp864219vsk; Sat, 20 May 2017 17:12:37 -0700 (PDT) X-Received: by 10.28.145.194 with SMTP id t185mr9705254wmd.128.1495325557414; Sat, 20 May 2017 17:12:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495325557; cv=none; d=google.com; s=arc-20160816; b=pwP4DIf/v0W4yjG7IRdadykUA2F2YHQ2V8tRTLmYKrFRZ57vDQAon9ArUXj9+WHMy+ Bo4SpydmHe1ojc7savelw9+HIBZG9nCAuzqe0uw4yzeK+xvCGg/vrbJjzq/DpGea4YtH fkC8nmaNLqbjuavoK2tmbaz3m+Bgaeh5FcmKEWyyYT8GQDkzns+nyyEz69XvhiXzXpRm wQe2lTnJd0NEeymSF9tzoyl26UNKokbOnjjHZ0p0eHMOyCl4LzP1yJR5yJYO4hovnIqQ bWA3sLrK7/f9SlvOVp3mBTPmM3OreomNv47aq+yNUOcAgSt5l5h0EbC3WhnwLGcnkbM5 elZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=TRlcNFEzY193Zd5bPwFlSpedK9vQy5D5M8ixmcLcbkM=; b=SThUr4hYmwVSoXlYqoS1lFcpZnsTUxG6uNnh2EPcR3gjW0yg79o1liz+BFpohzjNmM nBrzxOfQpkpgLpnmCh/J33m6jGGvs+eeSWtk981QbfvXxbLH/Qw52V0IXuP/LpSpN0dZ 5we+bBohuHIpROuYDHA77P/KXgQJ8fS/DKrmur8liHX/9jV7lBtly4Bci9PIFm63XQAc fpXIfnzewgo3PzFaP02osNrUHmDTdvt42nqZZeR2KKIn+nITAb79jufasNZJgDo3J3/N JLy54t/WrwGSmEdVslNv1Cf1U+ykMDJHh5UAv+eu/we7jsHWXM3Zp+DA9WD1AZPFv/7l EgqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h8si14140998wmf.41.2017.05.20.17.12.36; Sat, 20 May 2017 17:12:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 93B47689A05; Sun, 21 May 2017 03:12:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe05-1.mx.upcmail.net (vie01a-dmta-pe08-1.mx.upcmail.net [84.116.36.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B742680765 for ; Sun, 21 May 2017 03:12:26 +0300 (EEST) Received: from [172.31.216.43] (helo=vie01a-pemc-psmtp-pe01) by vie01a-dmta-pe08.mx.upcmail.net with esmtp (Exim 4.88) (envelope-from ) id 1dCETy-0007tg-Hx for ffmpeg-devel@ffmpeg.org; Sun, 21 May 2017 02:12:26 +0200 Received: from localhost ([213.47.41.20]) by vie01a-pemc-psmtp-pe01 with SMTP @ mailcloud.upcmail.net id NoCN1v00h0S5wYM01oCPp5; Sun, 21 May 2017 02:12:23 +0200 X-SourceIP: 213.47.41.20 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 21 May 2017 02:12:21 +0200 Message-Id: <20170521001221.30906-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.13.0 Subject: [FFmpeg-devel] [PATCH] avcodec/vp9block: fix runtime error: signed integer overflow: 196675 * 20670 cannot be represented in type 'int' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: 1710/clusterfuzz-testcase-minimized-4837032931098624 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp9block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9block.c b/libavcodec/vp9block.c index ae2f0e4c6f..a16ccdccdb 100644 --- a/libavcodec/vp9block.c +++ b/libavcodec/vp9block.c @@ -915,9 +915,9 @@ skip_eob: if (!--band_left) band_left = band_counts[++band]; if (is_tx32x32) - STORE_COEF(coef, rc, ((vp8_rac_get(c) ? -val : val) * qmul[!!i]) / 2); + STORE_COEF(coef, rc, (int)((vp8_rac_get(c) ? -val : val) * (unsigned)qmul[!!i]) / 2); else - STORE_COEF(coef, rc, (vp8_rac_get(c) ? -val : val) * qmul[!!i]); + STORE_COEF(coef, rc, (vp8_rac_get(c) ? -val : val) * (unsigned)qmul[!!i]); nnz = (1 + cache[nb[i][0]] + cache[nb[i][1]]) >> 1; tp = p[band][nnz]; } while (++i < n_coeffs);