From patchwork Mon May 22 10:06:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hendrik Leppkes X-Patchwork-Id: 3712 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.10.2 with SMTP id 2csp1350510vsk; Mon, 22 May 2017 03:12:42 -0700 (PDT) X-Received: by 10.223.145.162 with SMTP id 31mr11847872wri.43.1495447962806; Mon, 22 May 2017 03:12:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495447962; cv=none; d=google.com; s=arc-20160816; b=Ni9r420poCVydTUjtF23o906QTDdBR4esWEfqPhfXE9GzsVe8ijZQt+Cd7aa3RlDmb xbT+gf3x7f3q4cTu9JWxf/1vSKggR+wAVIXrV1/4iKw5gOd2nltvTV/tNyl4BSFfu3r2 P+ap6wnF1JrNIRVBL4a4Q6rMWw1i9VNFeu+4PHk6bMS/KQ8uh86IPaszNOwIWEJD6nx1 s/dz0gEe4bNBl4Jm/R2RogC+ti4axDWFj08JYPf0AuUTmnfFjwUbjjOrEh5KbW+LpfO5 QeIG9MnqJDP2dH/fxzCUy8G42Lx6K5Kys0OFzrWzh1XfDPZAaLxtbR4QQDv57Z8wA9s2 LybA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=46ZyZ3eSOSDbNKtnLsEpxdVxJ9FE1j75wAIyqy5Ig8U=; b=kclTsO8VNdHoJ/YLrajXPMB5nnhTRXGL1nnwgz7D0uR1VfCum8VW1U8E5GKJjAoOdI h8SZbeL3tclnPNSNLHXTOl3YW4dKxdCjvOQ3hJu0totCeeqN7VuwCaCeJbG3DVAh/ZwD kTtYAGwF+YiUmPHmrReMtkNT4O507Pi3NrtPNWDda/3a1eXpNpbT0dI2OqwaKTByWG5b x12f613TNYA0VqMKP4z/9rdp4WUbcXLIM1lXwrDth0qALGiz96UgrP2qncoXKWRX328K ZMckAN+k7EdTQ2HIcnpqsqQrw2gm/NjP06PB4oD5tKPh159tQtii8YR6ZVW3l2dMz0Z2 +Sqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b34si12033421wrb.130.2017.05.22.03.12.42; Mon, 22 May 2017 03:12:42 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5DC66899C9; Mon, 22 May 2017 13:12:37 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1870D6883AE for ; Mon, 22 May 2017 13:12:31 +0300 (EEST) Received: by mail-wm0-f52.google.com with SMTP id e127so32644867wmg.1 for ; Mon, 22 May 2017 03:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=HbGsVtm/+rBPZexbFUrsdjsd/9CMqQlsmztGoQDcVP8=; b=vVoQQ9End4LVH3mtqy6IWlAMTopimwaZ+LW4JuNpRur43sY+Bj6t+FHQ+fxlD6CuV9 x/V0OGVKZf7U83OMYl4B3g4jetrn4IcmMeCuhe1MwGe+GbyiQntOjuEMPUZARcS8QVRD 4rvlwTwe3qrkjadDSyv5acDpplDBenMHh2mIl3OxmRW+oaKgzPOxCaoqQwg7WxCFgrOO rgVIVb7vs5gtaZ/gMJCUHv0FUzhFj+X0M1nyrXj9mxnsSP05GzhXiIbUDMFB0WlvY/c9 VKIVXAjS1Rk9GJaeQelpk2RKlxdqJcmEmnqtQ7eTMob8K6FeNaM8p353NRSOirJtz+M/ kwEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=HbGsVtm/+rBPZexbFUrsdjsd/9CMqQlsmztGoQDcVP8=; b=PX1uylcH5DNr9HXVSR0Sn+EjMXPblXzOlAOyn+gk4GSzhid5CfeDgyc+yn867xZPDj o0fiz2EUbQ1l8OfBqY+U8nUCst2Lbwa/cfMMEAkA2Nwl7fK3l59eefFuGIf0Vw9wwl2V Kd6B+wfzXe/gKXbfiOlB2E8kWuuTQtjMA+n+FlK1WLPVRISA9Hq87LkcnSgHzn6LBqEL MLVEiU0usgNC4WF/RJqY7mLqWFF6vEOJKd+oKdKCl4KOoB//mUVAaWV+zrqC97C0V/GT SDZEZ5IO0HOhGgRBXgROMUNQbzs7rWRKFKbIp7REP/qb6JOsQfW/aHdk9paJm9oFLYam o0/g== X-Gm-Message-State: AODbwcDkOgUrwednbiW1l2OvK5udZ0yLgY+xTiK/TT2gH5e29p5bMEoN MAK65yu0ey1Pn6Qlh/w= X-Received: by 10.28.216.129 with SMTP id p123mr27680000wmg.55.1495447584135; Mon, 22 May 2017 03:06:24 -0700 (PDT) Received: from localhost (p200300CCF3C28400F0AFDEED321C49F7.dip0.t-ipconnect.de. [2003:cc:f3c2:8400:f0af:deed:321c:49f7]) by smtp.gmail.com with ESMTPSA id 137sm18423683wmi.19.2017.05.22.03.06.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 03:06:23 -0700 (PDT) From: Hendrik Leppkes To: ffmpeg-devel@ffmpeg.org Date: Mon, 22 May 2017 12:06:19 +0200 Message-Id: <20170522100619.23600-1-h.leppkes@gmail.com> X-Mailer: git-send-email 2.12.2.windows.2 Subject: [FFmpeg-devel] [PATCH] Use AVOnce as a static variable consistently X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Using AVOnce as a stack variable makes no sense as the state is lost when the function exists. This fixes repeated calls to av(filter/device)_register_all --- libavdevice/alldevices.c | 2 +- libavfilter/allfilters.c | 2 +- libavformat/allformats.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index 280a260bd3..a8ed53ae5d 100644 --- a/libavdevice/alldevices.c +++ b/libavdevice/alldevices.c @@ -73,7 +73,7 @@ static void register_all(void) void avdevice_register_all(void) { - AVOnce control = AV_ONCE_INIT; + static AVOnce control = AV_ONCE_INIT; ff_thread_once(&control, register_all); } diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 2bcfce77be..f8cd193dbe 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -390,7 +390,7 @@ static void register_all(void) void avfilter_register_all(void) { - AVOnce control = AV_ONCE_INIT; + static AVOnce control = AV_ONCE_INIT; ff_thread_once(&control, register_all); } diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 62661d14a4..b3ffe0f2b6 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@ -385,7 +385,7 @@ static void register_all(void) void av_register_all(void) { - AVOnce control = AV_ONCE_INIT; + static AVOnce control = AV_ONCE_INIT; ff_thread_once(&control, register_all); }