From patchwork Sat Jun 3 00:18:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Darnley X-Patchwork-Id: 3808 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.10.2 with SMTP id 2csp430632vsk; Fri, 2 Jun 2017 17:24:45 -0700 (PDT) X-Received: by 10.223.178.68 with SMTP id y4mr5564895wra.196.1496449485451; Fri, 02 Jun 2017 17:24:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496449485; cv=none; d=google.com; s=arc-20160816; b=0cdxTUs6rsdOTUmA7csYAyYFn4QkHrh9cbUDa1F+jmpJDNE7Zf1sW+iDiFMnF7qYd2 /7ffkkiJdhBhJ9deuGaBr/KlUcD1DA7FHo9HZb3R54ISt1wv7cmAcSRGEtJjCw1XlYLk k/2dXQZ/DWQMRZmdndlDkQEJRCO/fMReVBD0vkXo0WmTTJ2Jr06dXWcMP8Htqw9fVKng z4alauunQ8OS+KkHsEliffzM7i5o0jZMAczj4LEbtMYtQ3MTV+SpkJ+5aXx2bSg0HXf7 lwKSdmSALESOnylm9eYjpXGnP9WyDl+WAi3H/OAEK+mLV/4ba7NT3GA02eDf5tUuOOns JDww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=dZaCs5oe/4qHKPG0jqD8lNFvNekVvwTM+X2yxjJKFlM=; b=h3xbq3m8JBFrmZj1RYhqLUoBVRKfyAR3/QIDKUJE0ItZEP7kcRZ1tAEuOcG2+3gFkP DcIDdcbHU+ASd6Byk9/taRNGCBr8KgcuD3HQTI3rl813jbjxG2/G0AnVyKzAdfG9IWgM ZgbyJz0NI4viJo8uXiYkON4gR2gMwqS76b3/n9og1XdbbepWRpGJSow9TVBImKJjRYmd +di6TpaR7fivYE1eoFxHHIdw51JaD7YGmP0UnIcijCTkmH9Ejwq4Uao5ChcHMqbvihSy AAugAZwr/3Z9rAIQkNGKO45IiPNohxv4O04ECo6mNwAMupHm7tJsVFsPLRljy82UXMQS FRDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k72si9153189wrc.86.2017.06.02.17.24.45; Fri, 02 Jun 2017 17:24:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E942689C6F; Sat, 3 Jun 2017 03:24:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A77D689983 for ; Sat, 3 Jun 2017 03:24:30 +0300 (EEST) Received: by mail-wm0-f52.google.com with SMTP id 7so36335281wmo.1 for ; Fri, 02 Jun 2017 17:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ob-encoder-com.20150623.gappssmtp.com; s=20150623; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=DBaREP2NO8LYhNWNEcJp3/ksUIc901CJNUJpOeIy9rg=; b=0nUu9vGmGq9bpedAcNvAMCZHqT0gsHt27HLXLsFMYPzax6/X5J98j/lKYn36NVXssC aRGISVB3yej2siKqTnsrX/D+HlC5cxa9ToQ2d86oPXBIas4Yr8w/rM8b2swW6ijsg1G/ LKXPvoeDwAuPfntUJaJa65GeOacLgoe7fsf7ZRRzqKqfMRBKb6URe6BJy1c3cLt6iMcP sownA2/UmC2WgyXF7DK/ly39tyFTBSP4jNoj0crzocOmiz6lus8jkLV0usknKgjsvUU/ M6ALXJSwTKDt46yaW9jH4eH9hnr6P3W3w/hX2HKT8Q/4L7C10d/QdQg1sNPOryYBL0Hs 4dQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=DBaREP2NO8LYhNWNEcJp3/ksUIc901CJNUJpOeIy9rg=; b=lyA/6KO90w0O08xghjJVrGbcsxL5lHAmGtKP8QvGVwuHlHbnMMyqr2Z5+h9IylOCsY IN0wP8RbBn6j5ABkACH4WGmqby89zuCTL5U80wyupPc41h+sSV9c8MlOQP0xDS14fMWr yKxYROTnVZUKCJRpGJdgYhsxSdNuF3cWzH+L9IvSw+vrMnyjbFtB0n3Zn5WvzLSf41lC my/ervK9pLYKjtsbEQY+uOvfe6U6kAGjUWFWqo+NzKM/Im3PnjJQgpO+4+S6K1a425a2 LQacTZ0P3fxYs2vaG6ktQp2fZ8rv4u6sg3yGkLpuhkThsB8V/n8YvtGfp+ZI4SFkk8eh 4ZYg== X-Gm-Message-State: AODbwcDqaTLQfa983bCF/0jJKzaEtzzyQocwfbFmIskSLuargAk803ta z3SgIUEkzkRApKhGX+g= X-Received: by 10.28.185.200 with SMTP id j191mr1108957wmf.48.1496449103444; Fri, 02 Jun 2017 17:18:23 -0700 (PDT) Received: from Highwind.systemlords.lan (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id 25sm23284762wrz.8.2017.06.02.17.18.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2017 17:18:23 -0700 (PDT) From: James Darnley To: FFmpeg development discussions and patches Date: Sat, 3 Jun 2017 02:18:04 +0200 Message-Id: <20170603001809.13960-2-jdarnley@obe.tv> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170603001809.13960-1-jdarnley@obe.tv> References: <20170603001809.13960-1-jdarnley@obe.tv> Subject: [FFmpeg-devel] [PATCH 1/6] initial alignment corrections for xmm registers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- libavcodec/x86/simple_idct.asm | 47 ++++++++++++++++++++++++++++++------------ 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/libavcodec/x86/simple_idct.asm b/libavcodec/x86/simple_idct.asm index 6fedbb5784..b5d05ca653 100644 --- a/libavcodec/x86/simple_idct.asm +++ b/libavcodec/x86/simple_idct.asm @@ -29,8 +29,8 @@ SECTION_RODATA cextern pb_80 -wm1010: dw 0, 0xffff, 0, 0xffff d40000: dd 4 << 16, 0 +wm1010: dw 0, 0xffff, 0, 0xffff ; 23170.475006 ; 22725.260826 @@ -53,30 +53,51 @@ d40000: dd 4 << 16, 0 %define ROW_SHIFT 11 %define COL_SHIFT 20 ; 6 -coeffs: +rounding: + dw 1 << (ROW_SHIFT - 1), 0 dw 1 << (ROW_SHIFT - 1), 0 dw 1 << (ROW_SHIFT - 1), 0 + dw 1 << (ROW_SHIFT - 1), 0 + +coeffs: + dw 1 << (ROW_SHIFT - 1), 1 + dw 1 << (ROW_SHIFT - 1), 0 dw 1 << (ROW_SHIFT - 1), 1 dw 1 << (ROW_SHIFT - 1), 0 + ; coeffs + 16 dw C4, C4, C4, C4 dw C4, -C4, C4, -C4 + ; coeffs + 32 dw C2, C6, C2, C6 dw C6, -C2, C6, -C2 + ; coeffs + 48 dw C1, C3, C1, C3 dw C5, C7, C5, C7 + ; coeffs + 64 dw C3, -C7, C3, -C7 dw -C1, -C5, -C1, -C5 + ; coeffs + 80 dw C5, -C1, C5, -C1 dw C7, C3, C7, C3 + ; coeffs + 96 dw C7, -C5, C7, -C5 dw C3, -C1, C3, -C1 + ; for alignment + ; coeffs + 112 + dw C3, -C1, C3, -C1 + times 8 db 0 + + ; coeffs + 128 + dw C6, -C2, C6, -C2 + + SECTION .text %macro DC_COND_IDCT 7 @@ -103,13 +124,13 @@ SECTION .text pmaddwd mm1, mm6 ; -C2R6+C6R2 -C2r6+C6r2 movq mm7, [coeffs + 48] ; C3 C1 C3 C1 pmaddwd mm7, mm2 ; C3R3+C1R1 C3r3+C1r1 - paddd mm4, [coeffs + 8] + paddd mm4, [rounding + 16] movq mm6, mm4 ; C4R4+C4R0 C4r4+C4r0 paddd mm4, mm5 ; A0 a0 psubd mm6, mm5 ; A3 a3 movq mm5, [coeffs + 56] ; C7 C5 C7 C5 pmaddwd mm5, mm3 ; C7R7+C5R5 C7r7+C5r5 - paddd mm0, [coeffs + 8] + paddd mm0, [rounding + 16] paddd mm1, mm0 ; A1 a1 paddd mm0, mm0 psubd mm0, mm1 ; A2 a2 @@ -139,7 +160,7 @@ SECTION .text pmaddwd mm1, [coeffs + 96] ; -C5R3+C7R1 -C5r3+C7r1 pmaddwd mm7, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm0 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm4, mm7 ; B2 b2 paddd mm2, mm4 ; A2+B2 a2+b2 psubd mm0, mm4 ; a2-B2 a2-b2 @@ -191,13 +212,13 @@ SECTION .text pmaddwd mm1, mm6 ; -C2R6+C6R2 -C2r6+C6r2 movq mm7, [coeffs + 48] ; C3 C1 C3 C1 pmaddwd mm7, mm2 ; C3R3+C1R1 C3r3+C1r1 - paddd mm4, [coeffs] + paddd mm4, [rounding] movq mm6, mm4 ; C4R4+C4R0 C4r4+C4r0 paddd mm4, mm5 ; A0 a0 psubd mm6, mm5 ; A3 a3 movq mm5, [coeffs + 56] ; C7 C5 C7 C5 pmaddwd mm5, mm3 ; C7R7+C5R5 C7r7+C5r5 - paddd mm0, [coeffs] + paddd mm0, [rounding] paddd mm1, mm0 ; A1 a1 paddd mm0, mm0 psubd mm0, mm1 ; A2 a2 @@ -227,7 +248,7 @@ SECTION .text pmaddwd mm1, [coeffs + 96] ; -C5R3+C7R1 -C5r3+C7r1 pmaddwd mm7, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm0 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm4, mm7 ; B2 b2 paddd mm2, mm4 ; A2+B2 a2+b2 psubd mm0, mm4 ; a2-B2 a2-b2 @@ -298,7 +319,7 @@ SECTION .text pmaddwd mm0, [coeffs + 96] ; -C5R3+C7R1 -C5r3+C7r1 pmaddwd mm7, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm5 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm4, mm7 ; B2 b2 paddd mm2, mm4 ; A2+B2 a2+b2 psubd mm5, mm4 ; a2-B2 a2-b2 @@ -363,7 +384,7 @@ SECTION .text movq mm1, [coeffs + 88] ; C3 C7 C3 C7 pmaddwd mm1, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm5 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm2, mm1 ; A2+B2 a2+b2 psubd mm5, mm1 ; a2-B2 a2-b2 psrad mm2, %6 @@ -417,7 +438,7 @@ SECTION .text movq mm1, [coeffs + 88] ; C3 C7 C3 C7 pmaddwd mm1, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm5 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm2, mm1 ; A2+B2 a2+b2 psubd mm5, mm1 ; a2-B2 a2-b2 psrad mm2, %6 @@ -481,7 +502,7 @@ SECTION .text pmaddwd mm0, [coeffs + 96] ; -C5R3+C7R1 -C5r3+C7r1 pmaddwd mm7, mm3 ; C3R7+C7R5 C3r7+C7r5 movq mm2, mm5 ; A2 a2 - pmaddwd mm3, [coeffs + 104] ; -C1R7+C3R5 -C1r7+C3r5 + pmaddwd mm3, [coeffs + 112] ; -C1R7+C3R5 -C1r7+C3r5 paddd mm4, mm7 ; B2 b2 paddd mm2, mm4 ; A2+B2 a2+b2 psubd mm5, mm4 ; a2-B2 a2-b2 @@ -582,7 +603,7 @@ SECTION .text pmaddwd mm2, mm7 ; -C4R4+C4R0 -C4r4+C4r0 movq mm7, [coeffs + 32] ; C6 C2 C6 C2 pmaddwd mm7, mm3 ; C6R6+C2R2 C6r6+C2r2 - pmaddwd mm3, [coeffs + 40] ; -C2R6+C6R2 -C2r6+C6r2 + pmaddwd mm3, [coeffs + 128] ; -C2R6+C6R2 -C2r6+C6r2 paddd mm7, mm1 ; A0 a0 paddd mm1, mm1 ; 2C0 2c0 psubd mm1, mm7 ; A3 a3