From patchwork Sat Jun 10 11:46:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Darnley X-Patchwork-Id: 3900 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.10.195 with SMTP id 186csp133001vsk; Sat, 10 Jun 2017 04:53:30 -0700 (PDT) X-Received: by 10.28.15.84 with SMTP id 81mr2748095wmp.52.1497095610018; Sat, 10 Jun 2017 04:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497095609; cv=none; d=google.com; s=arc-20160816; b=z7jYp6HwyjqVUOoKEsTCAhUlcihC8dNfEHYe0kCgj0nQfQWYLXb/lidQlrZcIMtyv2 YeILvpTaCl2EyaK8CWzO6iGNlWUPwqdhJL/YPY+as+k5K4D+rsJxiZ9ugMPOXct5aZtZ XiRV0YVf3dcTK1I5XBcdk45+tU050f4NHSYhDEVfPLi/nUgCPggmPzkuBb695u195kDX 7Kp11x4fRpsen9de/O0HJ69IGDGtQDH+3FRHjTa1fR3JfBErAMkfnS3d43GHm8CSIWxJ v/Yreh1A5ZYX8/SrSR146R4G6lJJAsYWnFxMHrZIBLpBcF/MlRvW8mF66ebsuRkGHF68 KOiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=bTWwbGazHVXxfXqdZGCzumLN3KZ0nzd20GhyhlOhHFg=; b=q4XuNvhXzsdUi/LiiqHkpn96weQldwSV3J9yAxPqIhq2Z6u6tQnAhTEUX3SEzwRhbH 6ivNrCiFP6bzTqI07GD1J9Hj8qj5cQIRTdZhL+ooll9J8jEhiMFGXlpmxzqti/fx6jTj CrVqeXxOqq1/DFCQCml0Gl97S9XX5w/6uDr75BpUkRMPmgVtuSeRAKNJkKHp0iET2Hxc he8KNCdLaQDyHH0GL2usPWp3X8BcUpx0pdLg+jSigvhCG7c5JEHUUtIZaYx6zBrB1/Jn Se2KxPzuyJtfd54eYGu9WKaiZVXSdkkLxOFSD25Awuvbb1CwNTrbsdt+CHtKb+d1Efrl 0jQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com header.b=qum1lvFI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f68si2381264wma.73.2017.06.10.04.53.29; Sat, 10 Jun 2017 04:53:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ob-encoder-com.20150623.gappssmtp.com header.b=qum1lvFI; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 231A4689F1A; Sat, 10 Jun 2017 14:53:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D85A0689B4F for ; Sat, 10 Jun 2017 14:53:19 +0300 (EEST) Received: by mail-wr0-f196.google.com with SMTP id g76so11924248wrd.2 for ; Sat, 10 Jun 2017 04:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ob-encoder-com.20150623.gappssmtp.com; s=20150623; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=LPJgCG2Yyvp985niM/SQMTeV6hhkkU8mlKQ4H2mIcRQ=; b=qum1lvFImbi1FIKwqEpqA4kxe4d7wHZG6u7tmcokxwLErgUaUEEltnWZq+QYOO6P1l /dP9BTdNV0FbNd+ZzMSQeDShKaKyml7/SWtf5eXB1aLN6BlbHApq1/VQ8uMN7RQaOxNK 4eXwnLxWSh9LzruJXE7K1a/hL9Hah4NWYJbIuMgnu6fmoVEr4nLjzlEmuwXjiX8dh/Ew MBBcSbmpGps+WkNH7OQN8XdtRPVNjS9mwb9J1AOW5i5/dgD7/gdr0Ulv489i/e0jVEqv yuhRCoykhfo62d8w64qOOizbTw4qxnMBoowdbNU13KbYNd9YcJpPTvFNEqcetvtOdifj eKfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=LPJgCG2Yyvp985niM/SQMTeV6hhkkU8mlKQ4H2mIcRQ=; b=nTEMD8qBVGwIwdDvFUOaEmjIctgpHehM4e5/TgKsHC0E0z2PIm5v+O0Eoqzs8hLX2o 41wdL6zu/9w6IERDgh32XZK0kWbSNAFswO+LQ7qMrhc1Rck9bs+q7xBpm6HaHiptVgXC 9WTqMlZga0GI2BDGfSe0Kqted5Q79Y4gEbhaUiKjBsFrAhwZHcwGEbMCmwW6sYxnykqe 3mjDHkzwDjQsibkAja/mMKYoaN7qgJQhuz7Aenpi21bw1VaknIOrOYXrAo2a0RcW51ye CJkITQF8J+MEW7Dt1T9oPXZ8aATDYinKs/TaYEiTw3T57TAmf6ovyUfx0z/aNaxHLS7N CwQw== X-Gm-Message-State: AKS2vOx5if0lbhfIkzInskzyNIqwLdampfgM6flrB1KciXdBAhEd5Jtz JCMFEAFTZtzUt9Fk0FM= X-Received: by 10.223.150.13 with SMTP id b13mr2091834wra.67.1497095221679; Sat, 10 Jun 2017 04:47:01 -0700 (PDT) Received: from Highwind.systemlords.lan (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id c71sm1575231wmh.21.2017.06.10.04.47.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jun 2017 04:47:01 -0700 (PDT) From: James Darnley To: FFmpeg development discussions and patches Date: Sat, 10 Jun 2017 13:46:40 +0200 Message-Id: <20170610114644.3138-2-jdarnley@obe.tv> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170610114644.3138-1-jdarnley@obe.tv> References: <20170610114644.3138-1-jdarnley@obe.tv> Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/x86: cleanup simple_idct10 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Use named arguments for the functions so we can remove a define. The stride/linesize argument is now ptrdiff_t type so we no longer need to sign extend the register. --- libavcodec/x86/proresdsp.asm | 2 +- libavcodec/x86/simple_idct10.asm | 8 ++-- libavcodec/x86/simple_idct10_template.asm | 64 ++++++++++++++----------------- 3 files changed, 33 insertions(+), 41 deletions(-) diff --git a/libavcodec/x86/proresdsp.asm b/libavcodec/x86/proresdsp.asm index 16fc262aeb..8318a81c5e 100644 --- a/libavcodec/x86/proresdsp.asm +++ b/libavcodec/x86/proresdsp.asm @@ -51,7 +51,7 @@ cextern w7_min_w5 SECTION .text %macro idct_fn 0 -cglobal prores_idct_put_10, 4, 4, 15 +cglobal prores_idct_put_10, 4, 4, 15, pixels, lsize, block, qmat IDCT_FN pw_1, 15, pw_88, 18, pw_4, pw_1019, r3 RET %endmacro diff --git a/libavcodec/x86/simple_idct10.asm b/libavcodec/x86/simple_idct10.asm index 5dee533de0..7cfd33eaa3 100644 --- a/libavcodec/x86/simple_idct10.asm +++ b/libavcodec/x86/simple_idct10.asm @@ -68,21 +68,21 @@ CONST_DEC w7_min_w5, W7sh2, -W5sh2 SECTION .text %macro idct_fn 0 -cglobal simple_idct10, 1, 1, 16 +cglobal simple_idct10, 1, 1, 16, block IDCT_FN "", 12, "", 19 RET -cglobal simple_idct10_put, 3, 3, 16 +cglobal simple_idct10_put, 3, 3, 16, pixels, lsize, block IDCT_FN "", 12, "", 19, 0, pw_1023 RET -cglobal simple_idct12, 1, 1, 16 +cglobal simple_idct12, 1, 1, 16, block ; coeffs are already 15bits, adding the offset would cause ; overflow in the input IDCT_FN "", 15, pw_2, 16 RET -cglobal simple_idct12_put, 3, 3, 16 +cglobal simple_idct12_put, 3, 3, 16, pixels, lsize, block ; range isn't known, so the C simple_idct range is used ; Also, using a bias on input overflows, so use the bias ; on output of the first butterfly instead diff --git a/libavcodec/x86/simple_idct10_template.asm b/libavcodec/x86/simple_idct10_template.asm index 9d323d99b3..c0d1637ca2 100644 --- a/libavcodec/x86/simple_idct10_template.asm +++ b/libavcodec/x86/simple_idct10_template.asm @@ -115,18 +115,18 @@ psubd m3, m9 ; a1[4-7] intermediate ; load/store - mova [COEFFS+ 0], m0 - mova [COEFFS+ 32], m2 - mova [COEFFS+ 64], m4 - mova [COEFFS+ 96], m6 - mova m10,[COEFFS+ 16] ; { row[1] }[0-7] - mova m8, [COEFFS+ 48] ; { row[3] }[0-7] - mova m13,[COEFFS+ 80] ; { row[5] }[0-7] - mova m14,[COEFFS+112] ; { row[7] }[0-7] - mova [COEFFS+ 16], m1 - mova [COEFFS+ 48], m3 - mova [COEFFS+ 80], m5 - mova [COEFFS+112], m7 + mova [blockq+ 0], m0 + mova [blockq+ 32], m2 + mova [blockq+ 64], m4 + mova [blockq+ 96], m6 + mova m10,[blockq+ 16] ; { row[1] }[0-7] + mova m8, [blockq+ 48] ; { row[3] }[0-7] + mova m13,[blockq+ 80] ; { row[5] }[0-7] + mova m14,[blockq+112] ; { row[7] }[0-7] + mova [blockq+ 16], m1 + mova [blockq+ 48], m3 + mova [blockq+ 80], m5 + mova [blockq+112], m7 %if %0 == 3 pmullw m10,[%3+ 16] pmullw m8, [%3+ 48] @@ -197,17 +197,17 @@ ; row[5] = (a2 - b2) >> 15; ; row[3] = (a3 + b3) >> 15; ; row[4] = (a3 - b3) >> 15; - mova m8, [COEFFS+ 0] ; a0[0-3] - mova m9, [COEFFS+16] ; a0[4-7] + mova m8, [blockq+ 0] ; a0[0-3] + mova m9, [blockq+16] ; a0[4-7] SUMSUB_SHPK m8, m9, m10, m11, m0, m1, %2 - mova m0, [COEFFS+32] ; a1[0-3] - mova m1, [COEFFS+48] ; a1[4-7] + mova m0, [blockq+32] ; a1[0-3] + mova m1, [blockq+48] ; a1[4-7] SUMSUB_SHPK m0, m1, m9, m11, m2, m3, %2 - mova m1, [COEFFS+64] ; a2[0-3] - mova m2, [COEFFS+80] ; a2[4-7] + mova m1, [blockq+64] ; a2[0-3] + mova m2, [blockq+80] ; a2[4-7] SUMSUB_SHPK m1, m2, m11, m3, m4, m5, %2 - mova m2, [COEFFS+96] ; a3[0-3] - mova m3, [COEFFS+112] ; a3[4-7] + mova m2, [blockq+96] ; a3[0-3] + mova m3, [blockq+112] ; a3[4-7] SUMSUB_SHPK m2, m3, m4, m5, m6, m7, %2 %endmacro @@ -223,20 +223,12 @@ ; %7 = qmat (for prores) %macro IDCT_FN 4-7 -%if %0 == 4 - ; No clamping, means pure idct -%xdefine COEFFS r0 -%else - movsxd r1, r1d -%xdefine COEFFS r2 -%endif - ; for (i = 0; i < 8; i++) ; idctRowCondDC(block + i*8); - mova m10,[COEFFS+ 0] ; { row[0] }[0-7] - mova m8, [COEFFS+32] ; { row[2] }[0-7] - mova m13,[COEFFS+64] ; { row[4] }[0-7] - mova m12,[COEFFS+96] ; { row[6] }[0-7] + mova m10,[blockq+ 0] ; { row[0] }[0-7] + mova m8, [blockq+32] ; { row[2] }[0-7] + mova m13,[blockq+64] ; { row[4] }[0-7] + mova m12,[blockq+96] ; { row[6] }[0-7] %if %0 == 7 pmullw m10,[%7+ 0] @@ -251,10 +243,10 @@ ; transpose for second part of IDCT TRANSPOSE8x8W 8, 0, 1, 2, 4, 11, 9, 10, 3 - mova [COEFFS+ 16], m0 - mova [COEFFS+ 48], m2 - mova [COEFFS+ 80], m11 - mova [COEFFS+112], m10 + mova [blockq+ 16], m0 + mova [blockq+ 48], m2 + mova [blockq+ 80], m11 + mova [blockq+112], m10 SWAP 8, 10 SWAP 1, 8 SWAP 4, 13