diff mbox

[FFmpeg-devel,3/5] avcodec/utvideodec: enable unchecked bitreader

Message ID 20170627194735.27533-3-michael@niedermayer.cc
State Accepted
Commit 676a589c936b7b475b8008ce51c968c376b173b8
Headers show

Commit Message

Michael Niedermayer June 27, 2017, 7:47 p.m. UTC
inner reader loop becomes 16% faster

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/utvideodec.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kieran Kunhya June 27, 2017, 9:07 p.m. UTC | #1
On Tue, 27 Jun 2017 at 20:48 Michael Niedermayer <michael@niedermayer.cc>
wrote:

> inner reader loop becomes 16% faster
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/utvideodec.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> index 411df47730..1418cde543 100644
> --- a/libavcodec/utvideodec.c
> +++ b/libavcodec/utvideodec.c
> @@ -27,6 +27,8 @@
>  #include <inttypes.h>
>  #include <stdlib.h>
>
> +#define UNCHECKED_BITSTREAM_READER 1
> +
>  #include "libavutil/intreadwrite.h"
>  #include "avcodec.h"
>  #include "bswapdsp.h"
> --
> 2.13.0
>

Asking for trouble unless fuzzed well.

Kieran
Paul B Mahol June 27, 2017, 9:30 p.m. UTC | #2
On 6/27/17, Kieran Kunhya <kierank@obe.tv> wrote:
> On Tue, 27 Jun 2017 at 20:48 Michael Niedermayer <michael@niedermayer.cc>
> wrote:
>
>> inner reader loop becomes 16% faster
>>
>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>> ---
>>  libavcodec/utvideodec.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
>> index 411df47730..1418cde543 100644
>> --- a/libavcodec/utvideodec.c
>> +++ b/libavcodec/utvideodec.c
>> @@ -27,6 +27,8 @@
>>  #include <inttypes.h>
>>  #include <stdlib.h>
>>
>> +#define UNCHECKED_BITSTREAM_READER 1
>> +
>>  #include "libavutil/intreadwrite.h"
>>  #include "avcodec.h"
>>  #include "bswapdsp.h"
>> --
>> 2.13.0
>>
>
> Asking for trouble unless fuzzed well.

Not really, it allocates enough bytes extra.
diff mbox

Patch

diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
index 411df47730..1418cde543 100644
--- a/libavcodec/utvideodec.c
+++ b/libavcodec/utvideodec.c
@@ -27,6 +27,8 @@ 
 #include <inttypes.h>
 #include <stdlib.h>
 
+#define UNCHECKED_BITSTREAM_READER 1
+
 #include "libavutil/intreadwrite.h"
 #include "avcodec.h"
 #include "bswapdsp.h"