From patchwork Fri Jun 30 13:02:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 4163 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp5730900vsb; Fri, 30 Jun 2017 06:03:08 -0700 (PDT) X-Received: by 10.223.162.208 with SMTP id t16mr29703827wra.151.1498827788227; Fri, 30 Jun 2017 06:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498827788; cv=none; d=google.com; s=arc-20160816; b=JlhP178W+IIfRRsSfFpRmOKnWugqAJ+DCJu0qeEByiuaSK4pBjJ5PGhfO8dMAdjR0i 4wjpE4VSfOlqBqubMgmVqxVfr2GM7hXrn874i36Rl4pBptqYw14EyxV1sNsz4aB3uDwL 9gKWjpUzcHaIw1k2TuFmu56kZHrnSHeQbcO3WF6RF5pjZi/SonOPdXiX37doWhD40NSY mF57kMM632Kp9Y6WXN6EOext9u9RYQUC7WcXvg+E05YnCtYvzMcHwyNGWYhRn0ubWtQm JLLCSlbzao+XUZ5M3peT1yyHv9iFmTscCiEvX2v+q10lIkaRrSSAU3qpWermArdkT4Rd c3IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=isdvHzNOFCbLpYG+4DG/a787RbC0safP2jMF+UWR/oE=; b=QJKhaKeiK6Ipz0FQltp68CEixQY2VyMQTfzphhNIgdkwcqPxOJYfWu+cf35y5g0a9m OcXQMI0q94yfFk0YOP953mtF27+Kz8LitNdbwR0ONdV0NTiebhpsQPkEeuUoYqjTYku7 WvoqN/FiWwzTb4J/X00njzwWfp8pMZkW7VV2b8FB0LO92UUX/VceS8uEyQ5m3O1Z1Dgc n6ic2m7iL/4KpoMY7h+L6yLaTLmPwy69jnaeLj2eeM8l24LtNiOP+veMoMkjOkcQVsJI sQmmDbmKvznPJTHoHh1c212yOSdx5qAiKfUjBtMYDg9mTUVbe4bK++mMTowdkHa9z2B6 n6fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w1si6544973wrb.205.2017.06.30.06.03.07; Fri, 30 Jun 2017 06:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA874689F89; Fri, 30 Jun 2017 16:03:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF0F7689E7B for ; Fri, 30 Jun 2017 16:02:57 +0300 (EEST) Received: from mfilter14-d.gandi.net (mfilter14-d.gandi.net [217.70.178.142]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id 917AEC5A5C for ; Fri, 30 Jun 2017 15:02:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter14-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter14-d.gandi.net (mfilter14-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id wjZk5CgpHyq8 for ; Fri, 30 Jun 2017 15:02:55 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9B9EBC5A43 for ; Fri, 30 Jun 2017 15:02:55 +0200 (CEST) Date: Fri, 30 Jun 2017 15:02:41 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170630130241.GD4727@nb4> References: <20170626140958.2881-1-onemda@gmail.com> <20170626215535.24530-1-onemda@gmail.com> MIME-Version: 1.0 In-Reply-To: <20170626215535.24530-1-onemda@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/proresenc: switch default prores encoder to prores_ks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Mon, Jun 26, 2017 at 11:55:35PM +0200, Paul B Mahol wrote: > Rationale: > prores_ks have more features and is faster for qscale > 0 > and gives better quality output. > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 2 +- > libavcodec/proresenc_anatoliy.c | 14 -------------- > libavcodec/proresenc_kostya.c | 24 ++++++++++++++++++++++++ > tests/fate/vcodec.mak | 1 + > tests/ref/vsynth/vsynth1-prores | 8 ++++---- > tests/ref/vsynth/vsynth2-prores | 8 ++++---- > tests/ref/vsynth/vsynth3-prores | 8 ++++---- > 7 files changed, 38 insertions(+), 27 deletions(-) breaks fate Test vsynth_lena-prores failed. Look at tests/data/fate/vsynth_lena-prores.err for details. make: *** [fate-vsynth_lena-prores] Error 1 make: *** Waiting for unfinished jobs.... [...] --- ./tests/ref/vsynth/vsynth_lena-prores 2017-06-28 16:52:13.778069506 +0200 +++ tests/data/fate/vsynth_lena-prores 2017-06-30 14:42:11.173544386 +0200 @@ -1,4 +1,4 @@ -637f34b5fd81f072f76a967595fa6af7 *tests/data/fate/vsynth_lena-prores.mov -2844076 tests/data/fate/vsynth_lena-prores.mov -03fd29e3963716a09d232b6f817ecb57 *tests/data/fate/vsynth_lena-prores.out.rawvideo -stddev: 1.31 PSNR: 45.77 MAXDIFF: 11 bytes: 7603200/ 7603200 +032c3cd69efc2b13dcdb8505c587d2b5 *tests/data/fate/vsynth_lena-prores.mov +7925557 tests/data/fate/vsynth_lena-prores.mov +97c55951310fef217eb11e03e24d2403 *tests/data/fate/vsynth_lena-prores.out.rawvideo +stddev: 0.43 PSNR: 55.38 MAXDIFF: 6 bytes: 7603200/ 7603200