From patchwork Mon Jul 3 09:49:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 4196 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp9195993vsb; Mon, 3 Jul 2017 02:49:21 -0700 (PDT) X-Received: by 10.223.165.13 with SMTP id i13mr35557782wrb.35.1499075361579; Mon, 03 Jul 2017 02:49:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499075361; cv=none; d=google.com; s=arc-20160816; b=dofML4nBtXcj0fm15oQ2t68IE9h4CkHyG+vunniD3vBHsvYjBRCveCAjSVvMIEtaR2 8evg9gytFHwEohdCfsM+xKjkGgXoo6xOW9O8S6sHlPJcmwQqff4JllD+rF0swzJLsILk F8Gzq7040smt/J5RwrMESNMOxl5Wo3MNR2L97kH9ljvU50XP3WgtcbuTUgQotjYLGKPU stXPcxBkh8LHha2glQqtWjjSWKlf8etIRnYYdNcCCtA7aXyVaPL/69bH6qOf6fp7nm2v KOG/PFcgP5BTfJwFBpJVNT+T7YfslfAByYC5gaatwmyYkcTCApYRzxcqrVzfSKxsvTmF cjig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=pnM0RHPCvynON8omr1/KQdJudR6RpLHPSxfVY5KMjMM=; b=aegR9SfV5fC92g058hMfBuKq5zooxTPBqFZv0bBl16HpbrJGPSTX4o8ODDHJCCa9eK QPAIgLwqeQsog4Mf7JayEIzXkBFujRHxAoaWTSbkkK/f6JQZWKI+UQcwzKRtk7+sTauc L2J5eYcJiMokDzammCKScKfiiHl+h41yo00VtmhZ11Ep6TMXTHslEtGfadSwEIlKrehG Z5eg4rysNibCj7BZUdYYx//64EPu9FmKTOpkEN6pkwnaayk5KjP7oXLS4itTI+eDbAfd BOz0tvdFGwH7ttwlSmkdSvSRFKfDxj5JnzGruPGH4wTiIpsGp7pJwHx+vjcooVMout0H vV/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=CjgQAV8v; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z142si9991478wmc.38.2017.07.03.02.49.21; Mon, 03 Jul 2017 02:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=CjgQAV8v; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 97BB86882C2; Mon, 3 Jul 2017 12:49:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE0EF6805A7 for ; Mon, 3 Jul 2017 12:49:11 +0300 (EEST) Received: by mail-wr0-f196.google.com with SMTP id k67so44122568wrc.1 for ; Mon, 03 Jul 2017 02:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=fJU914ur2KL+GavoGg34sfm4DheOkGO2U2ehnOfJtuE=; b=CjgQAV8v5rHeyykDAsvmUwAcYDw5mtYqaGb3cpQf/0a8yl5gxpMDJ+nWkkIWOM58hs 5JBOrO2K5Kl4IMrYWatQszuv02DaNPMWWJsDFkjrtQF9NkFOHdMStRiivPyCSS3MBDuH P+2LOLsxoyEPWeF/0Q6bC8GntIqCksVEQaCWi0ORXHcunARZ9yDCfyEnkdHEnREn6qC0 +NnbxXJudgEWZI7BAMf8Rwc4YkkXhghg/xAN3Xvhhea2AsDreTa3BrU+9Ea7xK2SCBxH qhY5nH+3zRAvY52kZtDtYC8yl4YwHGhlIdyuv3CJ0Pur3FQ0nC7q98+urRTQkcsfsdON Kouw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=fJU914ur2KL+GavoGg34sfm4DheOkGO2U2ehnOfJtuE=; b=iW0dKeyK9+uztahKU0QtG3R/zpA414udMCCVZD68Myxo5KipfnsmadA84fB26sK/Ac 7ysdg8bbvM5qwtbCdf/99TDWJHZXPA46BS3qR1DfLuz0DKTq4g1gcq5YsOYSjM6P/40T PZr9flBPvpQso/iuyqTIaVqKYKPVJCaQL5zqqoud8L4BQfFIhG7fET5u8rHlH7K7WmL8 vxPthzuGLRcap0pStgToYSUAVptg6FllDnXiaTUr+Tjz6dsdJHQCsqbXRdiZQbiHKfKI IbxsGl7sFkE/7WizEJaPakCfFxDWbLytmJe9i5LA45XbqHMyoJLriH9ZqPIedutdf9PE Gekw== X-Gm-Message-State: AKS2vOwAD+749Ety41SoIHYsrf0FIMoVCGkAGavFuPigQ7eeuWfKAlgS EDRo9G+RN4TqczQV X-Received: by 10.223.176.218 with SMTP id j26mr32535058wra.192.1499075352772; Mon, 03 Jul 2017 02:49:12 -0700 (PDT) Received: from localhost.localdomain ([94.250.174.60]) by smtp.gmail.com with ESMTPSA id 187sm15975475wma.13.2017.07.03.02.49.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2017 02:49:11 -0700 (PDT) From: Paul B Mahol To: ffmpeg-devel@ffmpeg.org Date: Mon, 3 Jul 2017 11:49:02 +0200 Message-Id: <20170703094902.15630-1-onemda@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [FFmpeg-devel] [PATCH] avcodec/alsdec: fix some undefined shifts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Paul B Mahol --- libavcodec/alsdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index 37d6b38..df5e2bb 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -756,7 +756,7 @@ static int read_var_block_data(ALSDecContext *ctx, ALSBlockData *bd) } for (k = 2; k < opt_order; k++) - quant_cof[k] = (quant_cof[k] << 14) + (add_base << 13); + quant_cof[k] = (quant_cof[k] * (1 << 14)) + (add_base << 13); } } @@ -861,7 +861,7 @@ static int read_var_block_data(ALSDecContext *ctx, ALSBlockData *bd) res >>= 1; if (cur_k) { - res <<= cur_k; + res *= 1 << cur_k; res |= get_bits_long(gb, cur_k); } }