From patchwork Tue Jul 4 18:01:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Constantino X-Patchwork-Id: 4211 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp1286980vsb; Tue, 4 Jul 2017 11:07:57 -0700 (PDT) X-Received: by 10.28.20.76 with SMTP id 73mr18998998wmu.66.1499191677261; Tue, 04 Jul 2017 11:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499191677; cv=none; d=google.com; s=arc-20160816; b=UAGiAOIq8h2OMK3re60H18C6dr1MkZ5mMl76meApeA2FHv0r7dwxoFwtZVZWKoXeYU MTOoYds2Griei4V8GLuoyEErhMnk4LnRVEqzoz0seZwxy1TCGXgCIwYmKwRaJd31TYSc 864zcLWIB0ZoHTER256vDHwweT6iImf/7SwIjiQxDanye80zMaugBf0oa6oGOsuW3S4V /sPE41jvfuVCbSnLdLyKZ831lzuoTyEis8fI59SHy0IHTQY6kVqF/oErSnIvsP/NPr4v alpVvBVE95Ptdb7Hc7WoXTLFd8SEqOmIjpB7OTxqjV7pugXHavVEEKCSyc8Uom25Lu7C HbWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=ZbksyD8mB0nXriShn5+N8LN/1BuCLW4ripeYCWa4EkY=; b=zJoRsspJi0hrXpSpLI4bTkYUAK7gypRr6kedepnyGg0zMpBjiOO2w3qqojpdFbtkFZ be163oGHIpg2xIIiYA5HnncjbIAUkO/3r97NhdLUq5P++VO7JQNMw9WzKxLbuiPj3WsX wtLuYD6w3LZolfN0nTMBQqWNVITK+EXhmvlUBcdP5ytUh2T6KE1Z4uHegkByKYSPFcKo ampgx8IeL0tRJyav/y5NPyu7jMq6YXKx26qT3BZl51XHpmPzrZeRWx9pwCwtRlowWhQJ KupIOizl7xDWTBWztC595jdUAB7usppoGVsYZ+RVQc7q8QIFMq+GSCeMpfQqVKLHWO0c nq2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=RPZqYEtk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 6si18801680wmt.84.2017.07.04.11.07.55; Tue, 04 Jul 2017 11:07:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=RPZqYEtk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17480688325; Tue, 4 Jul 2017 21:07:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FE1D680ABA for ; Tue, 4 Jul 2017 21:07:45 +0300 (EEST) Received: by mail-wm0-f53.google.com with SMTP id f67so91656933wmh.1 for ; Tue, 04 Jul 2017 11:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=szkQQRC12KRLmaHSuAT775b+kwTnD5zWPovfsWC6/x8=; b=RPZqYEtkeOsRrnoh6eNlMEVL8t0EXOAxrBQG1Ri+EyCtB8cR2RnkPpS8NaInOKsZ11 Z6jOsVQ07fghZ8gs2s42L/4z//ls+xC6pVLPqh+7OEYTK8TJqehgn6h6M+4AW2A9yD8z gSBugKVCIBVgMMT/JJLHHzYL6z2RAisoH9gsYzoO1Zkskw72ASpZT8LIeGGgPzWZ2hjq OJcEHg98yP6pFQFLwc/YGqNz46mtEVyeisutgZGXr9X5fSz0tVSBtD6M8GI+hQ3FkUYy ckizsI0EiczCHLMH46OGXvDxme0pkT1gXn75qO2It+AtAYPBw3XtvAyKx2krLm9gTSY0 vFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=szkQQRC12KRLmaHSuAT775b+kwTnD5zWPovfsWC6/x8=; b=LXBNxxprMHYfRQdwEUNdqFO5Ef3GmHfJuAKXo8jG0h8b6ehzqW+Utxc1HVl8r4L+VT 81ktDG7LOuv0xmeWtvErcrrtIb8Ni4hFHEPnV6+DpLS/7iy/obe6zu8piIPsbDxHXUOi pkeGw3VdJJq1etQev6iZ7P1SSNYsQzd2qCOY9gl0eOMMh/NyPArXloTR+68L8loAW+CF WqdDDrfF81CsW8RAEuQdE2MBg1SnJ8JWnrerwDScKit99ozNfKxu6eXmx5NR+fXS8MaN L8/gYPWw4rlyVzb//+Iv37LgHrwB6R9eBF3xDuyGEK9o1OwIkExuYX1bPY2y18fjzTMH AjRQ== X-Gm-Message-State: AIVw111c0ocO6VaZH7wBWgubBk4gKMFmwbCM6o09FgHWU9tZBbqOCORN q7EITdqwfXboRx5AH7U= X-Received: by 10.28.105.91 with SMTP id e88mr7266893wmc.52.1499191294117; Tue, 04 Jul 2017 11:01:34 -0700 (PDT) Received: from localhost.localdomain (10.246.114.89.rev.vodafone.pt. [89.114.246.10]) by smtp.gmail.com with ESMTPSA id 35sm15625427wrp.63.2017.07.04.11.01.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 11:01:32 -0700 (PDT) From: Ricardo Constantino To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Jul 2017 19:01:22 +0100 Message-Id: <20170704180122.11012-1-wiiaboo@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170630180645.11192-1-wiiaboo@gmail.com> References: <20170630180645.11192-1-wiiaboo@gmail.com> Subject: [FFmpeg-devel] [PATCH v3] configure: require pkg-config for libvorbis X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" libvorbis comes with pkg-config files since at least v1.0.1, way back in 2003. We need the two checks for vorbis and vorbisenc because we use functions from both and Xiph considers them separate libraries. The check is inverted (vorbis first then vorbisenc) because add_extralibs() prepends to EXTRALIBS instead of appending. For both shared and static linking the order didn't seem to matter anyway, testing with MinGW. This alternative check was suggested by Derek Buitenhuis. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 282114d268..1c65b536d5 100755 --- a/configure +++ b/configure @@ -5902,7 +5902,8 @@ enabled libtwolame && require libtwolame twolame.h twolame_init -ltwolame enabled libv4l2 && require_pkg_config libv4l2 libv4l2.h v4l2_ioctl enabled libvidstab && require_pkg_config "vidstab >= 0.98" vid.stab/libvidstab.h vsMotionDetectInit enabled libvo_amrwbenc && require libvo_amrwbenc vo-amrwbenc/enc_if.h E_IF_init -lvo-amrwbenc -enabled libvorbis && require libvorbis vorbis/vorbisenc.h vorbis_info_init -lvorbisenc -lvorbis -logg +enabled libvorbis && require_pkg_config vorbis vorbis/codec.h vorbis_info_init && + require_pkg_config vorbisenc vorbis/vorbisenc.h vorbis_encode_init enabled libvpx && { enabled libvpx_vp8_decoder && {