diff mbox

[FFmpeg-devel,12/12] bitstream_filter: Add missing error check

Message ID 20170706182842.7785-13-derek.buitenhuis@gmail.com
State Accepted
Commit 51db262312558fc62b8b89a138b280e612f37509
Headers show

Commit Message

Derek Buitenhuis July 6, 2017, 6:28 p.m. UTC 
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 libavcodec/bitstream_filter.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer July 6, 2017, 8:35 p.m. UTC | #1 
On 7/6/2017 3:28 PM, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  libavcodec/bitstream_filter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/bitstream_filter.c b/libavcodec/bitstream_filter.c
> index e9291aba19..8599b90d4a 100644
> --- a/libavcodec/bitstream_filter.c
> +++ b/libavcodec/bitstream_filter.c
> @@ -122,6 +122,8 @@ int av_bitstream_filter_filter(AVBitStreamFilterContext *bsfc,
>                  shorthand[0] = opt->name;
>  
>              ret = av_opt_set_from_string(priv->ctx->priv_data, bsfc->args, shorthand, "=", ":");
> +            if (ret < 0)
> +                return ret;
>          }
>  
>          ret = av_bsf_init(priv->ctx);
> 

LGTM (Nobody should be using the old bsf API, though).
diff mbox

Patch

diff --git a/libavcodec/bitstream_filter.c b/libavcodec/bitstream_filter.c
index e9291aba19..8599b90d4a 100644
--- a/libavcodec/bitstream_filter.c
+++ b/libavcodec/bitstream_filter.c
@@ -122,6 +122,8 @@  int av_bitstream_filter_filter(AVBitStreamFilterContext *bsfc,
                 shorthand[0] = opt->name;
 
             ret = av_opt_set_from_string(priv->ctx->priv_data, bsfc->args, shorthand, "=", ":");
+            if (ret < 0)
+                return ret;
         }
 
         ret = av_bsf_init(priv->ctx);