diff mbox

[FFmpeg-devel] avcodec/hevcdec: hevc_await_progress: declare |y| only if used.

Message ID 20170720183911.52063-1-wtc@google.com
State Accepted
Commit b77e26b28525f366c5f978214b230a5324bedf81
Headers show

Commit Message

Wan-Teh Chang July 20, 2017, 6:39 p.m. UTC
hevc_await_progress() uses the variable |y| only inside the "if" block.
So |y| only needs to be declared and initialized in that block.

Signed-off-by: Wan-Teh Chang <wtc@google.com>
---
 libavcodec/hevcdec.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer July 20, 2017, 10:16 p.m. UTC | #1
On Thu, Jul 20, 2017 at 11:39:11AM -0700, Wan-Teh Chang wrote:
> hevc_await_progress() uses the variable |y| only inside the "if" block.
> So |y| only needs to be declared and initialized in that block.
> 
> Signed-off-by: Wan-Teh Chang <wtc@google.com>
> ---
>  libavcodec/hevcdec.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

will apply

thanks

[...]
diff mbox

Patch

diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 55f51211c3..e084d75767 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -1684,10 +1684,11 @@  static void chroma_mc_bi(HEVCContext *s, uint8_t *dst0, ptrdiff_t dststride, AVF
 static void hevc_await_progress(HEVCContext *s, HEVCFrame *ref,
                                 const Mv *mv, int y0, int height)
 {
-    int y = FFMAX(0, (mv->y >> 2) + y0 + height + 9);
+    if (s->threads_type == FF_THREAD_FRAME ) {
+        int y = FFMAX(0, (mv->y >> 2) + y0 + height + 9);
 
-    if (s->threads_type == FF_THREAD_FRAME )
         ff_thread_await_progress(&ref->tf, y, 0);
+    }
 }
 
 static void hevc_luma_mv_mvp_mode(HEVCContext *s, int x0, int y0, int nPbW,