From patchwork Thu Jul 20 20:21:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 4399 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp57182vsb; Thu, 20 Jul 2017 13:22:37 -0700 (PDT) X-Received: by 10.223.175.5 with SMTP id z5mr7496532wrc.11.1500582157113; Thu, 20 Jul 2017 13:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500582157; cv=none; d=google.com; s=arc-20160816; b=VtMcWaJasHNvETesctw7KIR0lZSy6pQmSkESIekP/Rc3Roguq5X8upduc7bNfc0Eqj 2MCS5/INGlxsmSH2IkE6rBl/u2R6M3qVBMS1rg2BdCV3IYA4BFqVl6THf65x1vWDSRp3 5yuX643kV3uiuJn7t3UuICzl8Xi4VP9trtS3LJeI1qevCsJpHjlVnf7aMGe1WVPgrZan 9eQcArNkSiWt9fQbRuaCrJVNcRf3KkDBEYTfih4iw/yp9VM7kCCvUCt9wJQ7y+2gZl5W ZP507GNJUW4G2qtQjS84UfH+Ij+R3ULq3lShBuqjMj/sJKbxbUjjGd/ESNnIXztETj5t 18/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=n8a7MduxzvmTPzCVjtV3ipIDd7y6wpRrdJb1D0kWzcU=; b=EW+XWfeIZePMYjVot/c5373fPG5K7RRNYFUarIJw1dso2hUH7+Pz6ni1NXrrtt/H27 wTpWag8h337W9hRGF+/h8tIQR4cSJgkSIrHMaC6OG8SLcZg7SELO9pEm2S6Om2JNk9Pm iBXFf+WpvKFZHQLL/+0mVY1J1xdglBc/yRiLpadvQFNOxO3Bir8YKt3IMFlA7FxxuET/ ZK0c/JRgU+b4AX/HYtsrMX9Xg4o7CRgBYwd73wKowF8pfqoq+jpb8iJAPO4uFxX8B6tK lo/B6wWo3Ud6LVyFsiaseSvmnmOgdF3KOs9szCZw1814uK8QCPK/kOycogGCbRWbFtLn Boug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t5si2237941wme.83.2017.07.20.13.22.36; Thu, 20 Jul 2017 13:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C954A689AD5; Thu, 20 Jul 2017 23:22:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 753FA689A83 for ; Thu, 20 Jul 2017 23:22:19 +0300 (EEST) Received: from mfilter17-d.gandi.net (mfilter17-d.gandi.net [217.70.178.145]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 2EB0EFB883 for ; Thu, 20 Jul 2017 22:22:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter17-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter17-d.gandi.net (mfilter17-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id Db1Uhfqs9HOj for ; Thu, 20 Jul 2017 22:22:25 +0200 (CEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 82184FB8B1 for ; Thu, 20 Jul 2017 22:22:25 +0200 (CEST) Date: Thu, 20 Jul 2017 22:21:44 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20170720202144.GG3740@nb4> References: <1500457259-23469-1-git-send-email-t.rapp@noa-archive.com> <20170719122401.GA3182013@phare.normalesup.org> <32844f6e-8a36-4a91-52a0-5cb8311de470@noa-archive.com> <20170719150630.GA3247812@phare.normalesup.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Wed, Jul 19, 2017 at 05:23:07PM +0200, Tobias Rapp wrote: > On 19.07.2017 17:06, Nicolas George wrote: > >Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : > >>Indeed they are remainders from previous edits. It seems that stripping any > >>whitespace within the filter string is enough to ensure that it is passed as > >>one argument token to ffmpeg. So fixed locally. > > > >I suppose you left the quotes, otherwise the semicolon separates > >commands and the brackets are globbing patterns. > > Indeed, see attached patch for reference (WIP as it still contains > the CPUFLAGS work-around). > > >>>>+ -f null /dev/null > >>BTW: Is it OK to redirect output to "/dev/null" here or does this introduce > >>an unwanted platform dependency (i.e. blocks FATE from running on > >>MSYS/Windows)? > > > >With -f null, you can put anything you want there. I usually put -, but > >that is just a convenience to be able to change it to "-f fmt - | cmd". > > OK. > > Regards, > Tobias > fate/filter-video.mak | 16 ++++++++++++++ > ref/fate/filter-refcmp-psnr-rgb | 45 ++++++++++++++++++++++++++++++++++++++++ > ref/fate/filter-refcmp-psnr-yuv | 45 ++++++++++++++++++++++++++++++++++++++++ > ref/fate/filter-refcmp-ssim-rgb | 30 ++++++++++++++++++++++++++ > ref/fate/filter-refcmp-ssim-yuv | 30 ++++++++++++++++++++++++++ > 5 files changed, 166 insertions(+) > ba25d086250183b279c65419343103872074dab8 0001-fate-add-tests-for-psnr-and-ssim-filter.patch > From 430a2c8cfb455cbd11af119987fffa0919f71cc5 Mon Sep 17 00:00:00 2001 > From: Tobias Rapp > Date: Tue, 11 Jul 2017 12:38:06 +0200 > Subject: [PATCH] fate: add tests for psnr and ssim filter > > Signed-off-by: Tobias Rapp on x86-32: Test filter-refcmp-psnr-rgb failed. Look at tests/data/fate/filter-refcmp-psnr-rgb.err for details. make: *** [fate-filter-refcmp-psnr-rgb] Error 1 [...] --- tests/ref/fate/filter-refcmp-psnr-yuv 2017-07-20 22:05:14.887394601 +0200 +++ tests/data/fate/filter-refcmp-psnr-yuv 2017-07-20 22:14:51.363406746 +0200 @@ -3,43 +3,43 @@ lavfi.psnr.psnr.y=24.67 lavfi.psnr.mse.u=339.38 lavfi.psnr.psnr.u=22.82 -lavfi.psnr.mse.v=705.41 +lavfi.psnr.mse.v=705.31 lavfi.psnr.psnr.v=19.65 -lavfi.psnr.mse_avg=372.23 +lavfi.psnr.mse_avg=372.20 lavfi.psnr.psnr_avg=22.42 frame:1 pts:1 pts_time:1 -lavfi.psnr.mse.y=236.74 +lavfi.psnr.mse.y=236.76 lavfi.psnr.psnr.y=24.39 lavfi.psnr.mse.u=416.17 lavfi.psnr.psnr.u=21.94 -lavfi.psnr.mse.v=704.98 +lavfi.psnr.mse.v=704.97 lavfi.psnr.psnr.v=19.65 lavfi.psnr.mse_avg=398.66 lavfi.psnr.psnr_avg=22.12 frame:2 pts:2 pts_time:2 -lavfi.psnr.mse.y=234.79 +lavfi.psnr.mse.y=234.83 lavfi.psnr.psnr.y=24.42 lavfi.psnr.mse.u=435.72 lavfi.psnr.psnr.u=21.74 lavfi.psnr.mse.v=699.60 lavfi.psnr.psnr.v=19.68 -lavfi.psnr.mse_avg=401.23 +lavfi.psnr.mse_avg=401.24 lavfi.psnr.psnr_avg=22.10 frame:3 pts:3 pts_time:3 -lavfi.psnr.mse.y=250.88 +lavfi.psnr.mse.y=250.91 lavfi.psnr.psnr.y=24.14 lavfi.psnr.mse.u=479.73 lavfi.psnr.psnr.u=21.32 -lavfi.psnr.mse.v=707.55 +lavfi.psnr.mse.v=707.54 lavfi.psnr.psnr.v=19.63 -lavfi.psnr.mse_avg=422.26 -lavfi.psnr.psnr_avg=21.88 +lavfi.psnr.mse_avg=422.27 +lavfi.psnr.psnr_avg=21.87 frame:4 pts:4 pts_time:4 -lavfi.psnr.mse.y=241.05 +lavfi.psnr.mse.y=241.04 lavfi.psnr.psnr.y=24.31 lavfi.psnr.mse.u=505.04 lavfi.psnr.psnr.u=21.10 lavfi.psnr.mse.v=716.00 lavfi.psnr.psnr.v=19.58 -lavfi.psnr.mse_avg=425.79 +lavfi.psnr.mse_avg=425.78 lavfi.psnr.psnr_avg=21.84 Test filter-refcmp-psnr-yuv failed. Look at tests/data/fate/filter-refcmp-psnr-yuv.err for details. make: *** [fate-filter-refcmp-psnr-yuv] Error 1 make: *** Waiting for unfinished jobs.... --- tests/ref/fate/filter-refcmp-psnr-rgb 2017-07-20 22:05:14.887394601 +0200 +++ tests/data/fate/filter-refcmp-psnr-rgb 2017-07-20 22:14:51.367406746 +0200 @@ -1,11 +1,11 @@ frame:0 pts:0 pts_time:0 -lavfi.psnr.mse.r=1381.80 +lavfi.psnr.mse.r=1381.38 lavfi.psnr.psnr.r=16.73 lavfi.psnr.mse.g=896.00 lavfi.psnr.psnr.g=18.61 lavfi.psnr.mse.b=277.38 lavfi.psnr.psnr.b=23.70 -lavfi.psnr.mse_avg=851.73 +lavfi.psnr.mse_avg=851.59 lavfi.psnr.psnr_avg=18.83 frame:1 pts:1 pts_time:1 lavfi.psnr.mse.r=1380.37 @@ -17,9 +17,9 @@ lavfi.psnr.mse_avg=930.67 lavfi.psnr.psnr_avg=18.44 frame:2 pts:2 pts_time:2 -lavfi.psnr.mse.r=1403.20 +lavfi.psnr.mse.r=1403.21 lavfi.psnr.psnr.r=16.66 -lavfi.psnr.mse.g=954.05 +lavfi.psnr.mse.g=954.04 lavfi.psnr.psnr.g=18.34 lavfi.psnr.mse.b=494.22 lavfi.psnr.psnr.b=21.19