From patchwork Sat Jul 22 14:02:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Faiz X-Patchwork-Id: 4425 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp2167875vsb; Sat, 22 Jul 2017 07:03:11 -0700 (PDT) X-Received: by 10.28.135.193 with SMTP id j184mr92940wmd.96.1500732191059; Sat, 22 Jul 2017 07:03:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500732191; cv=none; d=google.com; s=arc-20160816; b=cTqKxAlYZuYgYq8QIT8FmK3/Cp8Ev6X19uwgbqM2aCkNy3I8JzjL5LqkAJSFIC7a2Z woMTHAsnMMe1zcIr7lpoQOuJE4huGjEtxCXfO4LWMsVIgpxuktx9ijg8sm//hHrbylHA mViEg9kXGElpUA4IJg9a0TTC1YXKGB3NZ86R5RcdQ0gzzeTcGWV8hM0W2wqZS6IHVMea yVf6A5d/dpWjQUbepdoMd8D7AYnIAce5lQGK/Xonb4W+stGT5XkrGRrD91VhbjdRGCMC 18F/w+xWDETPEcpoaMzATPi7LqyCzZKrud0CWxb3XhpZonPtWUfLPeE1tJvMvWZVRSie dk7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=GPztVYeFaG3fEssPWb7dbOM8pChm6q+SkIgtsr/5KX4=; b=COk8DKmMpFHkOXFBRxtzzduEnNsFTDblbG14Jc3OcYKtKnC3NIB0dyCzb849ll2uRN jrwoxIFfu7AOAkwI1lM1vyDI5jA8GKy4EYeTlpnMZcOBy0VzmP5pPlIE6o36WridssYu 6A/a7Gn0tSjYhlI9bHE2OXg5q+n+IqBH8Pa6iZmOCgzi422PsujJQDEr/UcQBr0HzkRb mLmyS4k3+lqMOTxUzdnBk/ovrPz+svjLYtl55TMx8DCakZIhudZ2+i2Y+4Zf6R380DCy Mb6qcdW/M5wcmAlZ4mX2MJuBgxLM2AOBxPxeaxuT3xShOc3kaMK6Rj2AJgMb0/lWHKUn xgzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=OdRfJm9I; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v187si786948wme.237.2017.07.22.07.03.10; Sat, 22 Jul 2017 07:03:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=OdRfJm9I; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5AC7F689A33; Sat, 22 Jul 2017 17:02:59 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA9E06882CD for ; Sat, 22 Jul 2017 17:02:52 +0300 (EEST) Received: by mail-pg0-f67.google.com with SMTP id y129so7642187pgy.3 for ; Sat, 22 Jul 2017 07:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KkTIQoFJdVFU0K4WJjWpg1IlGwnpbc3Vq5qniZGljwc=; b=OdRfJm9IwqFleL65WfDKNNswU0k/FxQegmNXccCt3y/C68pWRCKi1vS/Ws9QCG9TLn RgiIZ7vmsYROLqAC7Bk4RkUfycyZs8UwUJbolZ9y+BUP6X0JC9wVCkdo2vGqkm1LiRth lwSVjcmahX6tMfN0U76+nvB05O3Lt9nGqowpj4AqeXwVJVtB5hgsaw8Xm/19x4x2tt2E 0ra+LihQFuEXRXuGk2n3dkOeI/Iuu44boW2KONYaPCw/FKfNu3pYllXx+u86zTpm98rD khWokxFmd4jHdNn4KkzqQBCtu0PwX7wSYy6FLgpBRjUtwVvnBwTPCaDE9Vvjsx0q6kYa J68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KkTIQoFJdVFU0K4WJjWpg1IlGwnpbc3Vq5qniZGljwc=; b=lNzqj9aTIp/OtdvV5TSbzJZX8CvJOZIEJ/e0b2D8Ao7JDwtPKeE91Mz9nU6W/qMBrB W/PiemPIlnM8xSsVC2VvI5+1l83pdvL4TJ7WTorstAyIW+KxDNyYsDXxQef+/qpjD3l/ TQQTA/R9E8rry6mPWRwMVer8NM8ML7uFYH+/cnUJt9DIpfcCcPXwAwWW3BTNOJ5S3FnQ iGkY0YKg9qO3ILTn5d/ga9JHwZnkbO/YFRxbPubNS82gOLPvu4klAUjrZgOtv4wqDyRg /jwBVSlLGF7+pgySz/97HkBlyhc3gj0INgLXNpu9trLYfXdLjqDy0OqtZACCbtLs/cq1 +3cw== X-Gm-Message-State: AIVw1116M8cU/fAXk3mrtff+toOUCG+57Cxe4Izv/OkBkBuk9ezUVIR9 TB0MERXOlTP5IoXT X-Received: by 10.99.53.65 with SMTP id c62mr10523877pga.304.1500732179779; Sat, 22 Jul 2017 07:02:59 -0700 (PDT) Received: from localhost.localdomain ([114.124.145.225]) by smtp.gmail.com with ESMTPSA id s206sm13869709pfs.55.2017.07.22.07.02.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jul 2017 07:02:58 -0700 (PDT) From: Muhammad Faiz To: ffmpeg-devel@ffmpeg.org Date: Sat, 22 Jul 2017 21:02:32 +0700 Message-Id: <20170722140232.962-1-mfcc64@gmail.com> X-Mailer: git-send-email 2.13.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Muhammad Faiz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The behaviour is based on assumptions: - copying audio data is cheap, so keeping data alignment is cheap, - copying video data is not cheap, so keeping data alignment is not cheap, e.g. crop filter. Should fix Ticket6349. Note that after fc3a03fcf9cd7eafe7342e2508e6128888efa0bb, the crash has been fixed. Signed-off-by: Muhammad Faiz --- libavutil/frame.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index 26261d7e40..1b08eec231 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -202,6 +202,9 @@ typedef struct AVFrame { * up to 16 bytes beyond the planes, if these filters are to be used, * then 16 extra bytes must be allocated. * + * For audio, the data should be aligned to CPUs alignment preference. + * For video, no restriction on the alignment. + * * NOTE: Except for hwaccel formats, pointers not needed by the format * MUST be set to NULL. */