From patchwork Wed Sep 6 09:58:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgQsWTc2No?= X-Patchwork-Id: 5005 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.15.201 with SMTP id 70csp384440jao; Wed, 6 Sep 2017 02:58:16 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5WBm3VkQZFrWLjEZnoDrtRi5bGf+/H8DYd9SgKQzjtQB2j/kS8z9h5JiP2MW0XSrzrB+6i X-Received: by 10.28.24.138 with SMTP id 132mr1188833wmy.61.1504691896709; Wed, 06 Sep 2017 02:58:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504691896; cv=none; d=google.com; s=arc-20160816; b=fWyWj1XbS1AxMgJv9kA4RdjJuZ98x1RzDE8GnAlBs79uauIRcp771nLNKNMAAMbUco D3YcIgXdRFdPAtvkLqB8+rgooqvGMjZYAwFuIocbnlnM3I6FpQcwUEiZLhilXO3LxY1E e8VJCDhxdcrjf1cikPiSQxlgdcVT9sMm6s1rwOy4orVNxB7/Cd8Hdvj1X3S3FKihmG42 nWznZfpIFmu/osuyXg5YQXioc/OpkuVH27df/6c9J/ndr9JGpgnp+YxSPRBZ6sMiWKgT D9PnJRCXPZbC4R3Uxtc4X+YrXUqt8s0YKrS7gNFvPyQ5HBZB56i6DU8XMIQSuTvnwXFB hUQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :domainkey-signature:dkim-signature:delivered-to :arc-authentication-results; bh=cgGOo0ZFGCpfRCYUKlWqiCC7FKMSsxJYgMVt8H/oPfc=; b=ykMYZFR1GfHmTAnQcqcEMkr5mB+2E9BFMI/JB9o74J1HnjnmCpZFPUbIF3Qjo57IqD cLuc9BSQauYGDTqNY8FmeBDnspMuXuXd1PfaLfc8uzPk5hQk2mVWeSsIe4lOTYFxEIAF T/uJ/PCVLb6tOyKBY7gkBekJw2XE/54tHslaG/l4hcXS1jPeph2556HFuS/BExKiQicV i4sFXLVa+eKuP5U9sqWlHsiHB6Ltmmqz4oh8rY0Z1PfNKGDCaUg+rQ+x2zr65efZ9cSb CoedAryu/TUkjmgK90Gw6+69Fm9sxw3aTSKVToS06z3iZh3xLi+mnjOl11IsDicRZX0A 528Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@pkh.me header.s=selector1 header.b=eYPCgeYg; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k190si842367wme.246.2017.09.06.02.58.16; Wed, 06 Sep 2017 02:58:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@pkh.me header.s=selector1 header.b=eYPCgeYg; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F35D368A2C7; Wed, 6 Sep 2017 12:58:11 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from golem.pkh.me (LStLambert-657-1-117-164.w92-154.abo.wanadoo.fr [92.154.28.164]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 481A368A106 for ; Wed, 6 Sep 2017 12:58:06 +0300 (EEST) Received: from golem.pkh.me (localhost.localdomain [127.0.0.1]) by golem.pkh.me (OpenSMTPD) with ESMTP id 346b16b8; Wed, 6 Sep 2017 09:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pkh.me; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=selector1; bh=zjy4jajGFsc6wqnJxlc8 3p29HW8=; b=eYPCgeYgdiwfdCO2qpoTyt61putNu5QxlA6hDNOd/5RU/eNwNeD+ eR0BbNbq2jMgZEFS1xuhlGQqj7MPo/KHtqrE/+vMHiAtbUUVoLdAAeTLeW+3Vs3n o8Yc6qGGTzGg0aPNZexOQyTwUNkE3xfrNv/qGuWQJwd1Nlkn6ErtDF4HCTaEPaEV O3cT/ssSlMj/Ve/w670N5i6VPs3YIhYKd9h3GQM00eEffnRb3a44Da8gU02Uensu 5ny8PL1nKRuRCkuRwIotqvbBn7kuvgwwBckonPvXXbeT0uJBQ4ePGvZdtShmStkK J6u5ojBH3Q3DYpCfl480PzPC1ojmE10lwA== DomainKey-Signature: a=rsa-sha1; c=nofws; d=pkh.me; h=from:to:cc:subject :date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=selector1; b=sCJNxMLSIsycLh bVFR3YX4LTeWhjbZweXP+Dv5XdX12cQaETdUpfk7I4gfF2L697mRtjnWLlv4d45Q wrAAx1GWUqUCx2BFV6c6bGojE9ltpj09tdmRibg08TUvbtxnrnBA68HmM81CUZG+ /YoB2lkwzm8IL6zViCW9c6Z1kx4xRf/mdrwcLX1tMznsG0M6NwA2uOiA5LIw4tV2 fbMumOsSC08aia+jGj2D5az3KzOiJky2ms/xLKwL9DIABAEGXDDiBI0ENSmYaEnP p982NFlhoSdumD+54vZunM+0z+wy9RzB9kujd4GhyvYh96fHf0YcUHi76v7wDacz G8j5BMtg== Received: from localhost (golem.pkh.me [local]) by golem.pkh.me (OpenSMTPD) with ESMTPA id 51302c38; Wed, 6 Sep 2017 09:58:08 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 6 Sep 2017 11:58:00 +0200 Message-Id: <20170906095806.3070-1-u@pkh.me> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/7] build: fix objcc header check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Clément Bœsch $headers is a variable set in the context of other functions (we don't use the "local" keyword in our scripts, so those variables are global). Currently, when checking for AVFoundation/AVFoundation.h, the actual enabled header is math.h. Similarly, when testing for QuartzCore/CoreImage.h, the actual enabled header is CoreGraphics/CoreGraphics.h. This is completely broken and may be the reason why these checks are made in random places. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2f3fa2ba3d..54fe846fea 100755 --- a/configure +++ b/configure @@ -1117,7 +1117,7 @@ check_header_objcc(){ { echo "#include <$header>" echo "int main(void) { return 0; }" - } | check_objcc && check_stat "$TMPO" && enable_safe $headers + } | check_objcc && check_stat "$TMPO" && enable_safe $header } check_func(){