From patchwork Tue Sep 26 00:36:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 5270 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp3225643jaa; Mon, 25 Sep 2017 17:36:56 -0700 (PDT) X-Received: by 10.28.66.65 with SMTP id p62mr1639489wma.159.1506386216661; Mon, 25 Sep 2017 17:36:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506386216; cv=none; d=google.com; s=arc-20160816; b=rc1urYyrfdTQU75k6qjiYbHbyBaoZp+TfkupCnESJbqH+qrWWdciMsFie/x2Bnk9YW PXWB13UK6abbTm21qdR01306iy4qR24tEnA0eBM8zad1XSimf4xULEJCL+9+Z2ugSe1C 4H/BNsGKSAkL+y4ejDakNVV8qgF6LhAjpFqS3J87wVs/nW3r3WEsWMd6tV0cHYX85r1s GKy0Cr5AwUUWXpdKejKKK/rF5+e5pw0n06f/FYQOFEiUW+Cx3IZqrog+ihMOSD5CePKk WU6cPE9Q8lGhPq6cpL1Quri23YY2FyiUBVWwIvYte2j0Yl+dXlXEW/d9udk4OwmmXRi3 p5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=2Tig5AKsijufZhuVQKbNJ3yAXf1Wr8IbfmI405ocA8I=; b=ra3nlEiga96DQqe/MTGxOk+ohb5WAWvCZMwxkWMSdO1D2NmVMVuq1pR41qkQmgVRQf R/e3Ar3Ssli1jNY+VOh+LXQQQt/UINfD6hcgpDK7u2GHbErZoTBC2KYc4ZNSnQ1ZDUBo D9yAl2n1MgItGV3Nvf5A2rjn9WYsPD6+FPUbw3u7PS9c5ppraLCFZXsysWpMaG4AxKhJ 2kWBOQZ/DH3nwoMrwd+Fjl2+TTfCNqcd+Xs6OsUfy+sh543t9XjPFIZydHQkZcs0NsHN 15DPdDiiMw+D9m7dLJ7KdEPSJwlYz0oztHsPfdfwP12Nbjuv1Haa/MiqZe2ATGDmc68h sRTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@tmm1-net.20150623.gappssmtp.com header.s=20150623 header.b=NZhNeUUz; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l7si5777754wrf.26.2017.09.25.17.36.56; Mon, 25 Sep 2017 17:36:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@tmm1-net.20150623.gappssmtp.com header.s=20150623 header.b=NZhNeUUz; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 752C9689AA2; Tue, 26 Sep 2017 03:36:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 79392688395 for ; Tue, 26 Sep 2017 03:36:37 +0300 (EEST) Received: by mail-pf0-f177.google.com with SMTP id z84so4686624pfi.2 for ; Mon, 25 Sep 2017 17:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tmm1-net.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0YwARSaaZXbN79FfsJDhVDJfyANsdefD+ABaOs7Ijd0=; b=NZhNeUUzuZ6D051cjMkNy9ZKrYEwfo2oWpLO6toflQJpY24Iwn4sIpwdP85iCbC5mb b57miUgF/g52JrPHIJKRc5EYmxYwzrZchU3vn4is+nYQxGpYBPZZhjXL1vF5bGTNTILY LtsacOCprkATM0R0NRyP0wQvp/U5zkwkSiUh+NhOKhVvmeHWu8J9jkEml0ZlZOMqeI6R U8vxyoRc8fJSPqSC03Con1UzkOkJTE/zzMN3KjfBXB+TjXsnIVdUoksD/5VpqfEY+eFr UummuLCFEOpJG66nFiQ6dNoRxoWJdYa73cp3QvojLwxNOtvu3+f2qnEcqab3iHkoJJ7y uwcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0YwARSaaZXbN79FfsJDhVDJfyANsdefD+ABaOs7Ijd0=; b=tG/WEFVM2Uox2XvXExISsYydHKV/157NylSRw/vTDCw2y10/dd1zUDGFBoAhUEyel7 rCMum2hVVytv+83x+brSaXBo8vCwnMSdOU7DRPZvecIcHLfSjqBzrJZ/XiGJUB6X7q9y i+ulO8SLryWjESBkilX7ruEfFT5BKt9O/Inub96mZUtWHDzUfEscj3A1W3Jv+574Z33P w5VsFdr3vAhaUpWl8FPuUN3ozwLiiGj+8ScD4oXX19q4VmI3m+i61km5aM/dstSuAtw2 hZaqGtiETiCKXGI8InWddB3DUrnYWHdzgUG9ODYi4rEUinMavNj1dgPgfPGddxVJXnhM Gusg== X-Gm-Message-State: AHPjjUiUczYWF2C3UIrDpnYLEQSHe68udl0xbv3GfU+mVrh0RmqYAOef PaT1iolB5JNDN/wkvnvTsXmv/YTK X-Google-Smtp-Source: AOwi7QAtXIm4mJMTLKaZ8nKKZmJWOJBnME9HEzGWmV8xzUEUjF4tdTiEffJztshpL/V/Sd+nb0n/Kw== X-Received: by 10.84.238.143 with SMTP id v15mr9397367plk.303.1506386207658; Mon, 25 Sep 2017 17:36:47 -0700 (PDT) Received: from tmm1-macbook.local.net (c-73-252-174-83.hsd1.ca.comcast.net. [73.252.174.83]) by smtp.gmail.com with ESMTPSA id n18sm12483164pgd.69.2017.09.25.17.36.46 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 25 Sep 2017 17:36:47 -0700 (PDT) From: Aman Gupta To: ffmpeg-devel@ffmpeg.org Date: Mon, 25 Sep 2017 17:36:27 -0700 Message-Id: <20170926003631.55571-5-ffmpeg@tmm1.net> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20170926003631.55571-1-ffmpeg@tmm1.net> References: <20170926003631.55571-1-ffmpeg@tmm1.net> Subject: [FFmpeg-devel] [PATCH 5/9] avcodec/videotoolbox: print descriptive errors on decode failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Aman Gupta MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Aman Gupta --- libavcodec/videotoolbox.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 1de556f3e8..f56ab1f8c9 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -425,7 +425,22 @@ static int videotoolbox_common_end_frame(AVCodecContext *avctx, AVFrame *frame) status = videotoolbox_session_decode_frame(avctx); if (status) { - av_log(avctx, AV_LOG_ERROR, "Failed to decode frame (%d)\n", status); + const char *error = NULL; + switch (status) { + case kVTVideoDecoderBadDataErr: + error = "bad data"; + break; + case kVTVideoDecoderMalfunctionErr: + error = "decoder malfunction"; + break; + case kVTInvalidSessionErr: + error = "invalid session"; + break; + default: + error = "unknown"; + break; + } + av_log(avctx, AV_LOG_ERROR, "Failed to decode frame (%s, %d)\n", error, status); return AVERROR_UNKNOWN; }