From patchwork Sun Oct 8 20:01:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 5469 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp1906149jah; Sun, 8 Oct 2017 13:04:03 -0700 (PDT) X-Received: by 10.223.134.93 with SMTP id 29mr8212542wrw.60.1507493043524; Sun, 08 Oct 2017 13:04:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507493043; cv=none; d=google.com; s=arc-20160816; b=a1NTed3Ezvire2gMhp8DQ4rxpPEMYBc2aTWa1VMjzfibldfOLMs87G6RCZhhiTeyhM ir+Lci2eLKISZKrK9qXGwMCqIZOWoossCnRAd5vfrrNiXrPfS6N93IJNf3qT6a86j+xI P1k3ziwcWIijDA9hIxYnSoZ42HsI/XSiCJ7lBgSWUtAO+5tC1HntGu31UI5n4m3vtRrj SioEVKE0k9WCZaoj9rbPGxtGLOTx9juxtev0xGfOEoYdeYGjxMKm9erzhCK0Z87hKsZq YlCI6dlcs7eF1ZNurld8KyXNZgapGMZyf/Gl5Z/lvCjlZsEJ7ojZLOMKdFwMqmBR9dom 2KlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=7soa7XwoupYBQai4wYS9YrTZ2//LfJP9z/ODkPk9fX0=; b=EM4LXQ3XZ+ERfbr/OEdjgB1DWMOylHEo9dZioiSP8xGldqmrbz27xPXI1zrSqWaCH4 qQ3WRXBuoqL6aWLcs6aNM7X4kfMrcVPECb1AXXsEtKdgr5axFaj5s2L7vW8Z3+W2Cn1n NKc+G5iMSabANbE3+DX6NKWMLWY6ui0h3hbNt+hllrANifdeWHGFH2XSfOuQYIsUNDEU lEmXCj4lEAjUq9PyX9IjiLdAZ+qo3C5lS7gWuCayKxkcgYE3c+st7S6HG/nJWLb6PEV8 0F3ngcfD+MoisVoSKDtTqtar6yKH0KeUvUNI1J58mknfjhxU4s5v77hlyjmXAmGmp0mD ycUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=gW3dBBb5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a137si5502490wme.11.2017.10.08.13.04.03; Sun, 08 Oct 2017 13:04:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=gW3dBBb5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B10A0689E56; Sun, 8 Oct 2017 23:02:11 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2EB6C689DCB for ; Sun, 8 Oct 2017 23:02:04 +0300 (EEST) Received: by mail-wm0-f45.google.com with SMTP id 196so8906931wma.1 for ; Sun, 08 Oct 2017 13:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=Ngsy9ebOI5433IjZvejyKonM1YbYNRcJhkmMMmKKzPc=; b=gW3dBBb5ng8lS2yHngWvzLm9BxQwT2en4C/Xs04Podzxc/borD3GMt4UXS9yIe6LZ6 fJnnUUFR8Y68Bb9SBhE/jllKSWjflhUjLlEB5MEZbllT5OaUbU2K6EdYT+3WM2F/mwzZ JFazIw3s+w9bTvQNT0yWit+UI68q8vjlhk1Ej1b/YEY9DuUQAyrqbexMWcP7/dm4q7C3 7cBGNIfmbJSY6ogyE8RMCA8NtFRoG5xs1rIyC7uxLdDd3ll3o7Ke9EZD/IcQEUSxv3aL /19NW0YJ0leForHNL3Ag55UoZSrcJJGT7bcKzF94m5nIERt/UqpLQguRQoIirgZznNH8 7INQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Ngsy9ebOI5433IjZvejyKonM1YbYNRcJhkmMMmKKzPc=; b=dGGEjTH0d6vtXhjp/BAB/5fMis81PzCxbIbrAQsu1urk8+wVVRp826gSfTr8PnTojd QaT+wxxOYdNvV2W3QE9FF70dOmA67IHJqve8wDF5aTauRN3wdfyYi07hPSpilNExpILF LjUKH3dhtuwq2giSSdExjPJoaOrb7UxIsXkSpxs1/xKFn3YmPQRbmD8jiBPZN6iGTbjQ 1mUEVdlODTgr7hIsNnu7BEldADScgn9I4Bbt6j9v4knRrNgoIBqnYvy6JTAaXhopBVOM yX6yGOyU3jR/mp4CwxwM7ZHWZFx3IETOIbtV3o5P3JxXCI6BqSMq6MlYb9pVQC4L69af hBEg== X-Gm-Message-State: AMCzsaVHiT5LtLkc11Swo/pv5BdzAt8+jpeXuNDX9KYYliWgWzA26+5W NB5ylBBXl969gfQr/Lah19sbjjXc X-Google-Smtp-Source: AOwi7QBL5t3/kZEh5nZCv+j6VvTvXbeTF/04RysNfBzT5hH2caykJdN3+Z7JqHMxb1iL+P0sgkBaXw== X-Received: by 10.223.145.41 with SMTP id j38mr6826361wrj.133.1507492925215; Sun, 08 Oct 2017 13:02:05 -0700 (PDT) Received: from rywe.jkqxz.net (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id x49sm2897856wrb.25.2017.10.08.13.02.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2017 13:02:04 -0700 (PDT) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Sun, 8 Oct 2017 21:01:41 +0100 Message-Id: <20171008200154.4873-8-sw@jkqxz.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171008200154.4873-1-sw@jkqxz.net> References: <20171008200154.4873-1-sw@jkqxz.net> Subject: [FFmpeg-devel] [PATCH 07/20] lavc: Add trace_headers bitstream filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Supports all streams that the coded bitstream infrastructure does (currently H.264, H.265 and MPEG-2). (cherry picked from commit f11d8a5e8b185340cc50fcbc8a1437b0fbe7e931) --- configure | 1 + doc/bitstream_filters.texi | 8 +++ libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/trace_headers_bsf.c | 126 +++++++++++++++++++++++++++++++++++++++++ 5 files changed, 137 insertions(+) create mode 100644 libavcodec/trace_headers_bsf.c diff --git a/configure b/configure index 37efffac86..70402c03d0 100755 --- a/configure +++ b/configure @@ -2906,6 +2906,7 @@ vc1_parser_select="vc1dsp" # bitstream_filters mjpeg2jpeg_bsf_select="jpegtables" +trace_headers_bsf_select="cbs_h264 cbs_h265 cbs_mpeg2" # external libraries aac_at_decoder_deps="audiotoolbox" diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 2dffe021f9..990b4f3c58 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -275,6 +275,14 @@ codec) with metadata headers. See also the @ref{mov2textsub} filter. +@section trace_headers + +Log trace output containing all syntax elements in the coded stream +headers (everything above the level of individual coded blocks). +This can be useful for debugging low-level stream issues. + +Supports H.264, H.265 and MPEG-2. + @section vp9_superframe Merge VP9 invisible (alt-ref) frames back into VP9 superframes. This diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 0265c92130..5e09889bc6 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1028,6 +1028,7 @@ OBJS-$(CONFIG_NOISE_BSF) += noise_bsf.o OBJS-$(CONFIG_NULL_BSF) += null_bsf.o OBJS-$(CONFIG_REMOVE_EXTRADATA_BSF) += remove_extradata_bsf.o OBJS-$(CONFIG_TEXT2MOVSUB_BSF) += movsub_bsf.o +OBJS-$(CONFIG_TRACE_HEADERS_BSF) += trace_headers_bsf.o OBJS-$(CONFIG_VP9_RAW_REORDER_BSF) += vp9_raw_reorder_bsf.o OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) += vp9_superframe_bsf.o OBJS-$(CONFIG_VP9_SUPERFRAME_SPLIT_BSF) += vp9_superframe_split_bsf.o diff --git a/libavcodec/bitstream_filters.c b/libavcodec/bitstream_filters.c index ce34de640d..dd0247182b 100644 --- a/libavcodec/bitstream_filters.c +++ b/libavcodec/bitstream_filters.c @@ -41,6 +41,7 @@ extern const AVBitStreamFilter ff_noise_bsf; extern const AVBitStreamFilter ff_null_bsf; extern const AVBitStreamFilter ff_remove_extradata_bsf; extern const AVBitStreamFilter ff_text2movsub_bsf; +extern const AVBitStreamFilter ff_trace_headers_bsf; extern const AVBitStreamFilter ff_vp9_raw_reorder_bsf; extern const AVBitStreamFilter ff_vp9_superframe_bsf; extern const AVBitStreamFilter ff_vp9_superframe_split_bsf; diff --git a/libavcodec/trace_headers_bsf.c b/libavcodec/trace_headers_bsf.c new file mode 100644 index 0000000000..93d04cb509 --- /dev/null +++ b/libavcodec/trace_headers_bsf.c @@ -0,0 +1,126 @@ +/* + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include + +#include "libavutil/avstring.h" +#include "libavutil/common.h" +#include "libavutil/log.h" + +#include "bsf.h" +#include "cbs.h" + + +typedef struct TraceHeadersContext { + CodedBitstreamContext *cbc; +} TraceHeadersContext; + + +static int trace_headers_init(AVBSFContext *bsf) +{ + TraceHeadersContext *ctx = bsf->priv_data; + int err; + + err = ff_cbs_init(&ctx->cbc, bsf->par_in->codec_id, bsf); + if (err < 0) + return err; + + ctx->cbc->trace_enable = 1; + ctx->cbc->trace_level = AV_LOG_INFO; + + if (bsf->par_in->extradata) { + CodedBitstreamFragment ps; + + av_log(bsf, AV_LOG_INFO, "Extradata\n"); + + err = ff_cbs_read_extradata(ctx->cbc, &ps, bsf->par_in); + if (err < 0) { + av_log(bsf, AV_LOG_ERROR, "Failed to read extradata.\n"); + return err; + } + + ff_cbs_fragment_uninit(ctx->cbc, &ps); + } + + return 0; +} + +static void trace_headers_close(AVBSFContext *bsf) +{ + TraceHeadersContext *ctx = bsf->priv_data; + + ff_cbs_close(&ctx->cbc); +} + +static int trace_headers(AVBSFContext *bsf, AVPacket *out) +{ + TraceHeadersContext *ctx = bsf->priv_data; + CodedBitstreamFragment au; + AVPacket *in; + char tmp[256] = { 0 }; + int err; + + err = ff_bsf_get_packet(bsf, &in); + if (err < 0) + return err; + + if (in->flags & AV_PKT_FLAG_KEY) + av_strlcat(tmp, ", key frame", sizeof(tmp)); + if (in->flags & AV_PKT_FLAG_CORRUPT) + av_strlcat(tmp, ", corrupt", sizeof(tmp)); + + if (in->pts != AV_NOPTS_VALUE) + av_strlcatf(tmp, sizeof(tmp), ", pts %"PRId64, in->pts); + else + av_strlcat(tmp, ", no pts", sizeof(tmp)); + if (in->dts != AV_NOPTS_VALUE) + av_strlcatf(tmp, sizeof(tmp), ", dts %"PRId64, in->dts); + else + av_strlcat(tmp, ", no dts", sizeof(tmp)); + if (in->duration > 0) + av_strlcatf(tmp, sizeof(tmp), ", duration %"PRId64, in->duration); + + av_log(bsf, AV_LOG_INFO, "Packet: %d bytes%s.\n", in->size, tmp); + + err = ff_cbs_read_packet(ctx->cbc, &au, in); + if (err < 0) + return err; + + ff_cbs_fragment_uninit(ctx->cbc, &au); + + av_packet_move_ref(out, in); + av_packet_free(&in); + + return 0; +} + +static const enum AVCodecID trace_headers_codec_ids[] = { + AV_CODEC_ID_H264, + AV_CODEC_ID_HEVC, + AV_CODEC_ID_MPEG2VIDEO, + AV_CODEC_ID_NONE, +}; + +const AVBitStreamFilter ff_trace_headers_bsf = { + .name = "trace_headers", + .priv_data_size = sizeof(TraceHeadersContext), + .init = &trace_headers_init, + .close = &trace_headers_close, + .filter = &trace_headers, + .codec_ids = trace_headers_codec_ids, +};