From patchwork Fri Oct 27 01:38:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 5711 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp163944jah; Thu, 26 Oct 2017 18:39:01 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TJ/NY7YF4LrCEXX5v/tKfkRU4F/0uJ0YlP1HYfLinzzPnwj+IhtkXaUlv5xOStXqrA3N3V X-Received: by 10.28.6.14 with SMTP id 14mr484004wmg.37.1509068341326; Thu, 26 Oct 2017 18:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509068341; cv=none; d=google.com; s=arc-20160816; b=nHbIXA3KTn91+PHWO+SPJD86STzDj0+v8x21h5giLhoSp6XB16++X2tbQz4DkFN0PV R7GpJcQizI0rmtJADOkJz8lCzqWmo0j5JTh95rRgjuL3+qq09EMhu/5aFP+dbaPE/eGD wx173TldxMY3FSyuJXSnPjSlwBDIYPuOPyIo3KTAaTiCbmnD1/73M9go8jX00U1N0BsD XchuiuVQSl4X0BMrlUbDEAFuer2CGHQVfyD6eCu/zCWoRzeBkCxWuyzWSYAldC5hQmUh oTszQjURNU5mfWpfeIpVozhmy14hyaIpKwM4dhiqSkYkFsjK2DNpJm1IOMl774UFpaRU Yeog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=0sOW9JSEXyZiB8Y12/ttyjhQJDOj/hltd8h2OBjlfTc=; b=IT3pOHQbWD6fn9LuHxEC0dagvZEoRn5pib/ym/fJ/Tn4UcRWh4Pcd3/PGDhghu+Ymd Xks+Rn6CK0ykyx0A4SIJNJJaexPI2ElVLvu66j8axZbd3Q0ieQVoqyEJzcRPCmEPx5Vv LXacLaffZAg970CCj6ZUHcKTAgWjl3fFtPoaWjePBk7c5Nppc6eAu/9Beefcga4H1bmn viPg8WiEJnzE7Utu0TSeDlXqHZRq50U/xhVYRTNHBJKqRp7g9pfjT8HjPJ43Sb28e8q+ hu5UwqHlJSmvu+mmwXIIBn4rCSLGnUEC+qMT0kyOBSUHbt+PTz1mVuSa3kr83d/aAE3H fojA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c193si424813wmh.99.2017.10.26.18.39.00; Thu, 26 Oct 2017 18:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB8E568A256; Fri, 27 Oct 2017 04:38:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6085D68A1B6 for ; Fri, 27 Oct 2017 04:38:44 +0300 (EEST) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 03ED9A80C1 for ; Fri, 27 Oct 2017 03:38:51 +0200 (CEST) Date: Fri, 27 Oct 2017 03:38:20 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20171027013820.GC6009@nb4> References: <20170619210845.20641-1-jonas.licht@fem.tu-ilmenau.de> MIME-Version: 1.0 In-Reply-To: <20170619210845.20641-1-jonas.licht@fem.tu-ilmenau.de> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Mon, Jun 19, 2017 at 11:08:45PM +0200, Jonas Licht wrote: > Subtract the calculated dts offset from the requested timestamp before > seeking. This fixes an error "Error while filtering: Operation not > permitted" observed with a short file which contains only one key frame > and starts with negative timestamps. > > Then, av_index_search_timestamp() returns a valid negative timestamp, > but mov_seek_stream bails out with AVERROR_INVALIDDATA. > > Fixes ticket #6139. > > Signed-off-by: Jonas Licht > --- > libavformat/mov.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) breaks make fate: either therers something wrong in the chnage or fate needs to be updated Test seek-extra-mp4 failed. Look at tests/data/fate/seek-extra-mp4.err for details. make: *** [fate-seek-extra-mp4] Error 1 [...] --- ./tests/ref/seek/extra-mp4 2017-10-27 03:04:37.457820255 +0200 +++ tests/data/fate/seek-extra-mp4 2017-10-27 03:32:10.625855082 +0200 @@ -28,10 +28,10 @@ ret: 0 st: 0 flags:0 dts: 50.666667 pts: 50.666667 pos:5927464 size: 150 ret: 0 st: 0 flags:0 dts: 50.700000 pts: 50.700000 pos:5927614 size: 176 ret: 0 st:-1 flags:1 ts: 153.470835 -ret: 0 st: 0 flags:1 dts: 153.466667 pts: 153.500000 pos:15867700 size: 96169 -ret: 0 st: 0 flags:0 dts: 153.500000 pts: 153.533333 pos:15963869 size: 785 -ret: 0 st: 0 flags:0 dts: 153.533333 pts: 153.633333 pos:15964654 size: 3135 -ret: 0 st: 0 flags:0 dts: 153.566667 pts: 153.566667 pos:15967789 size: 859 +ret: 0 st: 0 flags:1 dts: 151.966667 pts: 152.000000 pos:15705355 size:146924 +ret: 0 st: 0 flags:0 dts: 152.000000 pts: 152.100000 pos:15852279 size: 1355 +ret: 0 st: 0 flags:0 dts: 152.033333 pts: 152.033333 pos:15853634 size: 211 +ret: 0 st: 0 flags:0 dts: 152.066667 pts: 152.066667 pos:15853845 size: 217 ret: 0 st: 0 flags:0 ts: 76.365000 ret: 0 st: 0 flags:1 dts: 77.833333 pts: 77.866667 pos:8659657 size: 41182 ret: 0 st: 0 flags:0 dts: 77.866667 pts: 77.966667 pos:8700839 size: 4197 @@ -83,10 +83,10 @@ ret: 0 st: 0 flags:0 dts: 101.366667 pts: 101.366667 pos:11053072 size: 562 ret: 0 st: 0 flags:0 dts: 101.400000 pts: 101.400000 pos:11053634 size: 599 ret: 0 st:-1 flags:0 ts: 25.306672 -ret: 0 st: 0 flags:1 dts: 27.400000 pts: 27.433333 pos:2674605 size:127383 -ret: 0 st: 0 flags:0 dts: 27.433333 pts: 27.466667 pos:2801988 size: 68 -ret: 0 st: 0 flags:0 dts: 27.466667 pts: 27.500000 pos:2802268 size: 1754 -ret: 0 st: 0 flags:0 dts: 27.500000 pts: 27.533333 pos:2804022 size: 4071 +ret: 0 st: 0 flags:1 dts: 25.300000 pts: 25.333333 pos:2607246 size: 40273 +ret: 0 st: 0 flags:0 dts: 25.333333 pts: 25.433333 pos:2647519 size: 2959 +ret: 0 st: 0 flags:0 dts: 25.366667 pts: 25.366667 pos:2650478 size: 197 +ret: 0 st: 0 flags:0 dts: 25.400000 pts: 25.400000 pos:2650675 size: 230 ret: 0 st:-1 flags:1 ts: 128.200839 ret: 0 st: 0 flags:1 dts: 127.833333 pts: 127.866667 pos:13514072 size: 67382 ret: 0 st: 0 flags:0 dts: 127.866667 pts: 127.966667 pos:13581454 size: 2936